Patchwork qt4: add eglibc-gconv-utf-16 to QtCore RRECOMMENDS when using glibc

login
register
mail settings
Submitter Jonathan Liu
Date June 20, 2013, 1:19 p.m.
Message ID <1371734393-27665-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/52119/
State Accepted
Commit 2e9c8007bca684149d72e96423f30433b6665fad
Headers show

Comments

Jonathan Liu - June 20, 2013, 1:19 p.m.
This fixes the following warnings when running Qt applications:
QIconvCodec::convertFromUnicode: using Latin-1 for conversion, iconv_open failed
QIconvCodec::convertToUnicode: using Latin-1 for conversion, iconv_open failed

Qt's QString class stores strings internally using UTF-16 encoding.
The UTF-16 iconv module is needed to convert between the system's local
8-bit representation and QString's UTF-16 encoding.

For example, the following functions would be affected:
QString::fromLocal8Bit(...)
QString::toLocal8Bit(...)

If the UTF-16 iconv module couldn't be loaded, it would use Latin-1
encoding instead of the system's encoding for conversion.

[YOCTO #349]

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta/recipes-qt/qt4/qt4.inc | 1 +
 1 file changed, 1 insertion(+)
Paul Eggleton - June 20, 2013, 2:50 p.m.
On Thursday 20 June 2013 23:19:53 Jonathan Liu wrote:
> This fixes the following warnings when running Qt applications:
> QIconvCodec::convertFromUnicode: using Latin-1 for conversion, iconv_open
> failed QIconvCodec::convertToUnicode: using Latin-1 for conversion,
> iconv_open failed
> 
> Qt's QString class stores strings internally using UTF-16 encoding.
> The UTF-16 iconv module is needed to convert between the system's local
> 8-bit representation and QString's UTF-16 encoding.
> 
> For example, the following functions would be affected:
> QString::fromLocal8Bit(...)
> QString::toLocal8Bit(...)
> 
> If the UTF-16 iconv module couldn't be loaded, it would use Latin-1
> encoding instead of the system's encoding for conversion.
> 
> [YOCTO #349]
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta/recipes-qt/qt4/qt4.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-qt/qt4/qt4.inc b/meta/recipes-qt/qt4/qt4.inc
> index 828e30a..ebe0ea5 100644
> --- a/meta/recipes-qt/qt4/qt4.inc
> +++ b/meta/recipes-qt/qt4/qt4.inc
> @@ -134,6 +134,7 @@ FILES_${QT_BASE_NAME}-demos-doc =
> "${docdir}/${QT_DIR_NAME}/qch/qt.qch" RRECOMMENDS_${PN} = "${LIB_PACKAGES}
> ${OTHER_PACKAGES}"
>  RRECOMMENDS_${PN}-dev = "${DEV_PACKAGES}"
>  RRECOMMENDS_${PN}-dbg = "${DBG_PACKAGES}"
> +RRECOMMENDS_${QT_BASE_LIB}core4_append_libc-glibc = " eglibc-gconv-utf-16"
>  RRECOMMENDS_${QT_BASE_NAME}-demos += " \
>              ${QT_BASE_NAME}-examples \
>              ${QT_BASE_NAME}-plugin-sqldriver-sqlite \

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Thanks for fixing this.

Cheers,
Paul

Patch

diff --git a/meta/recipes-qt/qt4/qt4.inc b/meta/recipes-qt/qt4/qt4.inc
index 828e30a..ebe0ea5 100644
--- a/meta/recipes-qt/qt4/qt4.inc
+++ b/meta/recipes-qt/qt4/qt4.inc
@@ -134,6 +134,7 @@  FILES_${QT_BASE_NAME}-demos-doc = "${docdir}/${QT_DIR_NAME}/qch/qt.qch"
 RRECOMMENDS_${PN} = "${LIB_PACKAGES} ${OTHER_PACKAGES}"
 RRECOMMENDS_${PN}-dev = "${DEV_PACKAGES}"
 RRECOMMENDS_${PN}-dbg = "${DBG_PACKAGES}"
+RRECOMMENDS_${QT_BASE_LIB}core4_append_libc-glibc = " eglibc-gconv-utf-16"
 RRECOMMENDS_${QT_BASE_NAME}-demos += " \
             ${QT_BASE_NAME}-examples \
             ${QT_BASE_NAME}-plugin-sqldriver-sqlite \