Patchwork utility-tasks: Add recideptask flag for fetchall/checkuriall

login
register
mail settings
Submitter Richard Purdie
Date June 19, 2013, 1:05 p.m.
Message ID <1371647117.20823.182.camel@ted>
Download mbox | patch
Permalink /patch/51999/
State New
Headers show

Comments

Richard Purdie - June 19, 2013, 1:05 p.m.
See the bitbake commit adding the recideptask flag for details of the
problem but in summary, we weren't seeing the [depends] of tasks like
do_rootfs being taking into account for fetchall. This was leading
to not all sources being fetched and this is the OE-Core part of the
fix for this problem.

BB_DEFAULT_TASK is the default task used since this is the one that
most commands would end up targeting and is how users expect the command
to behave.

[YOCTO #4597]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Saul Wold - June 19, 2013, 1:54 p.m.
On 06/19/2013 06:05 AM, Richard Purdie wrote:
> See the bitbake commit adding the recideptask flag for details of the
> problem but in summary, we weren't seeing the [depends] of tasks like
> do_rootfs being taking into account for fetchall. This was leading
> to not all sources being fetched and this is the OE-Core part of the
> fix for this problem.
>
> BB_DEFAULT_TASK is the default task used since this is the one that
> most commands would end up targeting and is how users expect the command
> to behave.
>
> [YOCTO #4597]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/prexport.bbclass b/meta/classes/prexport.bbclass
> index 16c4bf2..5a1cb33 100644
> --- a/meta/classes/prexport.bbclass
> +++ b/meta/classes/prexport.bbclass
> @@ -55,4 +55,4 @@ python prexport_handler () {
>   }
>
>   addhandler prexport_handler
> -prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
> +prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
> diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass
> index bb26eb7..507e0f1 100644
> --- a/meta/classes/utility-tasks.bbclass
> +++ b/meta/classes/utility-tasks.bbclass
> @@ -48,6 +48,7 @@ python do_checkuri() {
>
>   addtask checkuriall after do_checkuri
>   do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
> +do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
>   do_checkuriall[nostamp] = "1"
>   do_checkuriall() {
>   	:
> @@ -55,6 +56,7 @@ do_checkuriall() {
>
>   addtask fetchall after do_fetch
>   do_fetchall[recrdeptask] = "do_fetchall do_fetch"
> +do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"

Would this change be needed in some of the distrodata tasks also? 
Mostly they operate on world or universe and not images, but I could see 
someone trying to get that info for a given image.

Sau!

>   do_fetchall() {
>   	:
>   }
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
Richard Purdie - June 19, 2013, 2:13 p.m.
On Wed, 2013-06-19 at 06:54 -0700, Saul Wold wrote:
> On 06/19/2013 06:05 AM, Richard Purdie wrote:
> >   addhandler prexport_handler
> > -prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
> > +prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
> > diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass
> > index bb26eb7..507e0f1 100644
> > --- a/meta/classes/utility-tasks.bbclass
> > +++ b/meta/classes/utility-tasks.bbclass
> > @@ -48,6 +48,7 @@ python do_checkuri() {
> >
> >   addtask checkuriall after do_checkuri
> >   do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
> > +do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
> >   do_checkuriall[nostamp] = "1"
> >   do_checkuriall() {
> >   	:
> > @@ -55,6 +56,7 @@ do_checkuriall() {
> >
> >   addtask fetchall after do_fetch
> >   do_fetchall[recrdeptask] = "do_fetchall do_fetch"
> > +do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"
> 
> Would this change be needed in some of the distrodata tasks also? 
> Mostly they operate on world or universe and not images, but I could see 
> someone trying to get that info for a given image.

Possibly, yes.

Cheers,

Richard

Patch

diff --git a/meta/classes/prexport.bbclass b/meta/classes/prexport.bbclass
index 16c4bf2..5a1cb33 100644
--- a/meta/classes/prexport.bbclass
+++ b/meta/classes/prexport.bbclass
@@ -55,4 +55,4 @@  python prexport_handler () {
 }
 
 addhandler prexport_handler
-prexport_handler bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
+prexport_handler[eventmask] = "bb.event.RecipeParsed bb.event.ParseStarted bb.event.ParseCompleted"
diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass
index bb26eb7..507e0f1 100644
--- a/meta/classes/utility-tasks.bbclass
+++ b/meta/classes/utility-tasks.bbclass
@@ -48,6 +48,7 @@  python do_checkuri() {
 
 addtask checkuriall after do_checkuri
 do_checkuriall[recrdeptask] = "do_checkuriall do_checkuri"
+do_checkuriall[recideptask] = "do_${BB_DEFAULT_TASK}"
 do_checkuriall[nostamp] = "1"
 do_checkuriall() {
 	:
@@ -55,6 +56,7 @@  do_checkuriall() {
 
 addtask fetchall after do_fetch
 do_fetchall[recrdeptask] = "do_fetchall do_fetch"
+do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}"
 do_fetchall() {
 	:
 }