Patchwork [1/1] base-files: create /usr/lib/locale dir

login
register
mail settings
Submitter rongqing.li@windriver.com
Date June 18, 2013, 8:42 a.m.
Message ID <51C01D87.9080804@windriver.com>
Download mbox | patch
Permalink /patch/51897/
State New
Headers show

Comments

rongqing.li@windriver.com - June 18, 2013, 8:42 a.m.
On 06/18/2013 04:07 PM, Phil Blundell wrote:
> On Tue, 2013-06-18 at 15:19 +0800, rongqing.li@windriver.com wrote:
>> -           ${libdir} ${sbindir} ${datadir} \
>> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
>
> This is bogus for a number of reasons.  If the only reason for having it
> is for lsbtest, can't it go in some LSB recipe?
>
> p.
>

Thanks, How about put it into do_install_append_linuxstdbase


-Roy



>
>
>
Phil Blundell - June 18, 2013, 9:12 a.m.
On Tue, 2013-06-18 at 16:42 +0800, Rongqing Li wrote:
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb 
> b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index fa1cc58..84663e3 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
>          for d in ${dirs4775}; do
>                   install -m 2755 -d ${D}$d
>           done
> +       install -m 755 -d ${D}/usr/lib/locale

Thanks, that looks better.  Could you not just add it to ${dirs3755}
though?  (Despite the confusing/misleading name, this variable appears
to be a list of LSB directories that should be created with mode 0755,
cf ${dirs4755} which is apparently directories to be created with mode
2755.)

In a stylistic sense it might be better to use ${prefix}/lib/locale (or
whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr",
and presumably lsbtest is looking for "/usr/lib/locale" specifically, so
I don't think it will actually make any functional difference in this
specific case.

p.
Mark Hatle - June 18, 2013, 2:19 p.m.
On 6/18/13 4:12 AM, Phil Blundell wrote:
> On Tue, 2013-06-18 at 16:42 +0800, Rongqing Li wrote:
>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> index fa1cc58..84663e3 100644
>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> @@ -139,6 +139,7 @@ do_install_append_linuxstdbase() {
>>           for d in ${dirs4775}; do
>>                    install -m 2755 -d ${D}$d
>>            done
>> +       install -m 755 -d ${D}/usr/lib/locale
>
> Thanks, that looks better.  Could you not just add it to ${dirs3755}
> though?  (Despite the confusing/misleading name, this variable appears
> to be a list of LSB directories that should be created with mode 0755,
> cf ${dirs4755} which is apparently directories to be created with mode
> 2755.)
>
> In a stylistic sense it might be better to use ${prefix}/lib/locale (or
> whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr",
> and presumably lsbtest is looking for "/usr/lib/locale" specifically, so
> I don't think it will actually make any functional difference in this
> specific case.

FYI, I agree  ${prefix}/lib/locale is likely the correct directory to reference. 
  It preserves the semantics of the OE way of declaring paths, supports the move 
of prefix to somewhere else, and will still work in an LSB compliant configuration.

--Mark

> p.
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb 
b/meta/recipes-core/base-files/base-files_3.0.14.bb
index fa1cc58..84663e3 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -139,6 +139,7 @@  do_install_append_linuxstdbase() {
         for d in ${dirs4775}; do
                  install -m 2755 -d ${D}$d
          done
+       install -m 755 -d ${D}/usr/lib/locale
  }

  PACKAGES = "${PN}-doc ${PN} ${PN}-dev ${PN}-dbg"