Patchwork [1/1] base-files: create /usr/lib/locale dir

login
register
mail settings
Submitter rongqing.li@windriver.com
Date June 18, 2013, 7:19 a.m.
Message ID <b57b85f69322501fb617a01e625734cda1088b5e.1371539741.git.rongqing.li@windriver.com>
Download mbox | patch
Permalink /patch/51883/
State New
Headers show

Comments

rongqing.li@windriver.com - June 18, 2013, 7:19 a.m.
From: "Roy.Li" <rongqing.li@windriver.com>

Lsbtest shows that /usr/lib/locale dir is lost, so create it

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
---
 meta/recipes-core/base-files/base-files_3.0.14.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Phil Blundell - June 18, 2013, 8:07 a.m.
On Tue, 2013-06-18 at 15:19 +0800, rongqing.li@windriver.com wrote:
> -           ${libdir} ${sbindir} ${datadir} \
> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \

This is bogus for a number of reasons.  If the only reason for having it
is for lsbtest, can't it go in some LSB recipe?

p.
Ross Burton - June 18, 2013, 8:24 a.m.
On Tuesday, 18 June 2013, wrote:

> -           ${libdir} ${sbindir} ${datadir} \
> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \


What Phil said, but also please don't hard-code paths - the rest of the
variable uses ${libdir} for a reason.

Ross
rongqing.li@windriver.com - June 18, 2013, 8:39 a.m.
On 06/18/2013 04:24 PM, Burton, Ross wrote:
> On Tuesday, 18 June 2013, wrote:
>
>> -           ${libdir} ${sbindir} ${datadir} \
>> +           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
>
>
> What Phil said, but also please don't hard-code paths - the rest of the
> variable uses ${libdir} for a reason.
>

${libdir}/locale can be /usr/lib/locale, or /usr/lib64/locale,

but localedef only thinks /usr/lib/locale as its default
outputpath(man localedef), can not /usr/lib64/locale, or
other.


-Roy

> Ross
>

Patch

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index ac85ed9..fa1cc58 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -36,7 +36,7 @@  dirs2775 = "/home ${prefix}/src ${localstatedir}/local"
 dirs755 = "/bin /boot /dev ${sysconfdir} ${sysconfdir}/default \
            ${sysconfdir}/skel /lib /mnt /proc ${ROOT_HOME} /run /sbin \
            ${prefix} ${bindir} ${docdir} /usr/games ${includedir} \
-           ${libdir} ${sbindir} ${datadir} \
+           ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
            ${datadir}/common-licenses ${datadir}/dict ${infodir} \
            ${mandir} ${datadir}/misc ${localstatedir} \
            ${localstatedir}/backups ${localstatedir}/lib \