Patchwork [bitbake-devel] xmlrpc,events: cleanup stale code

login
register
mail settings
Submitter Alexandru DAMIAN
Date June 17, 2013, 4:30 p.m.
Message ID <1371486629-14039-1-git-send-email-alexandru.damian@intel.com>
Download mbox | patch
Permalink /patch/51837/
State New
Headers show

Comments

Alexandru DAMIAN - June 17, 2013, 4:30 p.m.
From: Alexandru DAMIAN <alexandru.damian@intel.com>

This patch cleans up some stale code that isn't used anymore.
The unused code obscures file readability.

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
 lib/bb/event.py         |  7 -------
 lib/bb/server/xmlrpc.py | 46 ----------------------------------------------
 2 files changed, 53 deletions(-)

Patch

diff --git a/lib/bb/event.py b/lib/bb/event.py
index 9c134ee..d8111f1 100644
--- a/lib/bb/event.py
+++ b/lib/bb/event.py
@@ -294,12 +294,6 @@  class BuildBase(Event):
     def setName(self, name):
         self._name = name
 
-    def getCfg(self):
-        return self.data
-
-    def setCfg(self, cfg):
-        self.data = cfg
-
     def getFailures(self):
         """
         Return the number of failed packages
@@ -308,7 +302,6 @@  class BuildBase(Event):
 
     pkgs = property(getPkgs, setPkgs, None, "pkgs property")
     name = property(getName, setName, None, "name property")
-    cfg = property(getCfg, setCfg, None, "cfg property")
 
 
 
diff --git a/lib/bb/server/xmlrpc.py b/lib/bb/server/xmlrpc.py
index 026415e..56cae49 100644
--- a/lib/bb/server/xmlrpc.py
+++ b/lib/bb/server/xmlrpc.py
@@ -149,52 +149,6 @@  class BitBakeXMLRPCRequestHandler(SimpleXMLRPCRequestHandler):
         self.end_headers()
         self.wfile.write(response)
 
-class BitBakeUIEventServer(threading.Thread):
-    class EventAdapter():
-        """
-        Adapter to wrap our event queue since the caller (bb.event) expects to
-        call a send() method, but our actual queue only has put()
-        """
-        def __init__(self, notify):
-            self.queue = []
-            self.notify = notify
-            self.qlock = threading.Lock()
-
-        def send(self, event):
-            self.qlock.acquire()
-            self.queue.append(event)
-            self.qlock.release()
-            self.notify.set()
-
-        def get(self):
-            self.qlock.acquire()
-            if len(self.queue) == 0:
-                self.qlock.release()
-                return None
-            e = self.queue.pop(0)
-            if len(self.queue) == 0:
-                self.notify.clear()
-            self.qlock.release()
-            return e
-
-    def __init__(self, connection):
-        self.connection = connection
-        self.notify = threading.Event()
-        self.event = BitBakeUIEventServer.EventAdapter(self.notify)
-        self.quit = False
-        threading.Thread.__init__(self)
-
-    def terminateServer(self):
-        self.quit = True
-
-    def run(self):
-        while not self.quit:
-            self.notify.wait(0.1)
-            evt = self.event.get()
-            if evt:
-                self.connection.event.sendpickle(pickle.dumps(evt))
-
-
 class XMLRPCProxyServer(BaseImplServer):
     """ not a real working server, but a stub for a proxy server connection