Patchwork [1/2] strace: update depends

login
register
mail settings
Submitter Kang Kai
Date June 16, 2013, 2:16 p.m.
Message ID <30a61ca7883e5f9d8858c7b89884874e74a972c5.1371392062.git.kai.kang@windriver.com>
Download mbox | patch
Permalink /patch/51763/
State New
Headers show

Comments

Kang Kai - June 16, 2013, 2:16 p.m.
Build strace with libaio and acl to support more features. Because no
native libaio package, just add dependencies for target.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-devtools/strace/strace_4.7.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Bernhard Reutner-Fischer - June 17, 2013, 7:15 a.m.
On 16 June 2013 16:16:25 Kai Kang <kai.kang@windriver.com> wrote:
> Build strace with libaio and acl to support more features. Because no
> native libaio package, just add dependencies for target.

Do you mind updating to 4.8 while you touch it?
Thanks,


Sent with AquaMail for Android
http://www.aqua-mail.com
Kang Kai - June 17, 2013, 9:04 a.m.
On 2013?06?17? 15:15, Bernhard Reutner-Fischer wrote:
> On 16 June 2013 16:16:25 Kai Kang <kai.kang@windriver.com> wrote:
>> Build strace with libaio and acl to support more features. Because no
>> native libaio package, just add dependencies for target.
>
> Do you mind updating to 4.8 while you touch it?
> Thanks,
>

OK, I'll check the new version of strace

>
> Sent with AquaMail for Android
> http://www.aqua-mail.com
>
>
>
>
Richard Purdie - June 17, 2013, 3:11 p.m.
On Sun, 2013-06-16 at 22:16 +0800, Kai Kang wrote:
> Build strace with libaio and acl to support more features. Because no
> native libaio package, just add dependencies for target.
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  meta/recipes-devtools/strace/strace_4.7.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Shouldn't this be implemented like the other packages as PACKAGECONFIG
options? That is how acl is handled elsewhere at least...

Cheers,

Richard

> diff --git a/meta/recipes-devtools/strace/strace_4.7.bb b/meta/recipes-devtools/strace/strace_4.7.bb
> index e360e63..bcc7bd9 100644
> --- a/meta/recipes-devtools/strace/strace_4.7.bb
> +++ b/meta/recipes-devtools/strace/strace_4.7.bb
> @@ -5,6 +5,8 @@ LICENSE = "BSD"
>  LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=124500c21e856f0912df29295ba104c7"
>  PR = "r4"
>  
> +DEPENDS_class-target += "libaio acl"
> +
>  SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \
>             file://0003-util-fix-building-when-glibc-has-a-stub-process_vm_r.patch \
>             file://0014-x32-update-syscall-table.patch \
Kang Kai - June 18, 2013, 11:47 a.m.
On 2013?06?17? 23:11, Richard Purdie wrote:
> On Sun, 2013-06-16 at 22:16 +0800, Kai Kang wrote:
>> Build strace with libaio and acl to support more features. Because no
>> native libaio package, just add dependencies for target.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   meta/recipes-devtools/strace/strace_4.7.bb |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
> Shouldn't this be implemented like the other packages as PACKAGECONFIG
> options? That is how acl is handled elsewhere at least...

Yes, PACKAGECONFIG is the right way. I'll send V2.

Thanks,
Kai

>
> Cheers,
>
> Richard
>
>> diff --git a/meta/recipes-devtools/strace/strace_4.7.bb b/meta/recipes-devtools/strace/strace_4.7.bb
>> index e360e63..bcc7bd9 100644
>> --- a/meta/recipes-devtools/strace/strace_4.7.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.7.bb
>> @@ -5,6 +5,8 @@ LICENSE = "BSD"
>>   LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=124500c21e856f0912df29295ba104c7"
>>   PR = "r4"
>>   
>> +DEPENDS_class-target += "libaio acl"
>> +
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \
>>              file://0003-util-fix-building-when-glibc-has-a-stub-process_vm_r.patch \
>>              file://0014-x32-update-syscall-table.patch \
>
>

Patch

diff --git a/meta/recipes-devtools/strace/strace_4.7.bb b/meta/recipes-devtools/strace/strace_4.7.bb
index e360e63..bcc7bd9 100644
--- a/meta/recipes-devtools/strace/strace_4.7.bb
+++ b/meta/recipes-devtools/strace/strace_4.7.bb
@@ -5,6 +5,8 @@  LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=124500c21e856f0912df29295ba104c7"
 PR = "r4"
 
+DEPENDS_class-target += "libaio acl"
+
 SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \
            file://0003-util-fix-building-when-glibc-has-a-stub-process_vm_r.patch \
            file://0014-x32-update-syscall-table.patch \