Patchwork atk: inherit gnomebase

login
register
mail settings
Submitter Ross Burton
Date June 14, 2013, 3:40 p.m.
Message ID <1371224418-11163-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/51735/
State New
Headers show

Comments

Ross Burton - June 14, 2013, 3:40 p.m.
This recipe was missing a dependency on gnome-common, so lets just inherit
gnomebase and get both it and GNOME SRC_URI handling for free.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-support/atk/atk_2.8.0.bb |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Richard Purdie - June 14, 2013, 3:50 p.m.
On Fri, 2013-06-14 at 16:40 +0100, Ross Burton wrote:
> This recipe was missing a dependency on gnome-common, so lets just inherit
> gnomebase and get both it and GNOME SRC_URI handling for free.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-support/atk/atk_2.8.0.bb |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-support/atk/atk_2.8.0.bb b/meta/recipes-support/atk/atk_2.8.0.bb
> index a190c0a..cfe2f58 100644
> --- a/meta/recipes-support/atk/atk_2.8.0.bb
> +++ b/meta/recipes-support/atk/atk_2.8.0.bb
> @@ -10,11 +10,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
>  
>  DEPENDS = "glib-2.0"
>  
> -inherit autotools gtk-doc pkgconfig
> +inherit gnome gtk-doc

The above and the commit message don't match (gnome verses gnomebase) :/

Cheers,

Richard

> -MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
> +GNOME_COMPRESS_TYPE = "xz"
>  
> -SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz"
>  SRC_URI[md5sum] = "c652bd25530825d604dae1c1ebd2da02"
>  SRC_URI[sha256sum] = "b22519176226f3e07cf6d932b77852e6b6be4780977770704b32d0f4e0686df4"
>
Ross Burton - June 14, 2013, 4:42 p.m.
Gnar, sorry. I retract this, I inherited the wrong class.

Ross

On Friday, 14 June 2013, Richard Purdie wrote:

> On Fri, 2013-06-14 at 16:40 +0100, Ross Burton wrote:
> > This recipe was missing a dependency on gnome-common, so lets just
> inherit
> > gnomebase and get both it and GNOME SRC_URI handling for free.
> >
> > Signed-off-by: Ross Burton <ross.burton@intel.com <javascript:;>>
> > ---
> >  meta/recipes-support/atk/atk_2.8.0.bb |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-support/atk/atk_2.8.0.bbb/meta/recipes-support/atk/
> atk_2.8.0.bb
> > index a190c0a..cfe2f58 100644
> > --- a/meta/recipes-support/atk/atk_2.8.0.bb
> > +++ b/meta/recipes-support/atk/atk_2.8.0.bb
> > @@ -10,11 +10,10 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
> >
> >  DEPENDS = "glib-2.0"
> >
> > -inherit autotools gtk-doc pkgconfig
> > +inherit gnome gtk-doc
>
> The above and the commit message don't match (gnome verses gnomebase) :/
>
> Cheers,
>
> Richard
>
> > -MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
> > +GNOME_COMPRESS_TYPE = "xz"
> >
> > -SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz"
> >  SRC_URI[md5sum] = "c652bd25530825d604dae1c1ebd2da02"
> >  SRC_URI[sha256sum] =
> "b22519176226f3e07cf6d932b77852e6b6be4780977770704b32d0f4e0686df4"
> >
>
>
>

Patch

diff --git a/meta/recipes-support/atk/atk_2.8.0.bb b/meta/recipes-support/atk/atk_2.8.0.bb
index a190c0a..cfe2f58 100644
--- a/meta/recipes-support/atk/atk_2.8.0.bb
+++ b/meta/recipes-support/atk/atk_2.8.0.bb
@@ -10,11 +10,10 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
 
 DEPENDS = "glib-2.0"
 
-inherit autotools gtk-doc pkgconfig
+inherit gnome gtk-doc
 
-MAJ_VER = "${@oe.utils.trim_version("${PV}", 2)}"
+GNOME_COMPRESS_TYPE = "xz"
 
-SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz"
 SRC_URI[md5sum] = "c652bd25530825d604dae1c1ebd2da02"
 SRC_URI[sha256sum] = "b22519176226f3e07cf6d932b77852e6b6be4780977770704b32d0f4e0686df4"