Patchwork [CONSOLIDATED,PULL,24/32] bitbake.conf: Create static-dev pacakge for static libraries

login
register
mail settings
Submitter Saul Wold
Date June 1, 2011, 6:21 a.m.
Message ID <f1c4bd3cef1b384787b418e737c93cd105635196.1306909184.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/5171/
State New, archived
Headers show

Comments

Saul Wold - June 1, 2011, 6:21 a.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/conf/bitbake.conf |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
Richard Purdie - June 1, 2011, 5:29 p.m.
On Tue, 2011-05-31 at 23:21 -0700, Saul Wold wrote:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/conf/bitbake.conf |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index de94316..4722eb0 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -248,13 +248,18 @@ FILES_${PN}-doc = "${docdir} ${mandir} ${infodir} ${datadir}/gtk-doc \
>  SECTION_${PN}-doc = "doc"
>  
>  FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
> -                ${libdir}/*.a ${libdir}/*.o ${libdir}/pkgconfig \
> +                ${libdir}/*.o ${libdir}/pkgconfig \
>                  ${datadir}/pkgconfig ${datadir}/aclocal \
>                  ${base_libdir}/*.a ${base_libdir}/*.o"
>  SECTION_${PN}-dev = "devel"
>  ALLOW_EMPTY_${PN}-dev = "1"
>  RDEPENDS_${PN}-dev = "${PN} (= ${EXTENDPKGV})"
>  
> +FILES_${PN}-static-dev = "${libdir}/*.a ${base_libdir}/*.a"
> +SECTION_${PN}-static-dev = "devel"
> +ALLOW_EMPTY_${PN}-static-dev = "1"

No need for the ALLOW_EMPTY here. The dependencies of -dev packages are
important but it makes no sense for static dv packages.

I've also a slight preference for "staticdev" just to make these clearly
different from -dev packages.

Cheers,

Richard

> +RDEPENDS_${PN}-static-dev = "${PN} (= ${EXTENDPV})"
> +
>  DOTDEBUG-dbg = "${bindir}/.debug ${sbindir}/.debug ${libexecdir}/.debug ${libdir}/.debug \
>              ${base_bindir}/.debug ${base_sbindir}/.debug ${base_libdir}/.debug ${libdir}/${PN}/.debug \
>              ${libdir}/matchbox-panel/.debug /usr/src/debug"
Phil Blundell - June 1, 2011, 6:19 p.m.
On Wed, 2011-06-01 at 18:29 +0100, Richard Purdie wrote:
> I've also a slight preference for "staticdev" just to make these clearly
> different from -dev packages.

Agreed.  I think even "-static" might be better still.

p.
Koen Kooi - June 1, 2011, 6:27 p.m.
Op 1 jun 2011, om 20:19 heeft Phil Blundell het volgende geschreven:

> On Wed, 2011-06-01 at 18:29 +0100, Richard Purdie wrote:
>> I've also a slight preference for "staticdev" just to make these clearly
>> different from -dev packages.
> 
> Agreed.  I think even "-static" might be better still.

That's what we did in OE and it caused some troubles in the busybox-static and mplayer-static cases. But that were the only ones I encountered.

regards,

Koen
Saul Wold - June 2, 2011, 6:54 a.m.
On 06/01/2011 11:27 AM, Koen Kooi wrote:
>
> Op 1 jun 2011, om 20:19 heeft Phil Blundell het volgende geschreven:
>
>> On Wed, 2011-06-01 at 18:29 +0100, Richard Purdie wrote:
>>> I've also a slight preference for "staticdev" just to make these clearly
>>> different from -dev packages.
>>
>> Agreed.  I think even "-static" might be better still.
>
> That's what we did in OE and it caused some troubles in the busybox-static and mplayer-static cases. But that were the only ones I encountered.
>
What about -staticlibs since that what they the packages actaully contain?

Sau!
> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index de94316..4722eb0 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -248,13 +248,18 @@  FILES_${PN}-doc = "${docdir} ${mandir} ${infodir} ${datadir}/gtk-doc \
 SECTION_${PN}-doc = "doc"
 
 FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
-                ${libdir}/*.a ${libdir}/*.o ${libdir}/pkgconfig \
+                ${libdir}/*.o ${libdir}/pkgconfig \
                 ${datadir}/pkgconfig ${datadir}/aclocal \
                 ${base_libdir}/*.a ${base_libdir}/*.o"
 SECTION_${PN}-dev = "devel"
 ALLOW_EMPTY_${PN}-dev = "1"
 RDEPENDS_${PN}-dev = "${PN} (= ${EXTENDPKGV})"
 
+FILES_${PN}-static-dev = "${libdir}/*.a ${base_libdir}/*.a"
+SECTION_${PN}-static-dev = "devel"
+ALLOW_EMPTY_${PN}-static-dev = "1"
+RDEPENDS_${PN}-static-dev = "${PN} (= ${EXTENDPV})"
+
 DOTDEBUG-dbg = "${bindir}/.debug ${sbindir}/.debug ${libexecdir}/.debug ${libdir}/.debug \
             ${base_bindir}/.debug ${base_sbindir}/.debug ${base_libdir}/.debug ${libdir}/${PN}/.debug \
             ${libdir}/matchbox-panel/.debug /usr/src/debug"