Patchwork [v2,1/4] packagegroup-core-tools-profile: don't exclude mips

login
register
mail settings
Submitter Christopher Larson
Date June 10, 2013, 11:15 p.m.
Message ID <1103bc7c76faba1db73f4c4f4b8439aa03258c3d.1370906102.git.chris_larson@mentor.com>
Download mbox | patch
Permalink /patch/51473/
State New
Headers show

Comments

Christopher Larson - June 10, 2013, 11:15 p.m.
From: Christopher Larson <chris_larson@mentor.com>

Now that liburcu supports mips, this packagegroup can pull in lttng recipes
(lttng-ust, lttng-tools, lttng-modules, babeltrace) on that architecture as it
does for the others.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 .../packagegroups/packagegroup-core-tools-profile.bb          | 11 -----------
 1 file changed, 11 deletions(-)
Otavio Salvador - June 10, 2013, 11:48 p.m.
On Mon, Jun 10, 2013 at 8:15 PM, Christopher Larson <kergoth@gmail.com>wrote:

> From: Christopher Larson <chris_larson@mentor.com>
>
> Now that liburcu supports mips, this packagegroup can pull in lttng recipes
> (lttng-ust, lttng-tools, lttng-modules, babeltrace) on that architecture
> as it
> does for the others.
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>

Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
Khem Raj - June 11, 2013, 2:27 a.m.
On Jun 10, 2013, at 4:15 PM, Christopher Larson <kergoth@gmail.com> wrote:

> From: Christopher Larson <chris_larson@mentor.com>
> 
> Now that liburcu supports mips, this packagegroup can pull in lttng recipes
> (lttng-ust, lttng-tools, lttng-modules, babeltrace) on that architecture as it
> does for the others.

it still does not work on mips64 though. but thats another patch probably. 

> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
> .../packagegroups/packagegroup-core-tools-profile.bb          | 11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> index 8f40c4e..bb1b78b 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> @@ -48,22 +48,15 @@ SYSTEMTAP_aarch64 = ""
> 
> LTTNGUST = "lttng-ust"
> LTTNGUST_libc-uclibc = ""
> -LTTNGUST_mips = ""
> LTTNGUST_aarch64 = ""
> 
> -# lttng-tools, lttng-modules and babeltrace all depend on liburcu
> -# which currentl doesn't build on mips
> -
> LTTNGTOOLS = "lttng-tools"
> -LTTNGTOOLS_mips = ""
> LTTNGTOOLS_aarch64 = ""
> 
> LTTNGMODULES = "lttng-modules"
> -LTTNGMODULES_mips = ""
> LTTNGMODULES_aarch64 = ""
> 
> BABELTRACE = "babeltrace"
> -BABELTRACE_mips = ""
> BABELTRACE_aarch64 = ""
> 
> # valgrind does not work on mips
> @@ -77,10 +70,6 @@ VALGRIND_aarch64 = ""
> #    exmap-console
> #    exmap-server
> 
> -# At present we only build lttng-ust on
> -# qemux86/qemux86-64/qemuppc/qemuarm/emenlow/atom-pc since upstream liburcu
> -# (which is required by lttng-ust) may not build on other platforms, like
> -# MIPS.
> RDEPENDS_${PN} = "\
>     ${PROFILETOOLS} \
>     ${LTTNGUST} \
> -- 
> 1.8.3
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Christopher Larson - June 11, 2013, 2:48 a.m.
On Mon, Jun 10, 2013 at 7:27 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On Jun 10, 2013, at 4:15 PM, Christopher Larson <kergoth@gmail.com> wrote:
>
> > From: Christopher Larson <chris_larson@mentor.com>
> >
> > Now that liburcu supports mips, this packagegroup can pull in lttng
> recipes
> > (lttng-ust, lttng-tools, lttng-modules, babeltrace) on that architecture
> as it
> > does for the others.
>
> it still does not work on mips64 though. but thats another patch probably.


Good point, indeed.

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 8f40c4e..bb1b78b 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -48,22 +48,15 @@  SYSTEMTAP_aarch64 = ""
 
 LTTNGUST = "lttng-ust"
 LTTNGUST_libc-uclibc = ""
-LTTNGUST_mips = ""
 LTTNGUST_aarch64 = ""
 
-# lttng-tools, lttng-modules and babeltrace all depend on liburcu
-# which currentl doesn't build on mips
-
 LTTNGTOOLS = "lttng-tools"
-LTTNGTOOLS_mips = ""
 LTTNGTOOLS_aarch64 = ""
 
 LTTNGMODULES = "lttng-modules"
-LTTNGMODULES_mips = ""
 LTTNGMODULES_aarch64 = ""
 
 BABELTRACE = "babeltrace"
-BABELTRACE_mips = ""
 BABELTRACE_aarch64 = ""
 
 # valgrind does not work on mips
@@ -77,10 +70,6 @@  VALGRIND_aarch64 = ""
 #    exmap-console
 #    exmap-server
 
-# At present we only build lttng-ust on
-# qemux86/qemux86-64/qemuppc/qemuarm/emenlow/atom-pc since upstream liburcu
-# (which is required by lttng-ust) may not build on other platforms, like
-# MIPS.
 RDEPENDS_${PN} = "\
     ${PROFILETOOLS} \
     ${LTTNGUST} \