Patchwork [1/4] packagegroup-core-tools-profile: don't exclude mips

login
register
mail settings
Submitter Christopher Larson
Date June 10, 2013, 8:46 p.m.
Message ID <4dcc39cc1fed7d398b97859ea281ab46e8ba8dbb.1370896985.git.chris_larson@mentor.com>
Download mbox | patch
Permalink /patch/51439/
State Accepted
Commit c0f435cde195e1d037af32c69aa1732797362cfa
Headers show

Comments

Christopher Larson - June 10, 2013, 8:46 p.m.
From: Christopher Larson <chris_larson@mentor.com>

Now that liburcu supports mips, this packagegroup can pull in lttng software
on that architecture.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 .../packagegroups/packagegroup-core-tools-profile.bb          | 11 -----------
 1 file changed, 11 deletions(-)
Otavio Salvador - June 10, 2013, 8:56 p.m.
On Mon, Jun 10, 2013 at 5:46 PM, Christopher Larson <kergoth@gmail.com>wrote:

> From: Christopher Larson <chris_larson@mentor.com>
>
> Now that liburcu supports mips, this packagegroup can pull in lttng
> software
> on that architecture.
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>


Your commit log say's nothing about babeltrace. I think it'd be good to add
it.

 --
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Christopher Larson - June 10, 2013, 9 p.m.
On Mon, Jun 10, 2013 at 1:56 PM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> On Mon, Jun 10, 2013 at 5:46 PM, Christopher Larson <kergoth@gmail.com>wrote:
>
>> From: Christopher Larson <chris_larson@mentor.com>
>>
>> Now that liburcu supports mips, this packagegroup can pull in lttng
>> software
>> on that architecture.
>>
>> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>
>
> Your commit log say's nothing about babeltrace. I think it'd be good to
> add it.
>

It's debatable whether babel trace is considered 'lttng software', as it's
listed at http://lttng.org/download and http://lttng.org/babeltrace redirects
to the official babeltrace project page also. If you think mentioning it
separately would be beneficial, I'll send a v2. Thanks for reviewing these.

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 8f40c4e..bb1b78b 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -48,22 +48,15 @@  SYSTEMTAP_aarch64 = ""
 
 LTTNGUST = "lttng-ust"
 LTTNGUST_libc-uclibc = ""
-LTTNGUST_mips = ""
 LTTNGUST_aarch64 = ""
 
-# lttng-tools, lttng-modules and babeltrace all depend on liburcu
-# which currentl doesn't build on mips
-
 LTTNGTOOLS = "lttng-tools"
-LTTNGTOOLS_mips = ""
 LTTNGTOOLS_aarch64 = ""
 
 LTTNGMODULES = "lttng-modules"
-LTTNGMODULES_mips = ""
 LTTNGMODULES_aarch64 = ""
 
 BABELTRACE = "babeltrace"
-BABELTRACE_mips = ""
 BABELTRACE_aarch64 = ""
 
 # valgrind does not work on mips
@@ -77,10 +70,6 @@  VALGRIND_aarch64 = ""
 #    exmap-console
 #    exmap-server
 
-# At present we only build lttng-ust on
-# qemux86/qemux86-64/qemuppc/qemuarm/emenlow/atom-pc since upstream liburcu
-# (which is required by lttng-ust) may not build on other platforms, like
-# MIPS.
 RDEPENDS_${PN} = "\
     ${PROFILETOOLS} \
     ${LTTNGUST} \