Patchwork valgrind: added perl dependency

login
register
mail settings
Submitter eu@felipetonello.com
Date June 7, 2013, 5:35 p.m.
Message ID <1370626502-5233-1-git-send-email-eu@felipetonello.com>
Download mbox | patch
Permalink /patch/51377/
State New
Headers show

Comments

eu@felipetonello.com - June 7, 2013, 5:35 p.m.
From: "Felipe F. Tonello" <eu@felipetonello.com>

This is necessary since the valgrind package depends on /usr/bin/perl.

This patch will fix this error while installing into rootfs:
Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - June 7, 2013, 5:42 p.m.
On Fri, Jun 07, 2013 at 10:35:02AM -0700, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
> 
> This is necessary since the valgrind package depends on /usr/bin/perl.
> 
> This patch will fix this error while installing into rootfs:
> Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl

This doesn't look as build-time dependency and before you add it to
RDEPENDS_${PN} use grep to find which file in valgrind package is using
/usr/bin/perl shebang

grep -R '#/usr/bin/perl' packages-split/valgrind

and if it's just some "extra" script not always needed for valgrind,
then move it to extra package and add perl only to
PN-this-extra-package.

Cheers,

> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> index 3520d49..ae2c5a2 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> @@ -8,8 +8,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
>                      file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
>  
>  X11DEPENDS = "virtual/libx11"
> -DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> -PR = "r8"
> +DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)} perl"
> +PR = "r9"
>  
>  SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>  	   file://fix_issue_caused_by_ccache.patch \
> -- 
> 1.8.1.4
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Martin Jansa - June 7, 2013, 5:43 p.m.
On Fri, Jun 07, 2013 at 07:42:52PM +0200, Martin Jansa wrote:
> On Fri, Jun 07, 2013 at 10:35:02AM -0700, eu@felipetonello.com wrote:
> > From: "Felipe F. Tonello" <eu@felipetonello.com>
> > 
> > This is necessary since the valgrind package depends on /usr/bin/perl.
> > 
> > This patch will fix this error while installing into rootfs:
> > Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl
> 
> This doesn't look as build-time dependency and before you add it to
> RDEPENDS_${PN} use grep to find which file in valgrind package is using
> /usr/bin/perl shebang
> 
> grep -R '#/usr/bin/perl' packages-split/valgrind

ups, missed ! but you probably got the ide

> 
> and if it's just some "extra" script not always needed for valgrind,
> then move it to extra package and add perl only to
> PN-this-extra-package.
> 
> Cheers,
> 
> > 
> > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > ---
> >  meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > index 3520d49..ae2c5a2 100644
> > --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > @@ -8,8 +8,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
> >                      file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
> >  
> >  X11DEPENDS = "virtual/libx11"
> > -DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> > -PR = "r8"
> > +DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)} perl"
> > +PR = "r9"
> >  
> >  SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> >  	   file://fix_issue_caused_by_ccache.patch \
> > -- 
> > 1.8.1.4
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
eu@felipetonello.com - June 7, 2013, 5:47 p.m.
Hi Martin,

On Fri, Jun 7, 2013 at 10:42 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Jun 07, 2013 at 10:35:02AM -0700, eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <eu@felipetonello.com>
>>
>> This is necessary since the valgrind package depends on /usr/bin/perl.
>>
>> This patch will fix this error while installing into rootfs:
>> Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl
>
> This doesn't look as build-time dependency and before you add it to
> RDEPENDS_${PN} use grep to find which file in valgrind package is using
> /usr/bin/perl shebang

You are right, it's not a build time dependency, but this fix works anyway hehe.

>
> grep -R '#/usr/bin/perl' packages-split/valgrind
>
> and if it's just some "extra" script not always needed for valgrind,
> then move it to extra package and add perl only to
> PN-this-extra-package.

Yes, this makes sense.

Thank you

Felipe
eu@felipetonello.com - June 7, 2013, 5:51 p.m.
I got this:

valgrind/usr/bin/ms_print
1:#! /usr/bin/perl

valgrind/usr/bin/cg_diff
1:#! /usr/bin/perl

valgrind/usr/bin/cg_annotate
1:#! /usr/bin/perl

valgrind/usr/bin/callgrind_annotate
1:#! /usr/bin/perl -w

valgrind/usr/bin/callgrind_control
1:#! /usr/bin/perl -w

valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter

valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
55978:(/usr/bin/perl) 77.7083 Tj

Do you know if these "binaries" are part of the main package or can be
extra? I'm not that familiar with valgrind.
Martin Jansa - June 7, 2013, 6:37 p.m.
On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote:
> I got this:
> 
> valgrind/usr/bin/ms_print
> 1:#! /usr/bin/perl
> 
> valgrind/usr/bin/cg_diff
> 1:#! /usr/bin/perl
> 
> valgrind/usr/bin/cg_annotate
> 1:#! /usr/bin/perl
> 
> valgrind/usr/bin/callgrind_annotate
> 1:#! /usr/bin/perl -w
> 
> valgrind/usr/bin/callgrind_control
> 1:#! /usr/bin/perl -w
> 
> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
> 165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter
> 
> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
> 55978:(/usr/bin/perl) 77.7083 Tj
> 
> Do you know if these "binaries" are part of the main package or can be
> extra? I'm not that familiar with valgrind.

Neither am I, but from filenames I would guess they are not mandatory to
run valgrind binary, hopefully someone who is using valgrind daily will
respond soon...
Khem Raj - June 11, 2013, 7:36 a.m.
On Fri, Jun 7, 2013 at 11:37 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote:
>> I got this:
>>
>> valgrind/usr/bin/ms_print
>> 1:#! /usr/bin/perl
>>
>> valgrind/usr/bin/cg_diff
>> 1:#! /usr/bin/perl
>>
>> valgrind/usr/bin/cg_annotate
>> 1:#! /usr/bin/perl
>>
>> valgrind/usr/bin/callgrind_annotate
>> 1:#! /usr/bin/perl -w
>>
>> valgrind/usr/bin/callgrind_control
>> 1:#! /usr/bin/perl -w
>>
>> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
>> 165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter
>>
>> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
>> 55978:(/usr/bin/perl) 77.7083 Tj
>>
>> Do you know if these "binaries" are part of the main package or can be
>> extra? I'm not that familiar with valgrind.
>
> Neither am I, but from filenames I would guess they are not mandatory to
> run valgrind binary, hopefully someone who is using valgrind daily will
> respond soon...
>


they are fine with valgrind package itself. although its a rdepend and
not depend


> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
eu@felipetonello.com - June 26, 2013, 6:39 p.m.
Should I send another patch?

On Tue, Jun 11, 2013 at 12:36 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Jun 7, 2013 at 11:37 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote:
>>> I got this:
>>>
>>> valgrind/usr/bin/ms_print
>>> 1:#! /usr/bin/perl
>>>
>>> valgrind/usr/bin/cg_diff
>>> 1:#! /usr/bin/perl
>>>
>>> valgrind/usr/bin/cg_annotate
>>> 1:#! /usr/bin/perl
>>>
>>> valgrind/usr/bin/callgrind_annotate
>>> 1:#! /usr/bin/perl -w
>>>
>>> valgrind/usr/bin/callgrind_control
>>> 1:#! /usr/bin/perl -w
>>>
>>> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
>>> 165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter
>>>
>>> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
>>> 55978:(/usr/bin/perl) 77.7083 Tj
>>>
>>> Do you know if these "binaries" are part of the main package or can be
>>> extra? I'm not that familiar with valgrind.
>>
>> Neither am I, but from filenames I would guess they are not mandatory to
>> run valgrind binary, hopefully someone who is using valgrind daily will
>> respond soon...
>>
>
>
> they are fine with valgrind package itself. although its a rdepend and
> not depend
>
>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
Saul Wold - June 26, 2013, 8:35 p.m.
On 06/26/2013 11:39 AM, Felipe Tonello wrote:
> Should I send another patch?
>

I think that Khem pointed out it should be an RDEPENDS not DEPENDS and 
you can drop the PR bump.

Sau!

> On Tue, Jun 11, 2013 at 12:36 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Fri, Jun 7, 2013 at 11:37 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>> On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote:
>>>> I got this:
>>>>
>>>> valgrind/usr/bin/ms_print
>>>> 1:#! /usr/bin/perl
>>>>
>>>> valgrind/usr/bin/cg_diff
>>>> 1:#! /usr/bin/perl
>>>>
>>>> valgrind/usr/bin/cg_annotate
>>>> 1:#! /usr/bin/perl
>>>>
>>>> valgrind/usr/bin/callgrind_annotate
>>>> 1:#! /usr/bin/perl -w
>>>>
>>>> valgrind/usr/bin/callgrind_control
>>>> 1:#! /usr/bin/perl -w
>>>>
>>>> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
>>>> 165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter
>>>>
>>>> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
>>>> 55978:(/usr/bin/perl) 77.7083 Tj
>>>>
>>>> Do you know if these "binaries" are part of the main package or can be
>>>> extra? I'm not that familiar with valgrind.
>>>
>>> Neither am I, but from filenames I would guess they are not mandatory to
>>> run valgrind binary, hopefully someone who is using valgrind daily will
>>> respond soon...
>>>
>>
>>
>> they are fine with valgrind package itself. although its a rdepend and
>> not depend
>>
>>
>>> --
>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
Khem Raj - June 28, 2013, 10:35 p.m.
On Jun 26, 2013, at 11:39 AM, Felipe Tonello <eu@felipetonello.com> wrote:

> Should I send another patch?


Please do.

> 
> On Tue, Jun 11, 2013 at 12:36 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Fri, Jun 7, 2013 at 11:37 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>> On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote:
>>>> I got this:
>>>> 
>>>> valgrind/usr/bin/ms_print
>>>> 1:#! /usr/bin/perl
>>>> 
>>>> valgrind/usr/bin/cg_diff
>>>> 1:#! /usr/bin/perl
>>>> 
>>>> valgrind/usr/bin/cg_annotate
>>>> 1:#! /usr/bin/perl
>>>> 
>>>> valgrind/usr/bin/callgrind_annotate
>>>> 1:#! /usr/bin/perl -w
>>>> 
>>>> valgrind/usr/bin/callgrind_control
>>>> 1:#! /usr/bin/perl -w
>>>> 
>>>> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html
>>>> 165:<code class="filename">/usr/bin/perl</code>, or whatever interpreter
>>>> 
>>>> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps
>>>> 55978:(/usr/bin/perl) 77.7083 Tj
>>>> 
>>>> Do you know if these "binaries" are part of the main package or can be
>>>> extra? I'm not that familiar with valgrind.
>>> 
>>> Neither am I, but from filenames I would guess they are not mandatory to
>>> run valgrind binary, hopefully someone who is using valgrind daily will
>>> respond soon...
>>> 
>> 
>> 
>> they are fine with valgrind package itself. although its a rdepend and
>> not depend
>> 
>> 
>>> --
>>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>> 
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
index 3520d49..ae2c5a2 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
@@ -8,8 +8,8 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
                     file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
 
 X11DEPENDS = "virtual/libx11"
-DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
-PR = "r8"
+DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)} perl"
+PR = "r9"
 
 SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 	   file://fix_issue_caused_by_ccache.patch \