Patchwork classes/qmake_base: allow parallel make

login
register
mail settings
Submitter Jonathan Liu
Date June 6, 2013, 4:05 a.m.
Message ID <1370491540-21915-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/51197/
State Accepted
Commit 04af378874f38d1200bea2fa191beeae94232d6e
Headers show

Comments

Jonathan Liu - June 6, 2013, 4:05 a.m.
Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta/classes/qmake_base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - June 6, 2013, 5:02 a.m.
On 06/05/2013 09:05 PM, Jonathan Liu wrote:
> Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>   meta/classes/qmake_base.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/qmake_base.bbclass b/meta/classes/qmake_base.bbclass
> index 52e7fb0..3762887 100644
> --- a/meta/classes/qmake_base.bbclass
> +++ b/meta/classes/qmake_base.bbclass
> @@ -4,7 +4,7 @@ OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
>   QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
>
>   # We override this completely to eliminate the -e normally passed in
> -EXTRA_OEMAKE = ' MAKEFLAGS= '
> +EXTRA_OEMAKE = ""
>
I don't think this is correct, have you checked the run.do_compile script?

It shows
         make -j 16  MAKEFLAGS=  "$@" || die "oe_runmake failed"

Which means the parallel make info is being passed correctly.

Sau!


>   export OE_QMAKE_CC="${CC}"
>   export OE_QMAKE_CFLAGS="${CFLAGS}"
>
Jonathan Liu - June 6, 2013, 5:08 a.m.
On 6 June 2013 15:02, Saul Wold <sgw@linux.intel.com> wrote:
> On 06/05/2013 09:05 PM, Jonathan Liu wrote:
>>
>> Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>>   meta/classes/qmake_base.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/qmake_base.bbclass
>> b/meta/classes/qmake_base.bbclass
>> index 52e7fb0..3762887 100644
>> --- a/meta/classes/qmake_base.bbclass
>> +++ b/meta/classes/qmake_base.bbclass
>> @@ -4,7 +4,7 @@ OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
>>   QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
>>
>>   # We override this completely to eliminate the -e normally passed in
>> -EXTRA_OEMAKE = ' MAKEFLAGS= '
>> +EXTRA_OEMAKE = ""
>>
> I don't think this is correct, have you checked the run.do_compile script?
>
> It shows
>         make -j 16  MAKEFLAGS=  "$@" || die "oe_runmake failed"
>
> Which means the parallel make info is being passed correctly.
>
> Sau!

MAKEFLAGS= cancels out the -j 16.

Regards,
Jonathan

>
>
>
>>   export OE_QMAKE_CC="${CC}"
>>   export OE_QMAKE_CFLAGS="${CFLAGS}"
>>
>

Patch

diff --git a/meta/classes/qmake_base.bbclass b/meta/classes/qmake_base.bbclass
index 52e7fb0..3762887 100644
--- a/meta/classes/qmake_base.bbclass
+++ b/meta/classes/qmake_base.bbclass
@@ -4,7 +4,7 @@  OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
 QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
 
 # We override this completely to eliminate the -e normally passed in
-EXTRA_OEMAKE = ' MAKEFLAGS= '
+EXTRA_OEMAKE = ""
 
 export OE_QMAKE_CC="${CC}"
 export OE_QMAKE_CFLAGS="${CFLAGS}"