Patchwork [1/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz

login
register
mail settings
Submitter Yi Zhao
Date June 5, 2013, 9:20 a.m.
Message ID <d26bc9ddb088a29796402194ab5649cfbf916248.1370414193.git.yi.zhao@windriver.com>
Download mbox | patch
Permalink /patch/51167/
State Accepted
Commit dfd0985065c3447df169198e8cd518e007f630ff
Headers show

Comments

Yi Zhao - June 5, 2013, 9:20 a.m.
The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}.
But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin.
Remove the extra .bin suffix.

[YOCTO #4595]

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - June 5, 2013, 10:05 a.m.
On Wed, Jun 05, 2013 at 05:20:50PM +0800, Yi Zhao wrote:
> The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}.
> But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin.
> Remove the extra .bin suffix.
> 
> [YOCTO #4595]

Looks good, thanks for fixing it.

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

> 
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
>  meta/classes/kernel.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6550615..40a6b5b 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -375,7 +375,7 @@ kernel_do_deploy() {
>  	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
>  		mkdir -p ${D}/lib
>  		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
> -		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
> +		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
>  	fi
>  
>  	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 6550615..40a6b5b 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -375,7 +375,7 @@  kernel_do_deploy() {
 	if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
 		mkdir -p ${D}/lib
 		tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
-		ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
+		ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
 	fi
 
 	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin