Patchwork [dylan,master] Fix meta-toolchain-qte SDK build for x11-less DISTRO

login
register
mail settings
Submitter Nicolas Dechesne
Date June 5, 2013, 7:24 a.m.
Message ID <1370417067-30166-1-git-send-email-nicolas.dechesne@linaro.org>
Download mbox | patch
Permalink /patch/51157/
State New
Headers show

Comments

Nicolas Dechesne - June 5, 2013, 7:24 a.m.
When building QTe SDK for a DISTRO that does not have x11 FEATURES,
building meta-toolchain-qte failed because it unconditionally pulls in
nativesdk-libx11. The 'culprit' is meta/recipes-qt/qt4/nativesdk-qt4-tools.inc.

The fix is inspired from the following commits:

abf2ab7 dbus: only use x11 if DISTRO_FEATURES has selected it
ba22cfa cairo: only use x11 if selected in DISTRO_FEATURES

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
---
 meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Saul Wold - June 5, 2013, 4:30 p.m.
On 06/05/2013 12:24 AM, Nicolas Dechesne wrote:
> When building QTe SDK for a DISTRO that does not have x11 FEATURES,
> building meta-toolchain-qte failed because it unconditionally pulls in
> nativesdk-libx11. The 'culprit' is meta/recipes-qt/qt4/nativesdk-qt4-tools.inc.
>
> The fix is inspired from the following commits:
>
> abf2ab7 dbus: only use x11 if DISTRO_FEATURES has selected it
> ba22cfa cairo: only use x11 if selected in DISTRO_FEATURES
>
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> ---
>   meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> index cfc6fd8..3725cac 100644
> --- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> +++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> @@ -1,5 +1,6 @@
>   DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
> -DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
> +X11DEPENDS = "nativesdk-libx11"
> +DEPENDS = "nativesdk-zlib nativesdk-dbus qt4-native ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"

You could just directly put the nativesdk-libx11 in place of the 
variable, no need to have the variable there.

Sau!

>   SECTION = "libs"
>   HOMEPAGE = "http://qt.nokia.com"
>   LICENSE = "LGPLv2.1 | GPLv3"
>
Nicolas Dechesne - June 5, 2013, 4:32 p.m.
On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com> wrote:

> You could just directly put the nativesdk-libx11 in place of the variable,
> no need to have the variable there.
>

yes, that's what I had initially, but found it was less easy to read...
with X11DEPENDS it's more 'obvious' that there is something special.. that
said, i can make the change if that's really needed.
Denys Dmytriyenko - June 5, 2013, 4:40 p.m.
Ack, regardless of whether a separate X11DEPENDS variable stays or goes, as we 
had the same fix for our SDKs for some time now (yeah, I'm well behind on 
upstreaming my fixes, sorry).

Acked-by: Denys Dmytriyenko <denys@ti.com>
Tested-by: Denys Dmytriyenko <denys@ti.com>

On Wed, Jun 05, 2013 at 09:24:27AM +0200, Nicolas Dechesne wrote:
> When building QTe SDK for a DISTRO that does not have x11 FEATURES,
> building meta-toolchain-qte failed because it unconditionally pulls in
> nativesdk-libx11. The 'culprit' is meta/recipes-qt/qt4/nativesdk-qt4-tools.inc.
> 
> The fix is inspired from the following commits:
> 
> abf2ab7 dbus: only use x11 if DISTRO_FEATURES has selected it
> ba22cfa cairo: only use x11 if selected in DISTRO_FEATURES
> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> ---
>  meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> index cfc6fd8..3725cac 100644
> --- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> +++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> @@ -1,5 +1,6 @@
>  DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
> -DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
> +X11DEPENDS = "nativesdk-libx11"
> +DEPENDS = "nativesdk-zlib nativesdk-dbus qt4-native ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
>  SECTION = "libs"
>  HOMEPAGE = "http://qt.nokia.com"
>  LICENSE = "LGPLv2.1 | GPLv3"
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Saul Wold - June 5, 2013, 4:58 p.m.
On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>
> On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>> wrote:
>
>     You could just directly put the nativesdk-libx11 in place of the
>     variable, no need to have the variable there.
>
>
> yes, that's what I had initially, but found it was less easy to read...
> with X11DEPENDS it's more 'obvious' that there is something special..
> that said, i can make the change if that's really needed.
>
We do use the X11DEPENDS elsewhere when there are multiple dependencies, 
but I also found cases where we just include the dependency directly in 
the test. I was trying pick a direction: single entry no X11DEPENDS, 
multiple entries use X11DEPENDS.

Comments, flames, ...

Sau!
Otavio Salvador - June 5, 2013, 5:12 p.m.
On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>
>>
>> On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
>> <mailto:sgw@linux.intel.com>> wrote:
>>
>>     You could just directly put the nativesdk-libx11 in place of the
>>     variable, no need to have the variable there.
>>
>>
>> yes, that's what I had initially, but found it was less easy to read...
>> with X11DEPENDS it's more 'obvious' that there is something special..
>> that said, i can make the change if that's really needed.
>>
>>  We do use the X11DEPENDS elsewhere when there are multiple dependencies,
> but I also found cases where we just include the dependency directly in the
> test. I was trying pick a direction: single entry no X11DEPENDS, multiple
> entries use X11DEPENDS.
>
> Comments, flames, ...
>

Yes; I sent this patch in Febuary:
http://patchwork.openembedded.org/patch/44759/

Please use this one instead of the recent one.
Saul Wold - June 5, 2013, 5:19 p.m.
On 06/05/2013 10:12 AM, Otavio Salvador wrote:
>
>
>
> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>> wrote:
>
>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>
>
>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
>         <mailto:sgw@linux.intel.com>
>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>> wrote:
>
>              You could just directly put the nativesdk-libx11 in place
>         of the
>              variable, no need to have the variable there.
>
>
>         yes, that's what I had initially, but found it was less easy to
>         read...
>         with X11DEPENDS it's more 'obvious' that there is something
>         special..
>         that said, i can make the change if that's really needed.
>
>     We do use the X11DEPENDS elsewhere when there are multiple
>     dependencies, but I also found cases where we just include the
>     dependency directly in the test. I was trying pick a direction:
>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
>
>     Comments, flames, ...
>
>
> Yes; I sent this patch in Febuary:
> http://patchwork.openembedded.org/patch/44759/
>
> Please use this one instead of the recent one.
>

Well reading back on that, it looks like I was waiting for an 
EXTRA_OECONF or related change to the autoconf scripts.

Sau!

> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Nicolas Dechesne - June 5, 2013, 5:23 p.m.
On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
>
>>
>>
>>
>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com
>> <mailto:sgw@linux.intel.com>> wrote:
>>
>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>>
>>
>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
>>         <mailto:sgw@linux.intel.com>
>>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>> wrote:
>>
>>              You could just directly put the nativesdk-libx11 in place
>>         of the
>>              variable, no need to have the variable there.
>>
>>
>>         yes, that's what I had initially, but found it was less easy to
>>         read...
>>         with X11DEPENDS it's more 'obvious' that there is something
>>         special..
>>         that said, i can make the change if that's really needed.
>>
>>     We do use the X11DEPENDS elsewhere when there are multiple
>>     dependencies, but I also found cases where we just include the
>>     dependency directly in the test. I was trying pick a direction:
>>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
>>
>>     Comments, flames, ...
>>
>>
>> Yes; I sent this patch in Febuary:
>> http://patchwork.openembedded.**org/patch/44759/<http://patchwork.openembedded.org/patch/44759/>
>>
>> Please use this one instead of the recent one.
>>
>>
> Well reading back on that, it looks like I was waiting for an EXTRA_OECONF
> or related change to the autoconf scripts.
>
> Sau!


hmm. ok, sorry Otavio, i missed the other patch. I will check on my side
too about EXTRA_OECONF.


>
>
>  --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br http://projetos.ossystems.com.**br<http://projetos.ossystems.com.br>
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>>
>
Otavio Salvador - June 5, 2013, 5:43 p.m.
On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
nicolas.dechesne@linaro.org> wrote:

>
>
>
> On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com> wrote:
>
>> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
>>
>>>
>>>
>>>
>>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com
>>> <mailto:sgw@linux.intel.com>> wrote:
>>>
>>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>>>
>>>
>>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
>>>         <mailto:sgw@linux.intel.com>
>>>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
>>> wrote:
>>>
>>>              You could just directly put the nativesdk-libx11 in place
>>>         of the
>>>              variable, no need to have the variable there.
>>>
>>>
>>>         yes, that's what I had initially, but found it was less easy to
>>>         read...
>>>         with X11DEPENDS it's more 'obvious' that there is something
>>>         special..
>>>         that said, i can make the change if that's really needed.
>>>
>>>     We do use the X11DEPENDS elsewhere when there are multiple
>>>     dependencies, but I also found cases where we just include the
>>>     dependency directly in the test. I was trying pick a direction:
>>>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
>>>
>>>     Comments, flames, ...
>>>
>>>
>>> Yes; I sent this patch in Febuary:
>>> http://patchwork.openembedded.**org/patch/44759/<http://patchwork.openembedded.org/patch/44759/>
>>>
>>> Please use this one instead of the recent one.
>>>
>>>
>> Well reading back on that, it looks like I was waiting for an
>> EXTRA_OECONF or related change to the autoconf scripts.
>>
>> Sau!
>
>
> hmm. ok, sorry Otavio, i missed the other patch. I will check on my side
> too about EXTRA_OECONF.
>

Nicolas, don't worry. It is normal to end redoing some stuff.

Last time I checked it had no support in Qt build system; I am not sure if
it uses or not the host headers (in case they exist) but it needs testing
to be sure.
Denys Dmytriyenko - June 5, 2013, 8:07 p.m.
On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> nicolas.dechesne@linaro.org> wrote:
> 
> >
> >
> >
> > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com> wrote:
> >
> >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> >>
> >>>
> >>>
> >>>
> >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com
> >>> <mailto:sgw@linux.intel.com>> wrote:
> >>>
> >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> >>>
> >>>
> >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <sgw@linux.intel.com
> >>>         <mailto:sgw@linux.intel.com>
> >>>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
> >>> wrote:
> >>>
> >>>              You could just directly put the nativesdk-libx11 in place
> >>>         of the
> >>>              variable, no need to have the variable there.
> >>>
> >>>
> >>>         yes, that's what I had initially, but found it was less easy to
> >>>         read...
> >>>         with X11DEPENDS it's more 'obvious' that there is something
> >>>         special..
> >>>         that said, i can make the change if that's really needed.
> >>>
> >>>     We do use the X11DEPENDS elsewhere when there are multiple
> >>>     dependencies, but I also found cases where we just include the
> >>>     dependency directly in the test. I was trying pick a direction:
> >>>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
> >>>
> >>>     Comments, flames, ...
> >>>
> >>>
> >>> Yes; I sent this patch in Febuary:
> >>> http://patchwork.openembedded.**org/patch/44759/<http://patchwork.openembedded.org/patch/44759/>
> >>>
> >>> Please use this one instead of the recent one.
> >>>
> >>>
> >> Well reading back on that, it looks like I was waiting for an
> >> EXTRA_OECONF or related change to the autoconf scripts.
> >>
> >> Sau!
> >
> >
> > hmm. ok, sorry Otavio, i missed the other patch. I will check on my side
> > too about EXTRA_OECONF.
> >
> 
> Nicolas, don't worry. It is normal to end redoing some stuff.
> 
> Last time I checked it had no support in Qt build system; I am not sure if
> it uses or not the host headers (in case they exist) but it needs testing
> to be sure.

I can confirm that it does not link against host X11 when built w/o that 
dependency and nativesdk has no x11 libs/headers. As I previously mentioned, 
we've been using this fix for over 6 months on several releases built on 
different machines w/o problems...
Otavio Salvador - June 5, 2013, 8:10 p.m.
On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> > nicolas.dechesne@linaro.org> wrote:
> >
> > >
> > >
> > >
> > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > >
> > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> > >>
> > >>>
> > >>>
> > >>>
> > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold <sgw@linux.intel.com
> > >>> <mailto:sgw@linux.intel.com>> wrote:
> > >>>
> > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> > >>>
> > >>>
> > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold <
> sgw@linux.intel.com
> > >>>         <mailto:sgw@linux.intel.com>
> > >>>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
> > >>> wrote:
> > >>>
> > >>>              You could just directly put the nativesdk-libx11 in
> place
> > >>>         of the
> > >>>              variable, no need to have the variable there.
> > >>>
> > >>>
> > >>>         yes, that's what I had initially, but found it was less easy
> to
> > >>>         read...
> > >>>         with X11DEPENDS it's more 'obvious' that there is something
> > >>>         special..
> > >>>         that said, i can make the change if that's really needed.
> > >>>
> > >>>     We do use the X11DEPENDS elsewhere when there are multiple
> > >>>     dependencies, but I also found cases where we just include the
> > >>>     dependency directly in the test. I was trying pick a direction:
> > >>>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
> > >>>
> > >>>     Comments, flames, ...
> > >>>
> > >>>
> > >>> Yes; I sent this patch in Febuary:
> > >>> http://patchwork.openembedded.**org/patch/44759/<
> http://patchwork.openembedded.org/patch/44759/>
> > >>>
> > >>> Please use this one instead of the recent one.
> > >>>
> > >>>
> > >> Well reading back on that, it looks like I was waiting for an
> > >> EXTRA_OECONF or related change to the autoconf scripts.
> > >>
> > >> Sau!
> > >
> > >
> > > hmm. ok, sorry Otavio, i missed the other patch. I will check on my
> side
> > > too about EXTRA_OECONF.
> > >
> >
> > Nicolas, don't worry. It is normal to end redoing some stuff.
> >
> > Last time I checked it had no support in Qt build system; I am not sure
> if
> > it uses or not the host headers (in case they exist) but it needs testing
> > to be sure.
>
> I can confirm that it does not link against host X11 when built w/o that
> dependency and nativesdk has no x11 libs/headers. As I previously
> mentioned,
> we've been using this fix for over 6 months on several releases built on
> different machines w/o problems...
>

In this case the patch can be merged 'as is'.
Saul Wold - June 5, 2013, 8:53 p.m.
On 06/05/2013 01:10 PM, Otavio Salvador wrote:
>
>
>
> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
> <mailto:denis@denix.org>> wrote:
>
>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@linaro.org>>
>     wrote:
>      >
>      > >
>      > >
>      > >
>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com
>     <mailto:sgw@linux.intel.com>> wrote:
>      > >
>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
>      > >>
>      > >>>
>      > >>>
>      > >>>
>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>> wrote:
>      > >>>
>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>      > >>>
>      > >>>
>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
>      > >>>         <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>
>      > >>>         <mailto:sgw@linux.intel.com
>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
>     <mailto:sgw@linux.intel.com>>>>
>      > >>> wrote:
>      > >>>
>      > >>>              You could just directly put the nativesdk-libx11
>     in place
>      > >>>         of the
>      > >>>              variable, no need to have the variable there.
>      > >>>
>      > >>>
>      > >>>         yes, that's what I had initially, but found it was
>     less easy to
>      > >>>         read...
>      > >>>         with X11DEPENDS it's more 'obvious' that there is
>     something
>      > >>>         special..
>      > >>>         that said, i can make the change if that's really needed.
>      > >>>
>      > >>>     We do use the X11DEPENDS elsewhere when there are multiple
>      > >>>     dependencies, but I also found cases where we just
>     include the
>      > >>>     dependency directly in the test. I was trying pick a
>     direction:
>      > >>>     single entry no X11DEPENDS, multiple entries use X11DEPENDS.
>      > >>>
>      > >>>     Comments, flames, ...
>      > >>>
>      > >>>
>      > >>> Yes; I sent this patch in Febuary:
>      > >>>
>     http://patchwork.openembedded.**org/patch/44759/<http://patchwork.openembedded.org/patch/44759/>
>      > >>>
>      > >>> Please use this one instead of the recent one.
>      > >>>
>      > >>>
>      > >> Well reading back on that, it looks like I was waiting for an
>      > >> EXTRA_OECONF or related change to the autoconf scripts.
>      > >>
>      > >> Sau!
>      > >
>      > >
>      > > hmm. ok, sorry Otavio, i missed the other patch. I will check
>     on my side
>      > > too about EXTRA_OECONF.
>      > >
>      >
>      > Nicolas, don't worry. It is normal to end redoing some stuff.
>      >
>      > Last time I checked it had no support in Qt build system; I am
>     not sure if
>      > it uses or not the host headers (in case they exist) but it needs
>     testing
>      > to be sure.
>
>     I can confirm that it does not link against host X11 when built w/o that
>     dependency and nativesdk has no x11 libs/headers. As I previously
>     mentioned,
>     we've been using this fix for over 6 months on several releases built on
>     different machines w/o problems...
>
>
> In this case the patch can be merged 'as is'.
>

I am still concerned about a floating dependency here, imagine the 
following:

Build the toolchain with X11 enabled, nativesdk-libx11 is build, now 
rebuild with X11 disabled, the dependency is gone, but the libraries and 
headers still exist in the sysroot and thus the configure will still 
enable x11 in qte, bad things happen.

We need to have a disable flag to autotools.

Thanks
	Sau!

> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Otavio Salvador - June 5, 2013, 8:56 p.m.
On Wed, Jun 5, 2013 at 5:53 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 06/05/2013 01:10 PM, Otavio Salvador wrote:
>
>>
>>
>>
>> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
>> <mailto:denis@denix.org>> wrote:
>>
>>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
>>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
>>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@**linaro.org<nicolas.dechesne@linaro.org>
>> >>
>>
>>     wrote:
>>      >
>>      > >
>>      > >
>>      > >
>>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com
>>     <mailto:sgw@linux.intel.com>> wrote:
>>      > >
>>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
>>      > >>
>>      > >>>
>>      > >>>
>>      > >>>
>>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
>>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
>>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
>> wrote:
>>      > >>>
>>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
>>      > >>>
>>      > >>>
>>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
>>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
>>      > >>>         <mailto:sgw@linux.intel.com <mailto:
>> sgw@linux.intel.com>>
>>      > >>>         <mailto:sgw@linux.intel.com
>>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
>>     <mailto:sgw@linux.intel.com>>>**>
>>      > >>> wrote:
>>      > >>>
>>      > >>>              You could just directly put the nativesdk-libx11
>>     in place
>>      > >>>         of the
>>      > >>>              variable, no need to have the variable there.
>>      > >>>
>>      > >>>
>>      > >>>         yes, that's what I had initially, but found it was
>>     less easy to
>>      > >>>         read...
>>      > >>>         with X11DEPENDS it's more 'obvious' that there is
>>     something
>>      > >>>         special..
>>      > >>>         that said, i can make the change if that's really
>> needed.
>>      > >>>
>>      > >>>     We do use the X11DEPENDS elsewhere when there are multiple
>>      > >>>     dependencies, but I also found cases where we just
>>     include the
>>      > >>>     dependency directly in the test. I was trying pick a
>>     direction:
>>      > >>>     single entry no X11DEPENDS, multiple entries use
>> X11DEPENDS.
>>      > >>>
>>      > >>>     Comments, flames, ...
>>      > >>>
>>      > >>>
>>      > >>> Yes; I sent this patch in Febuary:
>>      > >>>
>>     http://patchwork.openembedded.****org/patch/44759/<http://**
>> patchwork.openembedded.org/**patch/44759/<http://patchwork.openembedded.org/patch/44759/>
>> >
>>      > >>>
>>      > >>> Please use this one instead of the recent one.
>>      > >>>
>>      > >>>
>>      > >> Well reading back on that, it looks like I was waiting for an
>>      > >> EXTRA_OECONF or related change to the autoconf scripts.
>>      > >>
>>      > >> Sau!
>>      > >
>>      > >
>>      > > hmm. ok, sorry Otavio, i missed the other patch. I will check
>>     on my side
>>      > > too about EXTRA_OECONF.
>>      > >
>>      >
>>      > Nicolas, don't worry. It is normal to end redoing some stuff.
>>      >
>>      > Last time I checked it had no support in Qt build system; I am
>>     not sure if
>>      > it uses or not the host headers (in case they exist) but it needs
>>     testing
>>      > to be sure.
>>
>>     I can confirm that it does not link against host X11 when built w/o
>> that
>>     dependency and nativesdk has no x11 libs/headers. As I previously
>>     mentioned,
>>     we've been using this fix for over 6 months on several releases built
>> on
>>     different machines w/o problems...
>>
>>
>> In this case the patch can be merged 'as is'.
>>
>>
> I am still concerned about a floating dependency here, imagine the
> following:
>
> Build the toolchain with X11 enabled, nativesdk-libx11 is build, now
> rebuild with X11 disabled, the dependency is gone, but the libraries and
> headers still exist in the sysroot and thus the configure will still enable
> x11 in qte, bad things happen.
>

I expect different distro features to have different build dirs. No?


> We need to have a disable flag to autotools.
>

The qmake based system does not provide this; so to support it, it will
need to be a hack ...
Denys Dmytriyenko - June 5, 2013, 8:58 p.m.
On Wed, Jun 05, 2013 at 05:56:31PM -0300, Otavio Salvador wrote:
> On Wed, Jun 5, 2013 at 5:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
> 
> > On 06/05/2013 01:10 PM, Otavio Salvador wrote:
> >
> >>
> >>
> >>
> >> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
> >> <mailto:denis@denix.org>> wrote:
> >>
> >>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> >>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> >>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@**linaro.org<nicolas.dechesne@linaro.org>
> >> >>
> >>
> >>     wrote:
> >>      >
> >>      > >
> >>      > >
> >>      > >
> >>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com
> >>     <mailto:sgw@linux.intel.com>> wrote:
> >>      > >
> >>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> >>      > >>
> >>      > >>>
> >>      > >>>
> >>      > >>>
> >>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
> >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> >>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
> >> wrote:
> >>      > >>>
> >>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> >>      > >>>
> >>      > >>>
> >>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
> >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> >>      > >>>         <mailto:sgw@linux.intel.com <mailto:
> >> sgw@linux.intel.com>>
> >>      > >>>         <mailto:sgw@linux.intel.com
> >>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
> >>     <mailto:sgw@linux.intel.com>>>**>
> >>      > >>> wrote:
> >>      > >>>
> >>      > >>>              You could just directly put the nativesdk-libx11
> >>     in place
> >>      > >>>         of the
> >>      > >>>              variable, no need to have the variable there.
> >>      > >>>
> >>      > >>>
> >>      > >>>         yes, that's what I had initially, but found it was
> >>     less easy to
> >>      > >>>         read...
> >>      > >>>         with X11DEPENDS it's more 'obvious' that there is
> >>     something
> >>      > >>>         special..
> >>      > >>>         that said, i can make the change if that's really
> >> needed.
> >>      > >>>
> >>      > >>>     We do use the X11DEPENDS elsewhere when there are multiple
> >>      > >>>     dependencies, but I also found cases where we just
> >>     include the
> >>      > >>>     dependency directly in the test. I was trying pick a
> >>     direction:
> >>      > >>>     single entry no X11DEPENDS, multiple entries use
> >> X11DEPENDS.
> >>      > >>>
> >>      > >>>     Comments, flames, ...
> >>      > >>>
> >>      > >>>
> >>      > >>> Yes; I sent this patch in Febuary:
> >>      > >>>
> >>     http://patchwork.openembedded.****org/patch/44759/<http://**
> >> patchwork.openembedded.org/**patch/44759/<http://patchwork.openembedded.org/patch/44759/>
> >> >
> >>      > >>>
> >>      > >>> Please use this one instead of the recent one.
> >>      > >>>
> >>      > >>>
> >>      > >> Well reading back on that, it looks like I was waiting for an
> >>      > >> EXTRA_OECONF or related change to the autoconf scripts.
> >>      > >>
> >>      > >> Sau!
> >>      > >
> >>      > >
> >>      > > hmm. ok, sorry Otavio, i missed the other patch. I will check
> >>     on my side
> >>      > > too about EXTRA_OECONF.
> >>      > >
> >>      >
> >>      > Nicolas, don't worry. It is normal to end redoing some stuff.
> >>      >
> >>      > Last time I checked it had no support in Qt build system; I am
> >>     not sure if
> >>      > it uses or not the host headers (in case they exist) but it needs
> >>     testing
> >>      > to be sure.
> >>
> >>     I can confirm that it does not link against host X11 when built w/o
> >> that
> >>     dependency and nativesdk has no x11 libs/headers. As I previously
> >>     mentioned,
> >>     we've been using this fix for over 6 months on several releases built
> >> on
> >>     different machines w/o problems...
> >>
> >>
> >> In this case the patch can be merged 'as is'.
> >>
> >>
> > I am still concerned about a floating dependency here, imagine the
> > following:
> >
> > Build the toolchain with X11 enabled, nativesdk-libx11 is build, now
> > rebuild with X11 disabled, the dependency is gone, but the libraries and
> > headers still exist in the sysroot and thus the configure will still enable
> > x11 in qte, bad things happen.
> >
> 
> I expect different distro features to have different build dirs. No?
> 
> 
> > We need to have a disable flag to autotools.
> >
> 
> The qmake based system does not provide this; so to support it, it will
> need to be a hack ...

I agree with Otavio here - seems like you are after a rare corner case here...
Richard Purdie - June 6, 2013, 3:46 p.m.
On Wed, 2013-06-05 at 16:58 -0400, Denys Dmytriyenko wrote:
> On Wed, Jun 05, 2013 at 05:56:31PM -0300, Otavio Salvador wrote:
> > On Wed, Jun 5, 2013 at 5:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > 
> > > On 06/05/2013 01:10 PM, Otavio Salvador wrote:
> > >
> > >>
> > >>
> > >>
> > >> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
> > >> <mailto:denis@denix.org>> wrote:
> > >>
> > >>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> > >>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> > >>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@**linaro.org<nicolas.dechesne@linaro.org>
> > >> >>
> > >>
> > >>     wrote:
> > >>      >
> > >>      > >
> > >>      > >
> > >>      > >
> > >>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <sgw@linux.intel.com
> > >>     <mailto:sgw@linux.intel.com>> wrote:
> > >>      > >
> > >>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> > >>      > >>
> > >>      > >>>
> > >>      > >>>
> > >>      > >>>
> > >>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
> > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > >>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>>
> > >> wrote:
> > >>      > >>>
> > >>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> > >>      > >>>
> > >>      > >>>
> > >>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
> > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > >>      > >>>         <mailto:sgw@linux.intel.com <mailto:
> > >> sgw@linux.intel.com>>
> > >>      > >>>         <mailto:sgw@linux.intel.com
> > >>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
> > >>     <mailto:sgw@linux.intel.com>>>**>
> > >>      > >>> wrote:
> > >>      > >>>
> > >>      > >>>              You could just directly put the nativesdk-libx11
> > >>     in place
> > >>      > >>>         of the
> > >>      > >>>              variable, no need to have the variable there.
> > >>      > >>>
> > >>      > >>>
> > >>      > >>>         yes, that's what I had initially, but found it was
> > >>     less easy to
> > >>      > >>>         read...
> > >>      > >>>         with X11DEPENDS it's more 'obvious' that there is
> > >>     something
> > >>      > >>>         special..
> > >>      > >>>         that said, i can make the change if that's really
> > >> needed.
> > >>      > >>>
> > >>      > >>>     We do use the X11DEPENDS elsewhere when there are multiple
> > >>      > >>>     dependencies, but I also found cases where we just
> > >>     include the
> > >>      > >>>     dependency directly in the test. I was trying pick a
> > >>     direction:
> > >>      > >>>     single entry no X11DEPENDS, multiple entries use
> > >> X11DEPENDS.
> > >>      > >>>
> > >>      > >>>     Comments, flames, ...
> > >>      > >>>
> > >>      > >>>
> > >>      > >>> Yes; I sent this patch in Febuary:
> > >>      > >>>
> > >>     http://patchwork.openembedded.****org/patch/44759/<http://**
> > >> patchwork.openembedded.org/**patch/44759/<http://patchwork.openembedded.org/patch/44759/>
> > >> >
> > >>      > >>>
> > >>      > >>> Please use this one instead of the recent one.
> > >>      > >>>
> > >>      > >>>
> > >>      > >> Well reading back on that, it looks like I was waiting for an
> > >>      > >> EXTRA_OECONF or related change to the autoconf scripts.
> > >>      > >>
> > >>      > >> Sau!
> > >>      > >
> > >>      > >
> > >>      > > hmm. ok, sorry Otavio, i missed the other patch. I will check
> > >>     on my side
> > >>      > > too about EXTRA_OECONF.
> > >>      > >
> > >>      >
> > >>      > Nicolas, don't worry. It is normal to end redoing some stuff.
> > >>      >
> > >>      > Last time I checked it had no support in Qt build system; I am
> > >>     not sure if
> > >>      > it uses or not the host headers (in case they exist) but it needs
> > >>     testing
> > >>      > to be sure.
> > >>
> > >>     I can confirm that it does not link against host X11 when built w/o
> > >> that
> > >>     dependency and nativesdk has no x11 libs/headers. As I previously
> > >>     mentioned,
> > >>     we've been using this fix for over 6 months on several releases built
> > >> on
> > >>     different machines w/o problems...
> > >>
> > >>
> > >> In this case the patch can be merged 'as is'.
> > >>
> > >>
> > > I am still concerned about a floating dependency here, imagine the
> > > following:
> > >
> > > Build the toolchain with X11 enabled, nativesdk-libx11 is build, now
> > > rebuild with X11 disabled, the dependency is gone, but the libraries and
> > > headers still exist in the sysroot and thus the configure will still enable
> > > x11 in qte, bad things happen.
> > >
> > 
> > I expect different distro features to have different build dirs. No?
> > 
> > 
> > > We need to have a disable flag to autotools.
> > >
> > 
> > The qmake based system does not provide this; so to support it, it will
> > need to be a hack ...
> 
> I agree with Otavio here - seems like you are after a rare corner case here...

We need determinism in the builds. Yes in this case it might be hard to
achieve but I do think we need to achieve it.

So this patch isn't going in until we can avoid this option magically
floating, sorry. I've said this before and I've not changed my mind.

Cheers,

Richard
Otavio Salvador - June 6, 2013, 4:28 p.m.
On Thu, Jun 6, 2013 at 12:46 PM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Wed, 2013-06-05 at 16:58 -0400, Denys Dmytriyenko wrote:
> > On Wed, Jun 05, 2013 at 05:56:31PM -0300, Otavio Salvador wrote:
> > > On Wed, Jun 5, 2013 at 5:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > >
> > > > On 06/05/2013 01:10 PM, Otavio Salvador wrote:
> > > >
> > > >>
> > > >>
> > > >>
> > > >> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
> > > >> <mailto:denis@denix.org>> wrote:
> > > >>
> > > >>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> > > >>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> > > >>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@**
> linaro.org<nicolas.dechesne@linaro.org>
> > > >> >>
> > > >>
> > > >>     wrote:
> > > >>      >
> > > >>      > >
> > > >>      > >
> > > >>      > >
> > > >>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <
> sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com>> wrote:
> > > >>      > >
> > > >>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> > > >>      > >>
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
> > > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > > >>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com
> >>>
> > > >> wrote:
> > > >>      > >>>
> > > >>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
> > > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > > >>      > >>>         <mailto:sgw@linux.intel.com <mailto:
> > > >> sgw@linux.intel.com>>
> > > >>      > >>>         <mailto:sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com>>>**>
> > > >>      > >>> wrote:
> > > >>      > >>>
> > > >>      > >>>              You could just directly put the
> nativesdk-libx11
> > > >>     in place
> > > >>      > >>>         of the
> > > >>      > >>>              variable, no need to have the variable
> there.
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>         yes, that's what I had initially, but found it
> was
> > > >>     less easy to
> > > >>      > >>>         read...
> > > >>      > >>>         with X11DEPENDS it's more 'obvious' that there is
> > > >>     something
> > > >>      > >>>         special..
> > > >>      > >>>         that said, i can make the change if that's really
> > > >> needed.
> > > >>      > >>>
> > > >>      > >>>     We do use the X11DEPENDS elsewhere when there are
> multiple
> > > >>      > >>>     dependencies, but I also found cases where we just
> > > >>     include the
> > > >>      > >>>     dependency directly in the test. I was trying pick a
> > > >>     direction:
> > > >>      > >>>     single entry no X11DEPENDS, multiple entries use
> > > >> X11DEPENDS.
> > > >>      > >>>
> > > >>      > >>>     Comments, flames, ...
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>> Yes; I sent this patch in Febuary:
> > > >>      > >>>
> > > >>     http://patchwork.openembedded.****org/patch/44759/<http://**
> > > >> patchwork.openembedded.org/**patch/44759/<
> http://patchwork.openembedded.org/patch/44759/>
> > > >> >
> > > >>      > >>>
> > > >>      > >>> Please use this one instead of the recent one.
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >> Well reading back on that, it looks like I was waiting
> for an
> > > >>      > >> EXTRA_OECONF or related change to the autoconf scripts.
> > > >>      > >>
> > > >>      > >> Sau!
> > > >>      > >
> > > >>      > >
> > > >>      > > hmm. ok, sorry Otavio, i missed the other patch. I will
> check
> > > >>     on my side
> > > >>      > > too about EXTRA_OECONF.
> > > >>      > >
> > > >>      >
> > > >>      > Nicolas, don't worry. It is normal to end redoing some stuff.
> > > >>      >
> > > >>      > Last time I checked it had no support in Qt build system; I
> am
> > > >>     not sure if
> > > >>      > it uses or not the host headers (in case they exist) but it
> needs
> > > >>     testing
> > > >>      > to be sure.
> > > >>
> > > >>     I can confirm that it does not link against host X11 when built
> w/o
> > > >> that
> > > >>     dependency and nativesdk has no x11 libs/headers. As I
> previously
> > > >>     mentioned,
> > > >>     we've been using this fix for over 6 months on several releases
> built
> > > >> on
> > > >>     different machines w/o problems...
> > > >>
> > > >>
> > > >> In this case the patch can be merged 'as is'.
> > > >>
> > > >>
> > > > I am still concerned about a floating dependency here, imagine the
> > > > following:
> > > >
> > > > Build the toolchain with X11 enabled, nativesdk-libx11 is build, now
> > > > rebuild with X11 disabled, the dependency is gone, but the libraries
> and
> > > > headers still exist in the sysroot and thus the configure will still
> enable
> > > > x11 in qte, bad things happen.
> > > >
> > >
> > > I expect different distro features to have different build dirs. No?
> > >
> > >
> > > > We need to have a disable flag to autotools.
> > > >
> > >
> > > The qmake based system does not provide this; so to support it, it will
> > > need to be a hack ...
> >
> > I agree with Otavio here - seems like you are after a rare corner case
> here...
>
> We need determinism in the builds. Yes in this case it might be hard to
> achieve but I do think we need to achieve it.
>
> So this patch isn't going in until we can avoid this option magically
> floating, sorry. I've said this before and I've not changed my mind.
>

It is completely deterministic that it is *broken* for every one not using
a DISTRO with X11; this is deterministic enough for me to justify it go in.
As most of people didn't complain about this before, it is clear most use
*x11* feature and thus this won't affect them.

I see no point in delay it; complete determinism is better - sure - but a
broken Qt toolchain for x11less systems does not improve it.
Nicolas Dechesne - June 7, 2013, 12:19 p.m.
On Thu, Jun 6, 2013 at 5:46 PM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Wed, 2013-06-05 at 16:58 -0400, Denys Dmytriyenko wrote:
> > On Wed, Jun 05, 2013 at 05:56:31PM -0300, Otavio Salvador wrote:
> > > On Wed, Jun 5, 2013 at 5:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > >
> > > > On 06/05/2013 01:10 PM, Otavio Salvador wrote:
> > > >
> > > >>
> > > >>
> > > >>
> > > >> On Wed, Jun 5, 2013 at 5:07 PM, Denys Dmytriyenko <denis@denix.org
> > > >> <mailto:denis@denix.org>> wrote:
> > > >>
> > > >>     On Wed, Jun 05, 2013 at 02:43:07PM -0300, Otavio Salvador wrote:
> > > >>      > On Wed, Jun 5, 2013 at 2:23 PM, Nicolas Dechesne <
> > > >>      > nicolas.dechesne@linaro.org <mailto:nicolas.dechesne@**
> linaro.org<nicolas.dechesne@linaro.org>
> > > >> >>
> > > >>
> > > >>     wrote:
> > > >>      >
> > > >>      > >
> > > >>      > >
> > > >>      > >
> > > >>      > > On Wed, Jun 5, 2013 at 7:19 PM, Saul Wold <
> sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com>> wrote:
> > > >>      > >
> > > >>      > >> On 06/05/2013 10:12 AM, Otavio Salvador wrote:
> > > >>      > >>
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>> On Wed, Jun 5, 2013 at 1:58 PM, Saul Wold
> > > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > > >>      > >>> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com
> >>>
> > > >> wrote:
> > > >>      > >>>
> > > >>      > >>>     On 06/05/2013 09:32 AM, Nicolas Dechesne wrote:
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>         On Wed, Jun 5, 2013 at 6:30 PM, Saul Wold
> > > >>     <sgw@linux.intel.com <mailto:sgw@linux.intel.com>
> > > >>      > >>>         <mailto:sgw@linux.intel.com <mailto:
> > > >> sgw@linux.intel.com>>
> > > >>      > >>>         <mailto:sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com> <mailto:sgw@linux.intel.com
> > > >>     <mailto:sgw@linux.intel.com>>>**>
> > > >>      > >>> wrote:
> > > >>      > >>>
> > > >>      > >>>              You could just directly put the
> nativesdk-libx11
> > > >>     in place
> > > >>      > >>>         of the
> > > >>      > >>>              variable, no need to have the variable
> there.
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>>         yes, that's what I had initially, but found it
> was
> > > >>     less easy to
> > > >>      > >>>         read...
> > > >>      > >>>         with X11DEPENDS it's more 'obvious' that there is
> > > >>     something
> > > >>      > >>>         special..
> > > >>      > >>>         that said, i can make the change if that's really
> > > >> needed.
> > > >>      > >>>
> > > >>      > >>>     We do use the X11DEPENDS elsewhere when there are
> multiple
> > > >>      > >>>     dependencies, but I also found cases where we just
> > > >>     include the
> > > >>      > >>>     dependency directly in the test. I was trying pick a
> > > >>     direction:
> > > >>      > >>>     single entry no X11DEPENDS, multiple entries use
> > > >> X11DEPENDS.
> > > >>      > >>>
> > > >>      > >>>     Comments, flames, ...
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >>> Yes; I sent this patch in Febuary:
> > > >>      > >>>
> > > >>     http://patchwork.openembedded.****org/patch/44759/<http://**
> > > >> patchwork.openembedded.org/**patch/44759/<
> http://patchwork.openembedded.org/patch/44759/>
> > > >> >
> > > >>      > >>>
> > > >>      > >>> Please use this one instead of the recent one.
> > > >>      > >>>
> > > >>      > >>>
> > > >>      > >> Well reading back on that, it looks like I was waiting
> for an
> > > >>      > >> EXTRA_OECONF or related change to the autoconf scripts.
> > > >>      > >>
> > > >>      > >> Sau!
> > > >>      > >
> > > >>      > >
> > > >>      > > hmm. ok, sorry Otavio, i missed the other patch. I will
> check
> > > >>     on my side
> > > >>      > > too about EXTRA_OECONF.
> > > >>      > >
> > > >>      >
> > > >>      > Nicolas, don't worry. It is normal to end redoing some stuff.
> > > >>      >
> > > >>      > Last time I checked it had no support in Qt build system; I
> am
> > > >>     not sure if
> > > >>      > it uses or not the host headers (in case they exist) but it
> needs
> > > >>     testing
> > > >>      > to be sure.
> > > >>
> > > >>     I can confirm that it does not link against host X11 when built
> w/o
> > > >> that
> > > >>     dependency and nativesdk has no x11 libs/headers. As I
> previously
> > > >>     mentioned,
> > > >>     we've been using this fix for over 6 months on several releases
> built
> > > >> on
> > > >>     different machines w/o problems...
> > > >>
> > > >>
> > > >> In this case the patch can be merged 'as is'.
> > > >>
> > > >>
> > > > I am still concerned about a floating dependency here, imagine the
> > > > following:
> > > >
> > > > Build the toolchain with X11 enabled, nativesdk-libx11 is build, now
> > > > rebuild with X11 disabled, the dependency is gone, but the libraries
> and
> > > > headers still exist in the sysroot and thus the configure will still
> enable
> > > > x11 in qte, bad things happen.
> > > >
> > >
> > > I expect different distro features to have different build dirs. No?
> > >
> > >
> > > > We need to have a disable flag to autotools.
> > > >
> > >
> > > The qmake based system does not provide this; so to support it, it will
> > > need to be a hack ...
> >
> > I agree with Otavio here - seems like you are after a rare corner case
> here...
>
> We need determinism in the builds. Yes in this case it might be hard to
> achieve but I do think we need to achieve it.
>
> So this patch isn't going in until we can avoid this option magically
> floating, sorry. I've said this before and I've not changed my mind.
>

I think the -embedded flag in the configure option is what makes a QT build
Embedded vs X11, at least based on [1].

what's disturbing to me is that we use the -embedded flag in
nativesdk-qt4-toos recipe whether we build meta-toolchain-qt or
meta-toolchain-qte, since both ends up with RDEPENDS on
nativesdk-qt4-tools, and we have the -embedded flag here in EXTRA_OECONF,
see [2].

what does that actually imply? unfortunately i am not enough familiar with
that, and I don't get it, but it looks like it could be a problem. are the
generated QT SDK tested in X11 and QTe configuration?

we can clearly see in [3] and [4] that we play with the -embedded flag when
building the target qt4 recipe, though.

[1] http://qt-project.org/doc/qt-4.8/qt-embedded-install.html
[2]
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-qt/qt4/qt4-native.inc#n38
[3]
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-qt/qt4/qt4-embedded.inc#n13
[4]
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-qt/qt4/qt4-x11-free_4.8.4.bb#n8


> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
index cfc6fd8..3725cac 100644
--- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
+++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
@@ -1,5 +1,6 @@ 
 DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
-DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
+X11DEPENDS = "nativesdk-libx11"
+DEPENDS = "nativesdk-zlib nativesdk-dbus qt4-native ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
 SECTION = "libs"
 HOMEPAGE = "http://qt.nokia.com"
 LICENSE = "LGPLv2.1 | GPLv3"