Patchwork gst-plugins-package.inc: Allow ${PN}-apps and ${PN}-glib to be empty

login
register
mail settings
Submitter Otavio Salvador
Date June 3, 2013, 4:53 p.m.
Message ID <1370278425-22062-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/51109/
State New
Headers show

Comments

Otavio Salvador - June 3, 2013, 4:53 p.m.
The ${PN}-meta package rdepends on ${PN}-apps and ${PN}-glib so we
need to have them available or the installation of the meta package
will fail.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
This patch is need to make the meta packages work. This should also be
applied in dylan branch as currently ${PN}-meta packages are not
installable.

 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 2 ++
 1 file changed, 2 insertions(+)
Otavio Salvador - June 3, 2013, 4:54 p.m.
Hello Paul,

On Mon, Jun 3, 2013 at 1:53 PM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> The ${PN}-meta package rdepends on ${PN}-apps and ${PN}-glib so we
> need to have them available or the installation of the meta package
> will fail.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> This patch is need to make the meta packages work. This should also be
> applied in dylan branch as currently ${PN}-meta packages are not
> installable.
>

Forgot to add you to CC, sorry.
dv - June 3, 2013, 5:43 p.m.
On 03.06.2013 18:53, Otavio Salvador wrote:
> The ${PN}-meta package rdepends on ${PN}-apps and ${PN}-glib so we
> need to have them available or the installation of the meta package
> will fail.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> This patch is need to make the meta packages work. This should also be
> applied in dylan branch as currently ${PN}-meta packages are not
> installable.
>
>   meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> index 7ae3ef6..b768094 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> @@ -28,6 +28,8 @@ python populate_packages_prepend () {
>   # each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev
>   # so we need them even when empty (like in gst-plugins-good case)
>   ALLOW_EMPTY_${PN} = "1"
> +ALLOW_EMPTY_${PN}-apps = "1"
> +ALLOW_EMPTY_${PN}-glib = "1"
>   ALLOW_EMPTY_${PN}-dev = "1"
>   ALLOW_EMPTY_${PN}-staticdev = "1"
>   

Note that I posted a similar patch here some time ago, and the concern 
about unnecessary empty packages was raised. My proposed OE-core 
GStreamer 1.0 patches include code that takes care of this by adding 
packages to the -meta rdepends only if they are not empty.
Otavio Salvador - June 3, 2013, 7:02 p.m.
On Mon, Jun 3, 2013 at 2:43 PM, Carlos Rafael Giani
<dv@pseudoterminal.org>wrote:

> On 03.06.2013 18:53, Otavio Salvador wrote:
>
>> The ${PN}-meta package rdepends on ${PN}-apps and ${PN}-glib so we
>> need to have them available or the installation of the meta package
>> will fail.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> This patch is need to make the meta packages work. This should also be
>> applied in dylan branch as currently ${PN}-meta packages are not
>> installable.
>>
>>   meta/recipes-multimedia/**gstreamer/gst-plugins-package.**inc | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-multimedia/**gstreamer/gst-plugins-package.**inc
>> b/meta/recipes-multimedia/**gstreamer/gst-plugins-package.**inc
>> index 7ae3ef6..b768094 100644
>> --- a/meta/recipes-multimedia/**gstreamer/gst-plugins-package.**inc
>> +++ b/meta/recipes-multimedia/**gstreamer/gst-plugins-package.**inc
>> @@ -28,6 +28,8 @@ python populate_packages_prepend () {
>>   # each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev
>> on PN-staticdev
>>   # so we need them even when empty (like in gst-plugins-good case)
>>   ALLOW_EMPTY_${PN} = "1"
>> +ALLOW_EMPTY_${PN}-apps = "1"
>> +ALLOW_EMPTY_${PN}-glib = "1"
>>   ALLOW_EMPTY_${PN}-dev = "1"
>>   ALLOW_EMPTY_${PN}-staticdev = "1"
>>
>>
>
> Note that I posted a similar patch here some time ago, and the concern
> about unnecessary empty packages was raised. My proposed OE-core GStreamer
> 1.0 patches include code that takes care of this by adding packages to the
> -meta rdepends only if they are not empty.
>

Oh; good. Maybe you could split this patch from it so we can have it
applied and easy to backport to dylan?
dv - June 3, 2013, 7:04 p.m.
This can be done already. The first patch (search for "[OE-core] [PATCH 
1/3] gstreamer: fixed -meta package rdepends") can be applied, and does 
not depend on GStreamer 1.0. I bundled it together with the rest since 
the other patches need this one.

cheers

On 2013-06-03 21:02, Otavio Salvador wrote:
>
>
>
> On Mon, Jun 3, 2013 at 2:43 PM, Carlos Rafael Giani 
> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>
>     On 03.06.2013 18:53, Otavio Salvador wrote:
>
>         The ${PN}-meta package rdepends on ${PN}-apps and ${PN}-glib so we
>         need to have them available or the installation of the meta
>         package
>         will fail.
>
>         Signed-off-by: Otavio Salvador <otavio@ossystems.com.br
>         <mailto:otavio@ossystems.com.br>>
>         ---
>         This patch is need to make the meta packages work. This should
>         also be
>         applied in dylan branch as currently ${PN}-meta packages are not
>         installable.
>
>           meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 2 ++
>           1 file changed, 2 insertions(+)
>
>         diff --git
>         a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
>         b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
>         index 7ae3ef6..b768094 100644
>         --- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
>         +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
>         @@ -28,6 +28,8 @@ python populate_packages_prepend () {
>           # each plugin depends on PN, plugin-dev on PN-dev and
>         plugin-staticdev on PN-staticdev
>           # so we need them even when empty (like in gst-plugins-good
>         case)
>           ALLOW_EMPTY_${PN} = "1"
>         +ALLOW_EMPTY_${PN}-apps = "1"
>         +ALLOW_EMPTY_${PN}-glib = "1"
>           ALLOW_EMPTY_${PN}-dev = "1"
>           ALLOW_EMPTY_${PN}-staticdev = "1"
>
>
>     Note that I posted a similar patch here some time ago, and the
>     concern about unnecessary empty packages was raised. My proposed
>     OE-core GStreamer 1.0 patches include code that takes care of this
>     by adding packages to the -meta rdepends only if they are not empty.
>
>
> Oh; good. Maybe you could split this patch from it so we can have it 
> applied and easy to backport to dylan?
>
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Otavio Salvador - June 3, 2013, 7:06 p.m.
On Mon, Jun 3, 2013 at 4:04 PM, Carlos Rafael Giani
<dv@pseudoterminal.org>wrote:

>  This can be done already. The first patch (search for "[OE-core] [PATCH
> 1/3] gstreamer: fixed -meta package rdepends") can be applied, and does not
> depend on GStreamer 1.0. I bundled it together with the rest since the
> other patches need this one.
>

Awesome.

Paul, please drop my patch from your queue and check Carlos' one. :)

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
index 7ae3ef6..b768094 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
@@ -28,6 +28,8 @@  python populate_packages_prepend () {
 # each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev
 # so we need them even when empty (like in gst-plugins-good case)
 ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-apps = "1"
+ALLOW_EMPTY_${PN}-glib = "1"
 ALLOW_EMPTY_${PN}-dev = "1"
 ALLOW_EMPTY_${PN}-staticdev = "1"