Patchwork bdwgc: fix recipe

login
register
mail settings
Submitter Bogdan Marinescu
Date June 3, 2013, 1:59 p.m.
Message ID <1370267962-23207-1-git-send-email-bogdan.a.marinescu@intel.com>
Download mbox | patch
Permalink /patch/51103/
State New
Headers show

Comments

Bogdan Marinescu - June 3, 2013, 1:59 p.m.
bdwgc has version names that may or may not contain a revision
(for example 7.2d or simply 7.2). The current recipe specifies
the revision as a separate variable, which confuses the automatic
version checker. This patch enables using the full version name
as part of the recipe name.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
 meta/recipes-support/bdwgc/{bdwgc_7.2.bb => bdwgc_7.2d.bb} |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
 rename meta/recipes-support/bdwgc/{bdwgc_7.2.bb => bdwgc_7.2d.bb} (91%)
Richard Purdie - June 3, 2013, 4:01 p.m.
On Mon, 2013-06-03 at 16:59 +0300, Bogdan Marinescu wrote:
> bdwgc has version names that may or may not contain a revision
> (for example 7.2d or simply 7.2). The current recipe specifies
> the revision as a separate variable, which confuses the automatic
> version checker. This patch enables using the full version name
> as part of the recipe name.
> 
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>  meta/recipes-support/bdwgc/{bdwgc_7.2.bb => bdwgc_7.2d.bb} |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>  rename meta/recipes-support/bdwgc/{bdwgc_7.2.bb => bdwgc_7.2d.bb} (91%)

I'm going to start getting more picky about these summaries as they're
not useful :(.

"fix recipe" tells me nothing about what this change actually does.
Please resent with a more better summary that related to what the change
does.

Cheers,

Richard

Patch

diff --git a/meta/recipes-support/bdwgc/bdwgc_7.2.bb b/meta/recipes-support/bdwgc/bdwgc_7.2d.bb
similarity index 91%
rename from meta/recipes-support/bdwgc/bdwgc_7.2.bb
rename to meta/recipes-support/bdwgc/bdwgc_7.2d.bb
index a0a5bff..b5a6831 100644
--- a/meta/recipes-support/bdwgc/bdwgc_7.2.bb
+++ b/meta/recipes-support/bdwgc/bdwgc_7.2d.bb
@@ -23,17 +23,15 @@  LIC_FILES_CHKSUM = "file://README.QUICK;md5=9b9dd874f6940641b6ab19893ee8f1cc \
                     file://doc/README;md5=92e7dd0334d1f672b699cd0aca08bef0 \
                     file://libatomic_ops/doc/LICENSING.txt;md5=607073e04548eac7d1f763e480477bab"
 
-REVISION = "d"
-
-SRC_URI = "http://www.hpl.hp.com/personal/Hans_Boehm/gc/gc_source/gc-${PV}${REVISION}.tar.gz"
+SRC_URI = "http://www.hpl.hp.com/personal/Hans_Boehm/gc/gc_source/gc-${PV}.tar.gz"
 
 SRC_URI[md5sum] = "91340b28c61753a789eb6077675d87d2"
 SRC_URI[sha256sum] = "d9fe0ae8650d43746a48bfb394cab01a319f3809cee19f8ebd16aa985b511c5e"
 FILES_${PN}-doc = "/usr/share"
 
-PR = "r0"
-
-S = "${WORKDIR}/gc-${PV}"
+PR = "r1"
+REAL_PV = "${@[d.getVar('PV',1)[:-1], d.getVar('PV',1)][(d.getVar('PV',1)[-1]).isdigit()]}"
+S = "${WORKDIR}/gc-${REAL_PV}"
 
 ARM_INSTRUCTION_SET = "arm"