Patchwork Revert "perl-native: create_wrapper on perl${PV} too"

login
mail settings
Submitter Paul Menzel
Date May 30, 2011, 7:16 p.m.
Message ID <1306782978.4106.483.camel@mattotaupa>
Download mbox | patch
Permalink /patch/5093/
State Superseded
Commit d8d2e1730a4e941bfeb5075c7816543ab201f9e0
Headers show

Comments

Paul Menzel - May 30, 2011, 7:16 p.m.
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Mon, 30 May 2011 21:08:24 +0200

This reverts commit 1e255fbd296e95ff178d66c4a1fe4875a988d7e1.

	Author: Tom Rini <tom_rini@mentor.com>
	Date:   Mon May 16 13:06:33 2011 -0700

		  perl-native: create_wrapper on perl${PV} too

		  perl${PV} becomes hostperl when building for the target so we need a
		  wrapper on that too.

		  Signed-off-by: Tom Rini <tom_rini@mentor.com>

It breaks task compile of perl using `angstrom-2010.x` or `minimal{,-uclibc}` for `MACHINE = "beagleboard"` [1].

[…]
| mv -f miniperl miniperl-target
| ln -s hostperl miniperl
| LD_LIBRARY_PATH=/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/perl-5.10.1${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH ./miniperl -Ilib make_patchnum.pl
| env: ./perl5.10.1.real: No such file or directory
| make[1]: *** [lib/Config_git.pl] Error 127
| make[1]: Leaving directory `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/perl-5.10.1'
| make[1]: Entering directory `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/perl-5.10.1'
| LD_LIBRARY_PATH=/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/perl-5.10.1${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH ./miniperl -Ilib autodoc.pl
| env: ./perl5.10.1.real: No such file or directory
| make[1]: *** [pod/perlapi.pod] Error 127
| make[1]: Leaving directory `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/perl-5.10.1'
| make: *** [perl] Error 2
[…]

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032981.html

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Tom Rini <tom_rini@mentor.com>
---
A fix is preferred though. ;-) Probably `PR` needs to be updated somehow too.
---
 recipes/perl/perl-native_5.10.1.bb |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Andreas Müller - May 30, 2011, 8:29 p.m.
On Monday, May 30, 2011 09:16:18 PM Paul Menzel wrote:
> From: Paul Menzel <paulepanter@users.sourceforge.net>
> Date: Mon, 30 May 2011 21:08:24 +0200
> 
> This reverts commit 1e255fbd296e95ff178d66c4a1fe4875a988d7e1.
> 
> 	Author: Tom Rini <tom_rini@mentor.com>
> 	Date:   Mon May 16 13:06:33 2011 -0700
> 
> 		  perl-native: create_wrapper on perl${PV} too
> 
> 		  perl${PV} becomes hostperl when building for the target so we need a
> 		  wrapper on that too.
> 
> 		  Signed-off-by: Tom Rini <tom_rini@mentor.com>
> 
> It breaks task compile of perl using `angstrom-2010.x` or
> `minimal{,-uclibc}` for `MACHINE = "beagleboard"` [1].
> 
> […]
> 
> | mv -f miniperl miniperl-target
> | ln -s hostperl miniperl
> | LD_LIBRARY_PATH=/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/pe
> | rl-5.10.1-r22/perl-5.10.1${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH ./miniperl
> | -Ilib make_patchnum.pl env: ./perl5.10.1.real: No such file or directory
> | make[1]: *** [lib/Config_git.pl] Error 127
> | make[1]: Leaving directory
> | `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/
> | perl-5.10.1' make[1]: Entering directory
> | `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/
> | perl-5.10.1'
> | LD_LIBRARY_PATH=/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/p
> | erl-5.10.1-r22/perl-5.10.1${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH
> | ./miniperl -Ilib autodoc.pl env: ./perl5.10.1.real: No such file or
> | directory
> | make[1]: *** [pod/perlapi.pod] Error 127
> | make[1]: Leaving directory
> | `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/perl-5.10.1-r22/
> | perl-5.10.1' make: *** [perl] Error 2
> 
> […]
> 
> [1]
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032981.ht
> ml
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> CC: Tom Rini <tom_rini@mentor.com>
> ---
> A fix is preferred though. ;-) Probably `PR` needs to be updated somehow
> too. ---
>  recipes/perl/perl-native_5.10.1.bb |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/perl/perl-native_5.10.1.bb
> b/recipes/perl/perl-native_5.10.1.bb index fdbe055..3dafc10 100644
> --- a/recipes/perl/perl-native_5.10.1.bb
> +++ b/recipes/perl/perl-native_5.10.1.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Perl is a popular scripting language."
>  HOMEPAGE = "http://www.perl.org/"
>  SECTION = "libs"
>  LICENSE = "Artistic|GPLv1+"
> -PR = "r11"
> +PR = "r10"
>  NATIVE_INSTALL_WORKS = "1"
>  INHIBIT_DEFAULT_DEPS = "1"
>  PATCHTOOL = "patch"
> @@ -108,7 +108,6 @@ do_install() {
>  	done
> 
>  	create_wrapper ${D}${bindir}/perl
> PERL5LIB='$PERL5LIB:${STAGING_LIBDIR}/perl/${PV}:${STAGING_LIBDIR}/perl/'
> -	create_wrapper ${D}${bindir}/perl${PV}
> PERL5LIB='$PERL5LIB:${STAGING_LIBDIR}/perl/${PV}:${STAGING_LIBDIR}/perl/'
> }
> 
>  do_install_append_nylon() {
Hello Paul,

Isn't that exactly what [1] wants to fix and was described in [2] (sorry for late 
night english written there :-)

Andreas

[1] http://patches.openembedded.org/patch/4923/
[2] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032981.html
Paul Menzel - May 31, 2011, 8:40 a.m.
Dear Andreas,


Am Montag, den 30.05.2011, 22:29 +0200 schrieb Andreas Mueller:
> On Monday, May 30, 2011 09:16:18 PM Paul Menzel wrote:
> > From: Paul Menzel <paulepanter@users.sourceforge.net>
> > Date: Mon, 30 May 2011 21:08:24 +0200
> > 
> > This reverts commit 1e255fbd296e95ff178d66c4a1fe4875a988d7e1.

[…]

> > [1]
> > http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032981.ht
> > ml

Please make sure to not line wrap quoted texts.

[…]

> Isn't that exactly what [1] wants to fix

Yes. I thought that such a patch was sent to the list, but I could not
find it in my inbox because I had deleted you message already and I only
searched for perl in Patchwork [3].

> and was described in [2] (sorry for late night english written there :-)

Yes. That is why I even sent this patch even as a reply in this thread.

Since I have deleted the patch already could you please resend the patch
as a reply to your original patch message so I can add my Acked-by line.

I will update the status of my patch soonish.


Thanks,

Paul


PS: Do you have commit access already?


> [1] http://patches.openembedded.org/patch/4923/
> [2] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032981.html
[3] http://patches.openembedded.org/project/oe/list/
Tom Rini - May 31, 2011, 2:59 p.m.
On 05/30/2011 12:16 PM, Paul Menzel wrote:
> From: Paul Menzel <paulepanter@users.sourceforge.net>
> Date: Mon, 30 May 2011 21:08:24 +0200
> 
> This reverts commit 1e255fbd296e95ff178d66c4a1fe4875a988d7e1.
> 
> 	Author: Tom Rini <tom_rini@mentor.com>
> 	Date:   Mon May 16 13:06:33 2011 -0700
> 
> 		  perl-native: create_wrapper on perl${PV} too
> 
> 		  perl${PV} becomes hostperl when building for the target so we need a
> 		  wrapper on that too.
> 
> 		  Signed-off-by: Tom Rini <tom_rini@mentor.com>
> 
> It breaks task compile of perl using `angstrom-2010.x` or `minimal{,-uclibc}` for `MACHINE = "beagleboard"` [1].

Didn't another change go in which fixes this go in?
Martin Jansa - May 31, 2011, 3:06 p.m.
On Tue, May 31, 2011 at 07:59:34AM -0700, Tom Rini wrote:
> On 05/30/2011 12:16 PM, Paul Menzel wrote:
> > From: Paul Menzel <paulepanter@users.sourceforge.net>
> > Date: Mon, 30 May 2011 21:08:24 +0200
> > 
> > This reverts commit 1e255fbd296e95ff178d66c4a1fe4875a988d7e1.
> > 
> > 	Author: Tom Rini <tom_rini@mentor.com>
> > 	Date:   Mon May 16 13:06:33 2011 -0700
> > 
> > 		  perl-native: create_wrapper on perl${PV} too
> > 
> > 		  perl${PV} becomes hostperl when building for the target so we need a
> > 		  wrapper on that too.
> > 
> > 		  Signed-off-by: Tom Rini <tom_rini@mentor.com>
> > 
> > It breaks task compile of perl using `angstrom-2010.x` or `minimal{,-uclibc}` for `MACHINE = "beagleboard"` [1].
> 
> Didn't another change go in which fixes this go in?

IIRC this fixed it in oe-core:
http://git.openembedded.org/cgit.cgi/openembedded-core/commit/?id=a10bd976f4cef54ac50b0c82f885c17a26e5989f

Patch

diff --git a/recipes/perl/perl-native_5.10.1.bb b/recipes/perl/perl-native_5.10.1.bb
index fdbe055..3dafc10 100644
--- a/recipes/perl/perl-native_5.10.1.bb
+++ b/recipes/perl/perl-native_5.10.1.bb
@@ -2,7 +2,7 @@  DESCRIPTION = "Perl is a popular scripting language."
 HOMEPAGE = "http://www.perl.org/"
 SECTION = "libs"
 LICENSE = "Artistic|GPLv1+"
-PR = "r11"
+PR = "r10"
 NATIVE_INSTALL_WORKS = "1"
 INHIBIT_DEFAULT_DEPS = "1"
 PATCHTOOL = "patch"
@@ -108,7 +108,6 @@  do_install() {
 	done
 
 	create_wrapper ${D}${bindir}/perl PERL5LIB='$PERL5LIB:${STAGING_LIBDIR}/perl/${PV}:${STAGING_LIBDIR}/perl/'
-	create_wrapper ${D}${bindir}/perl${PV} PERL5LIB='$PERL5LIB:${STAGING_LIBDIR}/perl/${PV}:${STAGING_LIBDIR}/perl/'
 }
 
 do_install_append_nylon() {