Patchwork [v3] tiobench: Add version 0.3.3 (initial recipe)

login
register
mail settings
Submitter Paul Menzel
Date May 30, 2011, 7:04 p.m.
Message ID <1306782295.4106.479.camel@mattotaupa>
Download mbox | patch
Permalink /patch/5091/
State Accepted
Commit 0052931adafee8db2bc4c9221934aa2ebae8f69b
Headers show

Comments

Paul Menzel - May 30, 2011, 7:04 p.m.
From: Ludovic Desroches <ludovic.desroches@atmel.com>
Date: Mon, 30 May 2011 18:43:14 +0200

Build tested
• with task-base image with the tiobench package on atmel boards by Ludovic Desroches and
• using `angstrom-2010.x` and `minimal{,-uclibc}` for `MACHINE = "beagleboard"` by Paul Menzel.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
v2 ? v3
• sort dependencies
• update `LICENSE`
• remove overrides, which are the defaults
• use ${PN} and ${P}
• rename directory for the patch

Ludovic, could you please test the updated patch and tell me if you send the Makefile patch upstream.
---
 .../tiobench-0.3.3/tiobench-makefile.patch         |   47 ++++++++++++++++++++
 recipes/tiobench/tiobench_0.3.3.bb                 |   24 ++++++++++
 2 files changed, 71 insertions(+), 0 deletions(-)
 create mode 100644 recipes/tiobench/tiobench-0.3.3/tiobench-makefile.patch
 create mode 100644 recipes/tiobench/tiobench_0.3.3.bb
Ludovic Desroches - May 31, 2011, 7:08 a.m.
Hello Paul,

On 5/30/2011 9:04 PM, Paul Menzel wrote:
> From: Ludovic Desroches<ludovic.desroches@atmel.com>
> Date: Mon, 30 May 2011 18:43:14 +0200
>
> Build tested
> • with task-base image with the tiobench package on atmel boards by Ludovic Desroches and
> • using `angstrom-2010.x` and `minimal{,-uclibc}` for `MACHINE = "beagleboard"` by Paul Menzel.
>
> Signed-off-by: Ludovic Desroches<ludovic.desroches@atmel.com>
> Signed-off-by: Paul Menzel<paulepanter@users.sourceforge.net>
> ---
> v2 ? v3
> • sort dependencies
> • update `LICENSE`
> • remove overrides, which are the defaults
> • use ${PN} and ${P}
> • rename directory for the patch
>
> Ludovic, could you please test the updated patch and tell me if you send the Makefile patch upstream.
No problem, it is still ok. Thanks for your help. It's good for me to 
see how this recipe has to look like since we can find different ways 
into other (maybe old) recipes. I confess I have seen some of the 
changes you asked but I forget them!

I have not sent the Makefile patch upstream, since the last release is 
quite old, I don't know the project is still active.

Regards,

Ludovic
Paul Menzel - May 31, 2011, 8:11 a.m.
Dear Ludovic,


Am Dienstag, den 31.05.2011, 09:08 +0200 schrieb Ludovic Desroches:

> On 5/30/2011 9:04 PM, Paul Menzel wrote:
> > From: Ludovic Desroches<ludovic.desroches@atmel.com>
> > Date: Mon, 30 May 2011 18:43:14 +0200
> >
> > Build tested
> > • with task-base image with the tiobench package on atmel boards by Ludovic Desroches and
> > • using `angstrom-2010.x` and `minimal{,-uclibc}` for `MACHINE = "beagleboard"` by Paul Menzel.
> >
> > Signed-off-by: Ludovic Desroches<ludovic.desroches@atmel.com>
> > Signed-off-by: Paul Menzel<paulepanter@users.sourceforge.net>
> > ---
> > v2 ? v3
> > • sort dependencies
> > • update `LICENSE`
> > • remove overrides, which are the defaults
> > • use ${PN} and ${P}
> > • rename directory for the patch
> >
> > Ludovic, could you please test the updated patch and tell me if you send the Makefile patch upstream.
> No problem, it is still ok. Thanks for your help. It's good for me to 
> see how this recipe has to look like since we can find different ways 
> into other (maybe old) recipes. I confess I have seen some of the 
> changes you asked but I forget them!
> 
> I have not sent the Makefile patch upstream, since the last release is 
> quite old, I don't know the project is still active.

It does not look like that. Looking at the CVS log it seems like
tiobench 0.4.1 should have been released somehow. Anyhow, it never hurts
to send the patch to the author mentioned in `README`.

I will commit your patch probably tomorrow to give others time for
comments.


Thanks,

Paul
Paul Menzel - June 9, 2011, 7:35 p.m.
Dear Ludovic,


Am Dienstag, den 31.05.2011, 10:11 +0200 schrieb Paul Menzel:

[…]

> I will commit your patch probably tomorrow to give others time for
> comments.

I am sorry, that it took longer. Please update the state of the sent
patches in our patch queue [1].


Thanks,

Paul


[1] http://openembedded.org/index.php/Patchwork

Patch

diff --git a/recipes/tiobench/tiobench-0.3.3/tiobench-makefile.patch b/recipes/tiobench/tiobench-0.3.3/tiobench-makefile.patch
new file mode 100644
index 0000000..f924c1b
--- /dev/null
+++ b/recipes/tiobench/tiobench-0.3.3/tiobench-makefile.patch
@@ -0,0 +1,47 @@ 
+Author: Ludovic Desroches <ludovic.desroches@atmel.com>
+
+Adapt tiobench to OE
+Index: Makefile
+===================================================================
+--- a/Makefile	2011-05-26 07:48:46.341400974 +0200
++++ b/Makefile	2011-05-30 06:32:38.091401358 +0200
+@@ -1,8 +1,9 @@
+ # Makefile for tiotest
+ 
+-CC=gcc
++CC?=gcc
+ #CFLAGS=-O3 -fomit-frame-pointer -Wall
+ CFLAGS=-O2 -Wall
++LDFLAGS?=
+ 
+ #DEFINES=-DUSE_MMAP 
+ #-DUSE_MADVISE
+@@ -14,16 +15,16 @@
+ 
+ #DEFINES=
+ 
+-LINK=gcc
++LINK?=$(CC)
+ EXE=tiotest
+ PROJECT=tiobench
+ # do it once instead of each time referenced
+ VERSION=$(shell egrep "tiotest v[0-9]+.[0-9]+" tiotest.c | cut -d " " -f 7 | sed "s/v//g")
+ DISTNAME=$(PROJECT)-$(VERSION)
+ INSTALL=install
+-PREFIX=/usr/local
++PREFIX?=/usr/local
+ BINDIR=$(PREFIX)/bin
+-DOCDIR=/usr/local/doc/$(DISTNAME)
++DOCDIR=$(PREFIX)/doc/$(DISTNAME)
+ 
+ all: $(EXE)
+ 
+@@ -34,7 +35,7 @@
+ 	$(CC) -c $(CFLAGS) $(DEFINES) tiotest.c -o tiotest.o
+ 
+ $(EXE): tiotest.o crc32.o
+-	$(LINK) -o $(EXE) tiotest.o crc32.o -lpthread
++	$(LINK) -o $(EXE) tiotest.o crc32.o -lpthread $(LDFLAGS)
+ 	@echo
+ 	@echo "./tiobench.pl --help for usage options"
+ 	@echo
diff --git a/recipes/tiobench/tiobench_0.3.3.bb b/recipes/tiobench/tiobench_0.3.3.bb
new file mode 100644
index 0000000..55894e3
--- /dev/null
+++ b/recipes/tiobench/tiobench_0.3.3.bb
@@ -0,0 +1,24 @@ 
+DESCRIPTION = "Threaded I/O tester"
+HOMEPAGE = "http://sourceforge.net/projects/tiobench/"
+LICENSE = "GPLv2"
+RDEPENDS = "\
+    perl \
+    perl-module-exporter-heavy \
+    perl-module-getopt-long \
+    perl-module-overload \
+    perl-module-strict \
+    "
+PR = "r0"
+
+SRC_URI = "\
+    http://sourceforge.net/projects/tiobench/files/tiobench/${PV}/${P}.tar.gz \
+    file://tiobench-makefile.patch \
+    "
+SRC_URI[md5sum] = "bf485bf820e693c79e6bd2a38702a128"
+SRC_URI[sha256sum] = "8ad011059a35ac70cdb5e3d3999ceee44a8e8e9078926844b0685b7ea9db2bcc"
+
+EXTRA_OEMAKE = "PREFIX=${D}"
+
+do_install() {
+    oe_runmake install
+}