Patchwork [v2,2/2] gtk-icon-cache pixbufcache: add a clear dependency on gdk-pixbuf-native

login
register
mail settings
Submitter Eric BENARD
Date May 30, 2013, 8:40 p.m.
Message ID <1369946430-12959-2-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/50885/
State New
Headers show

Comments

Eric BENARD - May 30, 2013, 8:40 p.m.
not really sure if the dependency is always inherited but at least
there won't be bad surprise.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 meta/classes/gtk-icon-cache.bbclass | 2 +-
 meta/classes/pixbufcache.bbclass    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - May 31, 2013, 6:35 a.m.
On 05/31/2013 05:40 AM, Eric Bénard wrote:
> not really sure if the dependency is always inherited but at least
> there won't be bad surprise.
>
This seems to have caused a circular dependency, not sure the exact 
nature, please verify this.

There might have been a patch from someone else recently, so please 
check the latest master.

Thanks
    Sau!

> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>   meta/classes/gtk-icon-cache.bbclass | 2 +-
>   meta/classes/pixbufcache.bbclass    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
> index 789fa38..8ed7feb 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -1,6 +1,6 @@
>   FILES_${PN} += "${datadir}/icons/hicolor"
>
> -DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native"
> +DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native gdk-pixbuf-native"
>
>   gtk_icon_cache_postinst() {
>   if [ "x$D" != "x" ]; then
> diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
> index 274d67d..4ac17ee 100644
> --- a/meta/classes/pixbufcache.bbclass
> +++ b/meta/classes/pixbufcache.bbclass
> @@ -3,7 +3,7 @@
>   # packages.
>   #
>
> -DEPENDS += "qemu-native"
> +DEPENDS += "qemu-native gdk-pixbuf-native"
>   inherit qemu
>
>   PIXBUF_PACKAGES ??= "${PN}"
>
Eric BENARD - May 31, 2013, 6:55 a.m.
Le Fri, 31 May 2013 15:35:35 +0900,
Saul Wold <sgw@linux.intel.com> a écrit :

> On 05/31/2013 05:40 AM, Eric Bénard wrote:
> > not really sure if the dependency is always inherited but at least
> > there won't be bad surprise.
> >
> This seems to have caused a circular dependency, not sure the exact 
> nature, please verify this.
> 
> There might have been a patch from someone else recently, so please 
> check the latest master.
> 
ok please forget this one it will need more testing if it's required at
all

Eric

Patch

diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
index 789fa38..8ed7feb 100644
--- a/meta/classes/gtk-icon-cache.bbclass
+++ b/meta/classes/gtk-icon-cache.bbclass
@@ -1,6 +1,6 @@ 
 FILES_${PN} += "${datadir}/icons/hicolor"
 
-DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native"
+DEPENDS += "${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk-update-icon-cache-native gdk-pixbuf-native"
 
 gtk_icon_cache_postinst() {
 if [ "x$D" != "x" ]; then
diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
index 274d67d..4ac17ee 100644
--- a/meta/classes/pixbufcache.bbclass
+++ b/meta/classes/pixbufcache.bbclass
@@ -3,7 +3,7 @@ 
 # packages.
 #
 
-DEPENDS += "qemu-native"
+DEPENDS += "qemu-native gdk-pixbuf-native"
 inherit qemu
 
 PIXBUF_PACKAGES ??= "${PN}"