Patchwork [1/2] hicolor-icon-theme: keep inherited dependencies

login
register
mail settings
Submitter Eric BENARD
Date May 30, 2013, 7:44 a.m.
Message ID <1369899843-3318-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/50795/
State New
Headers show

Comments

Eric BENARD - May 30, 2013, 7:44 a.m.
else, if an image installs hicolor-icon-theme without any other
gnome package, the dependency on gdk-pixbuf-native will be missing
and if it exists, the host gdk-pixbuf-query-loaders binary will be
used and it will try to update the host's cache

[YOCTO #4572]

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
this patch will need some testing as it's not clear to me why this dependency was forced to "". At least that fix the problem described in the bug report.
 meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb | 2 --
 1 file changed, 2 deletions(-)
Martin Jansa - May 30, 2013, 8:09 a.m.
Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
brings gconf.


On Thu, May 30, 2013 at 9:44 AM, Eric Bénard <eric@eukrea.com> wrote:

> else, if an image installs hicolor-icon-theme without any other
> gnome package, the dependency on gdk-pixbuf-native will be missing
> and if it exists, the host gdk-pixbuf-query-loaders binary will be
> used and it will try to update the host's cache
>
> [YOCTO #4572]
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> this patch will need some testing as it's not clear to me why this
> dependency was forced to "". At least that fix the problem described in the
> bug report.
>  meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-gnome/hicolor-icon-theme/
> hicolor-icon-theme_0.12.bb b/meta/recipes-gnome/hicolor-icon-theme/
> hicolor-icon-theme_0.12.bb
> index 7c911e0..8d48dec 100644
> --- a/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> +++ b/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
> @@ -8,8 +8,6 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=f08a446809913fc9b3c718f0eaea0426"
>  SECTION = "unknown"
>  inherit gnome allarch
>
> -DEPENDS = ""
> -
>  PR = "r1"
>
>  SRC_URI = "http://icon-theme.freedesktop.org/releases/${BPN}-${PV}.tar.gz\
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Ross Burton - May 30, 2013, 8:32 a.m.
On 30 May 2013 09:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> brings gconf.

gnome.bbclass is an abomination and should be gutted.  Yes, this will
mean the build dependencies are massive, and I can't see why this
recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
either as it doesn't actually have any icons in.  I'd be interested in
seeing a buildhistory-diff between the current recipe and one with
both inherit gnome and DEPENDS="" removed.

Ross
Eric BENARD - May 30, 2013, 10:32 a.m.
Le Thu, 30 May 2013 09:32:38 +0100,
"Burton, Ross" <ross.burton@intel.com> a écrit :

> On 30 May 2013 09:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> > Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> > brings gconf.
> 
> gnome.bbclass is an abomination and should be gutted.  Yes, this will
> mean the build dependencies are massive, and I can't see why this
> recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
> either as it doesn't actually have any icons in.  I'd be interested in
> seeing a buildhistory-diff between the current recipe and one with
> both inherit gnome and DEPENDS="" removed.
> 
when  removing gnome I get the following error at install :
DEBUG: Executing shell function do_install
install: cannot create regular file
`/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such
file or directory

Eric
Eric BENARD - May 30, 2013, 10:34 a.m.
Le Thu, 30 May 2013 10:09:36 +0200,
Martin Jansa <martin.jansa@gmail.com> a écrit :

> Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> brings gconf.
> 
true :
  * DEPENDS: added "shared-mime-info gnome-common-native
shared-mime-info-native gtk-update-icon-cache-native gconf gconf-native"

Eric
Eric BENARD - May 30, 2013, 10:48 a.m.
Hi Ross,

Le Thu, 30 May 2013 12:32:30 +0200,
Eric Bénard <eric@eukrea.com> a écrit :

> Le Thu, 30 May 2013 09:32:38 +0100,
> "Burton, Ross" <ross.burton@intel.com> a écrit :
> 
> > On 30 May 2013 09:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> > > brings gconf.
> > 
> > gnome.bbclass is an abomination and should be gutted.  Yes, this will
> > mean the build dependencies are massive, and I can't see why this
> > recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
> > either as it doesn't actually have any icons in.  I'd be interested in
> > seeing a buildhistory-diff between the current recipe and one with
> > both inherit gnome and DEPENDS="" removed.
> > 
> when  removing gnome I get the following error at install :
> DEBUG: Executing shell function do_install
> install: cannot create regular file
> `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
> nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such
> file or directory
> 
turning on the brain and fixing do_install, the diff between original et
new (without gnome and DEPENDS="") is :

packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme:
pkg_postinst cleared:
packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme: pkg_postrm
cleared:

So that seems the right thing to do don't you think ?

Eric
Richard Purdie - May 30, 2013, 10:49 a.m.
On Thu, 2013-05-30 at 12:32 +0200, Eric Bénard wrote:
> Le Thu, 30 May 2013 09:32:38 +0100,
> "Burton, Ross" <ross.burton@intel.com> a écrit :
> 
> > On 30 May 2013 09:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> > > brings gconf.
> > 
> > gnome.bbclass is an abomination and should be gutted.  Yes, this will
> > mean the build dependencies are massive, and I can't see why this
> > recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
> > either as it doesn't actually have any icons in.  I'd be interested in
> > seeing a buildhistory-diff between the current recipe and one with
> > both inherit gnome and DEPENDS="" removed.
> > 
> when  removing gnome I get the following error at install :
> DEBUG: Executing shell function do_install
> install: cannot create regular file
> `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
> nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such
> file or directory

I have a suspicion we really want a gnomebase inherit in the recipe
instead of gnome and that might solve serveral issues in one.

Cheers,

Richard
Eric BENARD - May 30, 2013, 11:11 a.m.
Le Thu, 30 May 2013 11:49:00 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :

> On Thu, 2013-05-30 at 12:32 +0200, Eric Bénard wrote:
> > Le Thu, 30 May 2013 09:32:38 +0100,
> > "Burton, Ross" <ross.burton@intel.com> a écrit :
> > 
> > > On 30 May 2013 09:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > > Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> > > > brings gconf.
> > > 
> > > gnome.bbclass is an abomination and should be gutted.  Yes, this will
> > > mean the build dependencies are massive, and I can't see why this
> > > recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
> > > either as it doesn't actually have any icons in.  I'd be interested in
> > > seeing a buildhistory-diff between the current recipe and one with
> > > both inherit gnome and DEPENDS=""DEPENDS="" removed.
> > > 
> > when  removing gnome I get the following error at install :
> > DEBUG: Executing shell function do_install
> > install: cannot create regular file
> > `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
> > nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such
> > file or directory
> 
> I have a suspicion we really want a gnomebase inherit in the recipe
> instead of gnome and that might solve serveral issues in one.
> 
inherit gnomebase and remove DEPENDS=""
seems to work fine (the postinst and postrm scripts are removed).
removing DEPENDS="" is not a big issue as it only brings native
packages :
DEPENDS = autoconf-native automake-native gnome-common-native
gnu-config-native libtool-native pkgconfig-native

Eric
Ross Burton - May 30, 2013, 11:51 a.m.
On 30 May 2013 12:11, Eric Bénard <eric@eukrea.com> wrote:
>> I have a suspicion we really want a gnomebase inherit in the recipe
>> instead of gnome and that might solve serveral issues in one.
>>
> inherit gnomebase and remove DEPENDS=""
> seems to work fine (the postinst and postrm scripts are removed).
> removing DEPENDS="" is not a big issue as it only brings native
> packages :
> DEPENDS = autoconf-native automake-native gnome-common-native
> gnu-config-native libtool-native pkgconfig-native

Sounds fine, they actually are the build-dependencies.

Ross
Ross Burton - May 30, 2013, 6:26 p.m.
On 30 May 2013 12:11, Eric Bénard <eric@eukrea.com> wrote:
> inherit gnomebase and remove DEPENDS=""
> seems to work fine (the postinst and postrm scripts are removed).
> removing DEPENDS="" is not a big issue as it only brings native
> packages :
> DEPENDS = autoconf-native automake-native gnome-common-native
> gnu-config-native libtool-native pkgconfig-native

Will you send a patch for this?

Ross
Eric BENARD - May 30, 2013, 7:14 p.m.
Le Thu, 30 May 2013 19:26:03 +0100,
"Burton, Ross" <ross.burton@intel.com> a écrit :

> On 30 May 2013 12:11, Eric Bénard <eric@eukrea.com> wrote:
> > inherit gnomebase and remove DEPENDS=""
> > seems to work fine (the postinst and postrm scripts are removed).
> > removing DEPENDS="" is not a big issue as it only brings native
> > packages :
> > DEPENDS = autoconf-native automake-native gnome-common-native
> > gnu-config-native libtool-native pkgconfig-native
> 
> Will you send a patch for this?
> 
yes it's coming ;-)

Eric

Patch

diff --git a/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb b/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
index 7c911e0..8d48dec 100644
--- a/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
+++ b/meta/recipes-gnome/hicolor-icon-theme/hicolor-icon-theme_0.12.bb
@@ -8,8 +8,6 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=f08a446809913fc9b3c718f0eaea0426"
 SECTION = "unknown"
 inherit gnome allarch
 
-DEPENDS = ""
-
 PR = "r1"
 
 SRC_URI = "http://icon-theme.freedesktop.org/releases/${BPN}-${PV}.tar.gz \