Patchwork [v2,0/4] Fixes for makedevs

login
register
mail settings
Submitter Peter Kjellerstedt
Date May 30, 2013, 7:19 a.m.
Message ID <cover.1369898198.git.pkj@axis.com>
Download mbox
Permalink /patch/50787/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib pkj/makedevs

Comments

Peter Kjellerstedt - May 30, 2013, 7:19 a.m.
When I wanted to create devices from a package I stumbled upon a couple
of problems with the makedevs program. Most notable was that it failed
to set the correct uid/gid for devices created as part of a block (i.e.,
with a count > 0).

And now with Signed-off-by lines, as requested.

The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:

  package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/makedevs
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs

Peter Kjellerstedt (4):
  makedevs: Create blocks of devices with the correct uid/gid
  makedevs: Correct the device number calculation for blocks of devices
  makedevs: Make the mode number readable in debug messages
  makedevs: Avoid unnecessary timestamp calculation

 .../recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
Bernhard Reutner-Fischer - May 30, 2013, 9:02 a.m.
On 30 May 2013 09:19:54 Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> When I wanted to create devices from a package I stumbled upon a couple
> of problems with the makedevs program. Most notable was that it failed
> to set the correct uid/gid for devices created as part of a block (i.e.,
> with a count > 0).
>
> And now with Signed-off-by lines, as requested.

Are these appropriate for or fixed already in upstream, I.e. Busybox?

 Thanks,
>
> The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:
>
>   package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)
>
> are available in the git repository at:
>
>   git://git.yoctoproject.org/poky-contrib pkj/makedevs
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs
>
> Peter Kjellerstedt (4):
>   makedevs: Create blocks of devices with the correct uid/gid
>   makedevs: Correct the device number calculation for blocks of devices
>   makedevs: Make the mode number readable in debug messages
>   makedevs: Avoid unnecessary timestamp calculation
>
>  .../recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
> --
> 1.8.2.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


Sent with AquaMail for Android
http://www.aqua-mail.com
Peter Kjellerstedt - May 30, 2013, 12:14 p.m.
> -----Original Message-----
> From: Bernhard Reutner-Fischer [mailto:rep.dot.nop@gmail.com]
> Sent: den 30 maj 2013 11:02
> To: Peter Kjellerstedt; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH v2 0/4] Fixes for makedevs
> 
> On 30 May 2013 09:19:54 Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> wrote:
> > When I wanted to create devices from a package I stumbled upon a
> couple
> > of problems with the makedevs program. Most notable was that it
> failed
> > to set the correct uid/gid for devices created as part of a block
> (i.e.,
> > with a count > 0).
> >
> > And now with Signed-off-by lines, as requested.
> 
> Are these appropriate for or fixed already in upstream, I.e. Busybox?

I took a look at makdevs.c in BusyBox, and as far as I can tell 
that version already has the relevant fixes. 

It also made me notice another mistake in the current OE version 
(it loops from start to count-1 rather than start to start+count-1)...
I will send an updated version of the patch series that fixes this.

//Peter