Patchwork [meta-fsl-arm] qt5: add mx5 and mx6 support

login
register
mail settings
Submitter Eric BENARD
Date May 29, 2013, 6:04 p.m.
Message ID <1369850680-18324-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/50761/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Eric BENARD - May 29, 2013, 6:04 p.m.
- this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
- tested on i.MX51, i.MX53 and i.MX6Q

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 conf/layer.conf                                |    2 +
 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105 ++++++++++++++++++++++++
 recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp
 create mode 100644 recipes-qt/qt5/qtbase_5.0.2.bbappend
Otavio Salvador - May 31, 2013, 1:18 p.m.
On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com> wrote:

> - this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
> - tested on i.MX51, i.MX53 and i.MX6Q
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
>

...


>  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> ++++++++++++++++++++++++
>  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
>

...

Thinking more about it, I think we should put these inside a meta-qt5
directory so we know what will be 'included'. Otherwse we may need to pick
every file depending on each layer and it might be difficult to understand
what is in use and what is not.
Eric BENARD - May 31, 2013, 2:15 p.m.
Le Fri, 31 May 2013 10:18:44 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com> wrote:
> 
> > - this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
> > - tested on i.MX51, i.MX53 and i.MX6Q
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> >
> 
> ...
> 
> 
> >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > ++++++++++++++++++++++++
> >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
> >
> 
> ...
> 
> Thinking more about it, I think we should put these inside a meta-qt5
> directory so we know what will be 'included'. Otherwse we may need to pick
> every file depending on each layer and it might be difficult to understand
> what is in use and what is not.
> 
please apply as is and create a patch on top of it to achieve the
organization you prefer.

Eric
Otavio Salvador - May 31, 2013, 3 p.m.
On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com> wrote:

> Le Fri, 31 May 2013 10:18:44 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
> > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com> wrote:
> >
> > > - this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
> > > - tested on i.MX51, i.MX53 and i.MX6Q
> > >
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > >
> >
> > ...
> >
> >
> > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > ++++++++++++++++++++++++
> > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
> > >
> >
> > ...
> >
> > Thinking more about it, I think we should put these inside a meta-qt5
> > directory so we know what will be 'included'. Otherwse we may need to
> pick
> > every file depending on each layer and it might be difficult to
> understand
> > what is in use and what is not.
> >
> please apply as is and create a patch on top of it to achieve the
> organization you prefer.
>

No reason to apply one patch which we know that needs rework.

Do you agree with my argument?
Eric BENARD - May 31, 2013, 3:02 p.m.
Le Fri, 31 May 2013 12:00:08 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com> wrote:
> 
> > Le Fri, 31 May 2013 10:18:44 -0300,
> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> >
> > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com> wrote:
> > >
> > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and i.MX6
> > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > >
> > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > >
> > >
> > > ...
> > >
> > >
> > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > ++++++++++++++++++++++++
> > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68 +++++++++++++++
> > > >
> > >
> > > ...
> > >
> > > Thinking more about it, I think we should put these inside a meta-qt5
> > > directory so we know what will be 'included'. Otherwse we may need to
> > pick
> > > every file depending on each layer and it might be difficult to
> > understand
> > > what is in use and what is not.
> > >
> > please apply as is and create a patch on top of it to achieve the
> > organization you prefer.
> >
> 
> No reason to apply one patch which we know that needs rework.
> 
> Do you agree with my argument?
> 
no ;-)

Eric
Otavio Salvador - May 31, 2013, 3:04 p.m.
On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <eric@eukrea.com> wrote:

> Le Fri, 31 May 2013 12:00:08 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
> > On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com> wrote:
> >
> > > Le Fri, 31 May 2013 10:18:44 -0300,
> > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > >
> > > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com>
> wrote:
> > > >
> > > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and
> i.MX6
> > > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > > >
> > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > >
> > > >
> > > > ...
> > > >
> > > >
> > > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > > ++++++++++++++++++++++++
> > > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
> +++++++++++++++
> > > > >
> > > >
> > > > ...
> > > >
> > > > Thinking more about it, I think we should put these inside a meta-qt5
> > > > directory so we know what will be 'included'. Otherwse we may need to
> > > pick
> > > > every file depending on each layer and it might be difficult to
> > > understand
> > > > what is in use and what is not.
> > > >
> > > please apply as is and create a patch on top of it to achieve the
> > > organization you prefer.
> > >
> >
> > No reason to apply one patch which we know that needs rework.
> >
> > Do you agree with my argument?
> >
> no ;-)
>

Well; it would be easier if you could explain why. Do you mind to elaborate
it a little more?
Eric BENARD - May 31, 2013, 3:35 p.m.
Le Fri, 31 May 2013 12:04:11 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <eric@eukrea.com> wrote:
> 
> > Le Fri, 31 May 2013 12:00:08 -0300,
> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> >
> > > On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com> wrote:
> > >
> > > > Le Fri, 31 May 2013 10:18:44 -0300,
> > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > >
> > > > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com>
> > wrote:
> > > > >
> > > > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and
> > i.MX6
> > > > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > > > >
> > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > >
> > > > >
> > > > > ...
> > > > >
> > > > >
> > > > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > > > ++++++++++++++++++++++++
> > > > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
> > +++++++++++++++
> > > > > >
> > > > >
> > > > > ...
> > > > >
> > > > > Thinking more about it, I think we should put these inside a meta-qt5
> > > > > directory so we know what will be 'included'. Otherwse we may need to
> > > > pick
> > > > > every file depending on each layer and it might be difficult to
> > > > understand
> > > > > what is in use and what is not.
> > > > >
> > > > please apply as is and create a patch on top of it to achieve the
> > > > organization you prefer.
> > > >
> > >
> > > No reason to apply one patch which we know that needs rework.
> > >
> > > Do you agree with my argument?
> > >
> > no ;-)
> >
> 
> Well; it would be easier if you could explain why. Do you mind to elaborate
> it a little more?
> 
if the argument is "No reason to apply one patch which we know that
needs rework" :
Changing the organization of the bbappend is not just a mater of editing
the patch in a few minutes, it also means testing with and without
meta-qt5 and that's very long (and I already did that for v1 when we
discussed that initially).
2 days ago you told me that the RFC was fine, now you tell me that
needs rework and as I don't have immediate time to rework it so if you
want to change the organization or use Chris' way to add layers (which
is very elegant) either create a patch to rework this one or rework the
patch before applying or drop it for the moment and I may work again
on that later (and in that case, please reply with the organization
you want so that the work is done only one time).

if the argument is "it might be difficult to understand what is in use
and what is not" :
as soon as you have automatic addition of sublayers you fall in a case
where it's not easy to understand what is in use or not whatever is
your directory organization.

Eric
Otavio Salvador - May 31, 2013, 4:23 p.m.
On Fri, May 31, 2013 at 12:35 PM, Eric Bénard <eric@eukrea.com> wrote:

> Le Fri, 31 May 2013 12:04:11 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
> > On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <eric@eukrea.com> wrote:
> >
> > > Le Fri, 31 May 2013 12:00:08 -0300,
> > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > >
> > > > On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com>
> wrote:
> > > >
> > > > > Le Fri, 31 May 2013 10:18:44 -0300,
> > > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > > >
> > > > > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com>
> > > wrote:
> > > > > >
> > > > > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and
> > > i.MX6
> > > > > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > > > > >
> > > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > > >
> > > > > >
> > > > > > ...
> > > > > >
> > > > > >
> > > > > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > > > > ++++++++++++++++++++++++
> > > > > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
> > > +++++++++++++++
> > > > > > >
> > > > > >
> > > > > > ...
> > > > > >
> > > > > > Thinking more about it, I think we should put these inside a
> meta-qt5
> > > > > > directory so we know what will be 'included'. Otherwse we may
> need to
> > > > > pick
> > > > > > every file depending on each layer and it might be difficult to
> > > > > understand
> > > > > > what is in use and what is not.
> > > > > >
> > > > > please apply as is and create a patch on top of it to achieve the
> > > > > organization you prefer.
> > > > >
> > > >
> > > > No reason to apply one patch which we know that needs rework.
> > > >
> > > > Do you agree with my argument?
> > > >
> > > no ;-)
> > >
> >
> > Well; it would be easier if you could explain why. Do you mind to
> elaborate
> > it a little more?
> >
> if the argument is "No reason to apply one patch which we know that
> needs rework" :
> Changing the organization of the bbappend is not just a mater of editing
> the patch in a few minutes, it also means testing with and without
> meta-qt5 and that's very long (and I already did that for v1 when we
> discussed that initially).
> 2 days ago you told me that the RFC was fine, now you tell me that
> needs rework and as I don't have immediate time to rework it so if you
> want to change the organization or use Chris' way to add layers (which
> is very elegant) either create a patch to rework this one or rework the
> patch before applying or drop it for the moment and I may work again
> on that later (and in that case, please reply with the organization
> you want so that the work is done only one time).
>

I asked you to send it as proper patch for review. I didn't noticed you
have put the bbappend in same level as the other so when I noticed it I
commented.


> if the argument is "it might be difficult to understand what is in use
> and what is not" :
> as soon as you have automatic addition of sublayers you fall in a case
> where it's not easy to understand what is in use or not whatever is
> your directory organization.
>

I'd put it as:

recipes-...
meta-qt5/recipes-qt/qt5/...

Or as Chris suggested:

recipes-...
qt5-layer/recipes-qt/qt5

Both ways looks good for me.

I will mark them as 'Changes requested' in patchwork.

Regards,
Eric BENARD - May 31, 2013, 8:06 p.m.
Le Fri, 31 May 2013 13:23:29 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Fri, May 31, 2013 at 12:35 PM, Eric Bénard <eric@eukrea.com> wrote:
> 
> > Le Fri, 31 May 2013 12:04:11 -0300,
> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> >
> > > On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <eric@eukrea.com> wrote:
> > >
> > > > Le Fri, 31 May 2013 12:00:08 -0300,
> > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > >
> > > > > On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com>
> > wrote:
> > > > >
> > > > > > Le Fri, 31 May 2013 10:18:44 -0300,
> > > > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > > > >
> > > > > > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <eric@eukrea.com>
> > > > wrote:
> > > > > > >
> > > > > > > > - this allow to build qt5 with OpenGL ES support for i.MX5 and
> > > > i.MX6
> > > > > > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > > > > > >
> > > > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > > > >
> > > > > > >
> > > > > > > ...
> > > > > > >
> > > > > > >
> > > > > > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > > > > > ++++++++++++++++++++++++
> > > > > > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
> > > > +++++++++++++++
> > > > > > > >
> > > > > > >
> > > > > > > ...
> > > > > > >
> > > > > > > Thinking more about it, I think we should put these inside a
> > meta-qt5
> > > > > > > directory so we know what will be 'included'. Otherwse we may
> > need to
> > > > > > pick
> > > > > > > every file depending on each layer and it might be difficult to
> > > > > > understand
> > > > > > > what is in use and what is not.
> > > > > > >
> > > > > > please apply as is and create a patch on top of it to achieve the
> > > > > > organization you prefer.
> > > > > >
> > > > >
> > > > > No reason to apply one patch which we know that needs rework.
> > > > >
> > > > > Do you agree with my argument?
> > > > >
> > > > no ;-)
> > > >
> > >
> > > Well; it would be easier if you could explain why. Do you mind to
> > elaborate
> > > it a little more?
> > >
> > if the argument is "No reason to apply one patch which we know that
> > needs rework" :
> > Changing the organization of the bbappend is not just a mater of editing
> > the patch in a few minutes, it also means testing with and without
> > meta-qt5 and that's very long (and I already did that for v1 when we
> > discussed that initially).
> > 2 days ago you told me that the RFC was fine, now you tell me that
> > needs rework and as I don't have immediate time to rework it so if you
> > want to change the organization or use Chris' way to add layers (which
> > is very elegant) either create a patch to rework this one or rework the
> > patch before applying or drop it for the moment and I may work again
> > on that later (and in that case, please reply with the organization
> > you want so that the work is done only one time).
> >
> 
> I asked you to send it as proper patch for review. I didn't noticed you
> have put the bbappend in same level as the other so when I noticed it I
> commented.

Otavio sometimes you push the pedantry very far : the difference between
the initial patch and what you call the "proper patch" is that the
"proper patch" doesn't have 3 letters (RFC) in the subject and now I
understand that having "RFC" in the subject means you didn't review the
patch.

> > if the argument is "it might be difficult to understand what is in use
> > and what is not" :
> > as soon as you have automatic addition of sublayers you fall in a case
> > where it's not easy to understand what is in use or not whatever is
> > your directory organization.
> >
> 
> I'd put it as:
> 
> recipes-...
> meta-qt5/recipes-qt/qt5/...
> 
> Or as Chris suggested:
> 
> recipes-...
> qt5-layer/recipes-qt/qt5
> 
> Both ways looks good for me.
> 
please choose ONE way so that the next patch iteration get THE right
one for you.

> I will mark them as 'Changes requested' in patchwork.
> 
perfect.

Eric
Otavio Salvador - May 31, 2013, 8:30 p.m.
On Fri, May 31, 2013 at 5:06 PM, Eric Bénard <eric@eukrea.com> wrote:

> Le Fri, 31 May 2013 13:23:29 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
> > On Fri, May 31, 2013 at 12:35 PM, Eric Bénard <eric@eukrea.com> wrote:
> >
> > > Le Fri, 31 May 2013 12:04:11 -0300,
> > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > >
> > > > On Fri, May 31, 2013 at 12:02 PM, Eric Bénard <eric@eukrea.com>
> wrote:
> > > >
> > > > > Le Fri, 31 May 2013 12:00:08 -0300,
> > > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > > >
> > > > > > On Fri, May 31, 2013 at 11:15 AM, Eric Bénard <eric@eukrea.com>
> > > wrote:
> > > > > >
> > > > > > > Le Fri, 31 May 2013 10:18:44 -0300,
> > > > > > > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > > > > > >
> > > > > > > > On Wed, May 29, 2013 at 3:04 PM, Eric Bénard <
> eric@eukrea.com>
> > > > > wrote:
> > > > > > > >
> > > > > > > > > - this allow to build qt5 with OpenGL ES support for i.MX5
> and
> > > > > i.MX6
> > > > > > > > > - tested on i.MX51, i.MX53 and i.MX6Q
> > > > > > > > >
> > > > > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > > > > >
> > > > > > > >
> > > > > > > > ...
> > > > > > > >
> > > > > > > >
> > > > > > > > >  recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp |  105
> > > > > > > > > ++++++++++++++++++++++++
> > > > > > > > >  recipes-qt/qt5/qtbase_5.0.2.bbappend           |   68
> > > > > +++++++++++++++
> > > > > > > > >
> > > > > > > >
> > > > > > > > ...
> > > > > > > >
> > > > > > > > Thinking more about it, I think we should put these inside a
> > > meta-qt5
> > > > > > > > directory so we know what will be 'included'. Otherwse we may
> > > need to
> > > > > > > pick
> > > > > > > > every file depending on each layer and it might be difficult
> to
> > > > > > > understand
> > > > > > > > what is in use and what is not.
> > > > > > > >
> > > > > > > please apply as is and create a patch on top of it to achieve
> the
> > > > > > > organization you prefer.
> > > > > > >
> > > > > >
> > > > > > No reason to apply one patch which we know that needs rework.
> > > > > >
> > > > > > Do you agree with my argument?
> > > > > >
> > > > > no ;-)
> > > > >
> > > >
> > > > Well; it would be easier if you could explain why. Do you mind to
> > > elaborate
> > > > it a little more?
> > > >
> > > if the argument is "No reason to apply one patch which we know that
> > > needs rework" :
> > > Changing the organization of the bbappend is not just a mater of
> editing
> > > the patch in a few minutes, it also means testing with and without
> > > meta-qt5 and that's very long (and I already did that for v1 when we
> > > discussed that initially).
> > > 2 days ago you told me that the RFC was fine, now you tell me that
> > > needs rework and as I don't have immediate time to rework it so if you
> > > want to change the organization or use Chris' way to add layers (which
> > > is very elegant) either create a patch to rework this one or rework the
> > > patch before applying or drop it for the moment and I may work again
> > > on that later (and in that case, please reply with the organization
> > > you want so that the work is done only one time).
> > >
> >
> > I asked you to send it as proper patch for review. I didn't noticed you
> > have put the bbappend in same level as the other so when I noticed it I
> > commented.
>
> Otavio sometimes you push the pedantry very far : the difference between
> the initial patch and what you call the "proper patch" is that the
> "proper patch" doesn't have 3 letters (RFC) in the subject and now I
> understand that having "RFC" in the subject means you didn't review the
> patch.
>

Usually RFC patches are to discuss the concept not to receive a complete
review. We did discuss it and it even allowed Chris to comment on it with a
better way of solving the problem - which is what it is the real goal of it
I think.

I didn't try the patch (I was under high volume of tests here for GPU
patches) and once I managed to get it done I started to check for backlog
in the mailing list (today) so I did look at it more carefully and found a
issue which I didn't see at first look - which I also think is normal - as
I can also make mistakes - so I don't think I was pedant but instead a
careful maintainer.

> > if the argument is "it might be difficult to understand what is in use
> > > and what is not" :
> > > as soon as you have automatic addition of sublayers you fall in a case
> > > where it's not easy to understand what is in use or not whatever is
> > > your directory organization.
> > >
> >
> > I'd put it as:
> >
> > recipes-...
> > meta-qt5/recipes-qt/qt5/...
> >
> > Or as Chris suggested:
> >
> > recipes-...
> > qt5-layer/recipes-qt/qt5
> >
> > Both ways looks good for me.
> >
> please choose ONE way so that the next patch iteration get THE right
> one for you.


Let's go with Chris proposal than; it avoids future rework in bblayers.conf
I think.

So the way I see it, it could be done as:

* one patch adding the bblayers.conf change
* one for Qt5 additions

Regards,

Patch

diff --git a/conf/layer.conf b/conf/layer.conf
index c4b9cd1..2bdff7c 100644
--- a/conf/layer.conf
+++ b/conf/layer.conf
@@ -4,6 +4,8 @@  BBPATH .= ":${LAYERDIR}"
 # We have a packages directory, add to BBFILES
 BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
             ${LAYERDIR}/recipes-*/*/*.bbappend"
+BBMASK_append = "${@base_contains('BBFILE_COLLECTIONS', 'qt5-layer', '' ,\
+           ' meta-fsl-arm/recipes-qt/qt5/*.bb meta-fsl-arm/recipes-qt/qt5/*.bbappend', d)}"
 
 BBFILE_COLLECTIONS += "fsl-arm"
 BBFILE_PATTERN_fsl-arm := "^${LAYERDIR}/"
diff --git a/recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp b/recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp
new file mode 100644
index 0000000..43e6d8d
--- /dev/null
+++ b/recipes-qt/qt5/qtbase/mx5/qeglfshooks_imx5.cpp
@@ -0,0 +1,105 @@ 
+/****************************************************************************
+**
+** hacked by Eric Bénard - Eukréa Electromatique
+** inspired from https://community.freescale.com/docs/DOC-94123
+** and from fbset.c http://users.telenet.be/geertu/Linux/fbdev/
+**
+** based on qeglfshooks_imx6.cpp which is :
+** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
+** Contact: http://www.qt-project.org/legal
+**
+** This file is part of the qmake spec of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia.  For licensing terms and
+** conditions see http://qt.digia.com/licensing.  For further information
+** use the contact form at http://qt.digia.com/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPL included in the
+** packaging of this file.  Please review the following information to
+** ensure the GNU Lesser General Public License version 2.1 requirements
+** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights.  These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3.0 as published by the Free Software
+** Foundation and appearing in the file LICENSE.GPL included in the
+** packaging of this file.  Please review the following information to
+** ensure the GNU General Public License version 3.0 requirements will be
+** met: http://www.gnu.org/copyleft/gpl.html.
+**
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+#include <fcntl.h>    /* For O_RDWR */
+#include <unistd.h>   /* For open(), creat() */
+#include "qeglfshooks.h"
+#include <EGL/egl.h>
+#include <linux/fb.h>
+#include <sys/ioctl.h>
+
+QT_BEGIN_NAMESPACE
+
+class QEglFSImx5Hooks : public QEglFSHooks
+{
+public:
+    QEglFSImx5Hooks();
+    virtual QSize screenSize() const;
+    virtual EGLNativeWindowType createNativeWindow(const QSize &size, const QSurfaceFormat &format);
+    virtual void destroyNativeWindow(EGLNativeWindowType window);
+
+private:
+    QSize mScreenSize;
+    EGLNativeDisplayType mNativeDisplay;
+};
+
+
+QEglFSImx5Hooks::QEglFSImx5Hooks()
+{
+    int width, height;
+    /* code taken from fbset.c */
+    int fh;
+    struct fb_var_screeninfo var;
+    fh = open("/dev/fb0", O_RDONLY);
+    ioctl(fh, FBIOGET_VSCREENINFO, &var);
+    mScreenSize.setHeight(var.yres);
+    mScreenSize.setWidth(var.xres);
+    close(fh);
+    mNativeDisplay = EGL_DEFAULT_DISPLAY;
+}
+
+QSize QEglFSImx5Hooks::screenSize() const
+{
+    return mScreenSize;
+}
+
+EGLNativeWindowType QEglFSImx5Hooks::createNativeWindow(const QSize &size, const QSurfaceFormat &format)
+{
+    Q_UNUSED(format);
+
+    EGLNativeWindowType eglWindow =  open("/dev/fb0", O_RDWR);
+    return eglWindow;
+}
+
+
+void QEglFSImx5Hooks::destroyNativeWindow(EGLNativeWindowType window)
+{
+    close(window);
+}
+
+QEglFSImx5Hooks eglFSImx5Hooks;
+QEglFSHooks *platformHooks = &eglFSImx5Hooks;
+
+QT_END_NAMESPACE
diff --git a/recipes-qt/qt5/qtbase_5.0.2.bbappend b/recipes-qt/qt5/qtbase_5.0.2.bbappend
new file mode 100644
index 0000000..00a8819
--- /dev/null
+++ b/recipes-qt/qt5/qtbase_5.0.2.bbappend
@@ -0,0 +1,68 @@ 
+# Copyright (C) 2013 Eric Bénard - Eukréa Electromatique
+
+GL_DEPENDS_mx6 = "virtual/libgles2 virtual/egl"
+QT_GLFLAGS_mx6 = "-opengl es2 -eglfs"
+QT_EXAMPLES_mx6 = "-make examples"
+QT_DEMOS_mx6 = "-make demos"
+
+GL_DEPENDS_mx5 = "virtual/libgles2 virtual/egl"
+QT_GLFLAGS_mx5 = "-opengl es2 -eglfs"
+QT_EXAMPLES_mx5 = "-make examples"
+QT_DEMOS_mx5 = "-make demos"
+
+TSLIB_DEPENDS_mx6 = "tslib"
+QT_TSLIB_mx6 = "-tslib"
+
+TSLIB_DEPENDS_mx5 = "tslib"
+QT_TSLIB_mx5 = "-tslib"
+
+PACKAGE_ARCH_mx6 = "${MACHINE_ARCH}"
+PACKAGE_ARCH_mx5 = "${MACHINE_ARCH}"
+
+FILESEXTRAPATHS_prepend_mx5 := "${THISDIR}/${PN}:"
+SRC_URI_append_mx5 += " \
+    file://qeglfshooks_imx5.cpp \
+    "
+
+do_configure_prepend_mx6() {
+# adapt qmake.conf to our needs
+sed -i 's!load(qt_config)!!' ${S}/mkspecs/linux-oe-g++/qmake.conf
+cat >> ${S}/mkspecs/linux-oe-g++/qmake.conf <<EOF
+EGLFS_PLATFORM_HOOKS_SOURCES = \$\$PWD/qeglfshooks_imx6.cpp
+IMX6_CFLAGS             = -DLINUX=1 -DEGL_API_FB=1
+QMAKE_LIBS_EGL         += -lEGL
+QMAKE_LIBS_OPENGL_ES2  += -lGLESv2 -lEGL -lGAL
+QMAKE_LIBS_OPENVG      += -lOpenVG -lEGL -lGAL
+QMAKE_CFLAGS_RELEASE   += \$\$IMX6_CFLAGS
+QMAKE_CXXFLAGS_RELEASE += \$\$IMX6_CFLAGS
+QMAKE_CFLAGS_DEBUG   += \$\$IMX6_CFLAGS
+QMAKE_CXXFLAGS_DEBUG += \$\$IMX6_CFLAGS
+QMAKE_CFLAGS_EGL += \$\$IMX6_CFLAGS
+load(qt_config)
+
+EOF
+
+# copy the hook in the mkspecs directory OE is using
+cp ${S}/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp ${S}/mkspecs/linux-oe-g++/
+}
+
+do_configure_prepend_mx5() {
+# adapt qmake.conf to our needs
+sed -i 's!load(qt_config)!!' ${S}/mkspecs/linux-oe-g++/qmake.conf
+cat >> ${S}/mkspecs/linux-oe-g++/qmake.conf <<EOF
+EGLFS_PLATFORM_HOOKS_SOURCES = \$\$PWD/qeglfshooks_imx5.cpp
+IMX5_CFLAGS             = -D_LINUX
+QMAKE_LIBS_EGL         += -lEGL
+QMAKE_LIBS_OPENGL_ES2  += -lGLESv2 -lEGL
+QMAKE_LIBS_OPENVG      += -lOpenVG -lEGL
+QMAKE_CFLAGS_RELEASE   += \$\$IMX5_CFLAGS
+QMAKE_CXXFLAGS_RELEASE += \$\$IMX5_CFLAGS
+QMAKE_CFLAGS_DEBUG   += \$\$IMX5_CFLAGS
+QMAKE_CXXFLAGS_DEBUG += \$\$IMX5_CFLAGS
+QMAKE_CFLAGS_EGL += \$\$IMX5_CFLAGS
+load(qt_config)
+
+EOF
+
+cp ${WORKDIR}/qeglfshooks_imx5.cpp ${S}/mkspecs/linux-oe-g++/
+}