Patchwork python-smartpm: add gettext-native to DEPENDS

login
register
mail settings
Submitter Paul Eggleton
Date May 29, 2013, 3:51 p.m.
Message ID <1369842682-11880-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/50747/
State Accepted
Commit 4c6939f6579563d1cdf7cd58820f432d5869d90a
Headers show

Comments

Paul Eggleton - May 29, 2013, 3:51 p.m.
Fixes the following failure at do_install if gettext-native has not
already been built and gettext tools are not installed on the host:

| compiling locale/it/LC_MESSAGES/smart.po -> locale/it/LC_MESSAGES/smart.mo
| sh: msgfmt: command not found
...
| creating $D/usr/share/share/locale/it/LC_MESSAGES
| error: can't copy 'locale/it/LC_MESSAGES/smart.mo': doesn't exist or not a regular file

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Khem Raj - May 29, 2013, 5:41 p.m.
On Wednesday, May 29, 2013, Paul Eggleton <paul.eggleton@linux.intel.com>
wrote:
> Fixes the following failure at do_install if gettext-native has not
> already been built and gettext tools are not installed on the host:
>
> | compiling locale/it/LC_MESSAGES/smart.po ->
locale/it/LC_MESSAGES/smart.mo
> | sh: msgfmt: command not found
> ...
> | creating $D/usr/share/share/locale/it/LC_MESSAGES
> | error: can't copy 'locale/it/LC_MESSAGES/smart.mo': doesn't exist or
not a regular file
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/recipes-devtools/python/python-smartpm_1.4.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python-smartpm_1.4.1.bbb/meta/recipes-devtools/python/
python-smartpm_1.4.1.bb
> index cfa2dba..0cf3847 100644
> --- a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
> +++ b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
> @@ -8,7 +8,7 @@ SECTION = "devel/python"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=393a5ca445f6965873eca0259a17f833"
>
> -DEPENDS = "python rpm"
> +DEPENDS = "python rpm gettext-native"

Why not inherit gettext ?


>  PR = "r9"
>  SRCNAME = "smart"
>
> --
> 1.8.1.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Paul Eggleton - May 29, 2013, 5:51 p.m.
On Wednesday 29 May 2013 10:41:25 Khem Raj wrote:
> On Wednesday, May 29, 2013, Paul Eggleton <paul.eggleton@linux.intel.com>
> wrote:
> > -DEPENDS = "python rpm"
> > +DEPENDS = "python rpm gettext-native"
> 
> Why not inherit gettext ?

Because that doesn't work for python-smartpm-native - that will add gettext-
minimal-native to DEPENDS which does not provide msgfmt.

Cheers,
Paul
Khem Raj - May 29, 2013, 6:22 p.m.
On May 29, 2013, at 10:51 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> On Wednesday 29 May 2013 10:41:25 Khem Raj wrote:
>> On Wednesday, May 29, 2013, Paul Eggleton <paul.eggleton@linux.intel.com>
>> wrote:
>>> -DEPENDS = "python rpm"
>>> +DEPENDS = "python rpm gettext-native"
>> 
>> Why not inherit gettext ?
> 
> Because that doesn't work for python-smartpm-native - that will add gettext-
> minimal-native to DEPENDS which does not provide msgfmt.


Add that info to commit log please 

> 
> Cheers,
> Paul
> 
> -- 
> 
> Paul Eggleton
> Intel Open Source Technology Centre

Patch

diff --git a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
index cfa2dba..0cf3847 100644
--- a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
+++ b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
@@ -8,7 +8,7 @@  SECTION = "devel/python"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=393a5ca445f6965873eca0259a17f833"
 
-DEPENDS = "python rpm"
+DEPENDS = "python rpm gettext-native"
 PR = "r9"
 SRCNAME = "smart"