Patchwork [0/4] Fixes for makedevs

login
register
mail settings
Submitter Peter Kjellerstedt
Date May 29, 2013, 2:55 p.m.
Message ID <cover.1369839249.git.pkj@axis.com>
Download mbox
Permalink /patch/50697/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib pkj/makedevs

Comments

Peter Kjellerstedt - May 29, 2013, 2:55 p.m.
When I wanted to create devices from a package I stumbled upon a couple
of problems with the makedevs program. Most notable was that it failed
to set the correct uid/gid for devices created as part of a block (i.e.,
with a count > 0).

The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:

  package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/makedevs
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs

Peter Kjellerstedt (4):
  makedevs: Create blocks of devices with the correct uid/gid
  makedevs: Correct the device number calculation for blocks of devices
  makedevs: Make the mode number readable in debug messages
  makedevs: Avoid unnecessary timestamp calculation

 .../recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
Richard Purdie - May 29, 2013, 9:40 p.m.
On Wed, 2013-05-29 at 16:55 +0200, Peter Kjellerstedt wrote:
> When I wanted to create devices from a package I stumbled upon a couple
> of problems with the makedevs program. Most notable was that it failed
> to set the correct uid/gid for devices created as part of a block (i.e.,
> with a count > 0).
> 
> The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:
> 
>   package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib pkj/makedevs
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs
> 
> Peter Kjellerstedt (4):
>   makedevs: Create blocks of devices with the correct uid/gid
>   makedevs: Correct the device number calculation for blocks of devices
>   makedevs: Make the mode number readable in debug messages
>   makedevs: Avoid unnecessary timestamp calculation

These look good to me but could you push a branch with signed-off-by
lines in the commits please?

Cheers,

Richard
Peter Kjellerstedt - May 30, 2013, 7:29 a.m.
> -----Original Message-----
> From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
> Sent: den 29 maj 2013 23:40
> To: Peter Kjellerstedt
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 0/4] Fixes for makedevs
> 
> On Wed, 2013-05-29 at 16:55 +0200, Peter Kjellerstedt wrote:
> > When I wanted to create devices from a package I stumbled upon a couple
> > of problems with the makedevs program. Most notable was that it failed
> > to set the correct uid/gid for devices created as part of a block (i.e.,
> > with a count > 0).
> >
> > The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:
> >
> >   package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)
> >
> > are available in the git repository at:
> >
> >   git://git.yoctoproject.org/poky-contrib pkj/makedevs
> >   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs
> >
> > Peter Kjellerstedt (4):
> >   makedevs: Create blocks of devices with the correct uid/gid
> >   makedevs: Correct the device number calculation for blocks of devices
> >   makedevs: Make the mode number readable in debug messages
> >   makedevs: Avoid unnecessary timestamp calculation
> 
> These look good to me but could you push a branch with signed-off-by
> lines in the commits please?
> 
> Cheers,
> 
> Richard

I have sent an updated pull request that add Signed-off-by lines now.

//Peter