Patchwork [0/2] switch to using busybox instead of tinylogin

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date May 28, 2013, 5:39 a.m.
Message ID <cover.1369719531.git.Qi.Chen@windriver.com>
Download mbox
Permalink /patch/50603/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox

Comments

Qi.Chen@windriver.com - May 28, 2013, 5:39 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

The following changes since commit 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:

  ref-manual: Added xmlto and dblatex packages for docs (2013-05-22 17:23:41 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox

Chen Qi (2):
  packagegroup-core-boot: use busybox as the default login manager
  busybox: enable login/password commands by default

 meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26 ++++++++++----------
 .../packagegroups/packagegroup-core-boot.bb        |    2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)
Jonathan Liu - May 28, 2013, 6:25 a.m.
On 28 May 2013 15:39, <Qi.Chen@windriver.com> wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
>
> The following changes since commit
> 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>   ref-manual: Added xmlto and dblatex packages for docs (2013-05-22
> 17:23:41 +0100)
>
> are available in the git repository at:
>
>   git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
>
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
> Chen Qi (2):
>   packagegroup-core-boot: use busybox as the default login manager
>   busybox: enable login/password commands by default
>
>  meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26
> ++++++++++----------
>  .../packagegroups/packagegroup-core-boot.bb        |    2 +-
>  2 files changed, 14 insertions(+), 14 deletions(-)
>

After switching from tinylogin to busybox, the following commands that used
to be provided by tinylogin are provided by other packages instead of
busybox:
-/bin/login [shadow]
-/sbin/getty [util-linux-agetty]
-/usr/bin/passwd  [shadow]
-/usr/bin/su [shadow]

Perhaps util-linux-agetty and shadow packages have higher alternatives
priority?

Regards,
Jonathan
Qi.Chen@windriver.com - May 28, 2013, 6:32 a.m.
On 05/28/2013 02:25 PM, Jonathan Liu wrote:
> On 28 May 2013 15:39, <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     From: Chen Qi <Qi.Chen@windriver.com <mailto:Qi.Chen@windriver.com>>
>
>     The following changes since commit
>     21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>       ref-manual: Added xmlto and dblatex packages for docs
>     (2013-05-22 17:23:41 +0100)
>
>     are available in the git repository at:
>
>       git://git.pokylinux.org/poky-contrib
>     <http://git.pokylinux.org/poky-contrib> ChenQi/tinylogin-busybox
>     http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
>     Chen Qi (2):
>       packagegroup-core-boot: use busybox as the default login manager
>       busybox: enable login/password commands by default
>
>      meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26
>     ++++++++++----------
>      .../packagegroups/packagegroup-core-boot.bb
>     <http://packagegroup-core-boot.bb>        |    2 +-
>      2 files changed, 14 insertions(+), 14 deletions(-)
>
>
> After switching from tinylogin to busybox, the following commands that 
> used to be provided by tinylogin are provided by other packages 
> instead of busybox:
> -/bin/login [shadow]
> -/sbin/getty [util-linux-agetty]
> -/usr/bin/passwd  [shadow]
> -/usr/bin/su [shadow]
>
> Perhaps util-linux-agetty and shadow packages have higher alternatives 
> priority?
>
The answer seems to be 'yes'.

meta/recipes-core/busybox/busybox.inc:ALTERNATIVE_PRIORITY = "50"
meta/recipes-extended/shadow/shadow_4.1.4.3.bb:ALTERNATIVE_PRIORITY = "200"
meta/recipes-core/util-linux/util-linux.inc:ALTERNATIVE_PRIORITY = "100"

//Chen Qi

> Regards,
> Jonathan
Saul Wold - May 28, 2013, 7:02 a.m.
On 05/28/2013 02:39 PM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> The following changes since commit 21089515bd18ba18e86ec8f72ff8141b9fb1dea8:
>
>    ref-manual: Added xmlto and dblatex packages for docs (2013-05-22 17:23:41 +0100)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib ChenQi/tinylogin-busybox
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tinylogin-busybox
>
> Chen Qi (2):
>    packagegroup-core-boot: use busybox as the default login manager
>    busybox: enable login/password commands by default
>
As Otavio suggested, these need to be re-ordered.

Does this all work correctly without the need to use "setuid" of the 
busybox binary, it seems we currently are doing setuid for the busybox 
binary since we include SUID app, but what would happen to tinylogin if 
we remove that?

Sau!

>   meta/recipes-core/busybox/busybox-1.20.2/defconfig |   26 ++++++++++----------
>   .../packagegroups/packagegroup-core-boot.bb        |    2 +-
>   2 files changed, 14 insertions(+), 14 deletions(-)
>