Patchwork [0/1] RFC: Add recipe of gtk3 version of vte alongside gtk2 one.

login
register
mail settings
Submitter Marko Lindqvist
Date May 26, 2013, 2:03 p.m.
Message ID <cover.1369576071.git.cazfi74@gmail.com>
Download mbox
Permalink /patch/50547/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib cazfi/rfc

Comments

Marko Lindqvist - May 26, 2013, 2:03 p.m.
RFC only! Patch is only build-tested.

Last gtk2-compatible version of vte is 0.28.2 currently present on OE core.
Later versions depend on gtk3. Since gtk3 exist in OE core, it would make
sense to be able to build version of vte (and other similar packages)
that does not depend on gtk2. Otherwise we end with systems that must
contain both gtk2 (to be used by some programs) and gtk3 (to be used by
other programs).
This patch just adds new recipe for latest vte version, 0.34.5, alongside
with 0.28.2 version.
How should priorities be set? "1" for gtk2-version, so it gets selected despite gtk3-version being newer?


 - ML

The following changes since commit 8f5bc47729edb8cb051d81e9ff1680cb8d2eca25:

  dropbear: a fix for hang in dropbearkey, built for x32 (2013-05-24 14:14:30 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib cazfi/rfc
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=cazfi/rfc

Marko Lindqvist (1):
  vte: add 0.34.5 recipe

 .../vte/vte-0.34.5/obsolete_automake_macros.patch        |   14 ++++++++++++++
 meta/recipes-support/vte/vte.inc                         |    4 +++-
 meta/recipes-support/vte/vte_0.28.2.bb                   |    6 ++++--
 meta/recipes-support/vte/vte_0.34.5.bb                   |   12 ++++++++++++
 4 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-support/vte/vte-0.34.5/obsolete_automake_macros.patch
 create mode 100644 meta/recipes-support/vte/vte_0.34.5.bb
Ross Burton - May 29, 2013, 10:14 a.m.
On 26 May 2013 15:03, Marko Lindqvist <cazfi74@gmail.com> wrote:
> Last gtk2-compatible version of vte is 0.28.2 currently present on OE core.
> Later versions depend on gtk3.

vte supports both gtk2 and gtk3.

> Since gtk3 exist in OE core, it would make
> sense to be able to build version of vte (and other similar packages)
> that does not depend on gtk2. Otherwise we end with systems that must
> contain both gtk2 (to be used by some programs) and gtk3 (to be used by
> other programs).
> This patch just adds new recipe for latest vte version, 0.34.5, alongside
> with 0.28.2 version.
> How should priorities be set? "1" for gtk2-version, so it gets selected despite gtk3-version being newer?

Because they are *not* drop-in replacements, how about naming the gtk3
vte vte3_3.34.5.bb?

Ross
Marko Lindqvist - May 29, 2013, 10:14 p.m.
On 29 May 2013 13:14, Burton, Ross <ross.burton@intel.com> wrote:

> On 26 May 2013 15:03, Marko Lindqvist <cazfi74@gmail.com> wrote:
> > Last gtk2-compatible version of vte is 0.28.2 currently present on OE
> core.
> > Later versions depend on gtk3.
>
> vte supports both gtk2 and gtk3.
>

 0.30.0 NEWS states that "dropped support for gtk2". While this sounds like
upstream 0.28.2 would work with either gtk2 or gtk3, OE recipe depends on
"gtk+", which is always gtk2?


> > Since gtk3 exist in OE core, it would make
> > sense to be able to build version of vte (and other similar packages)
> > that does not depend on gtk2. Otherwise we end with systems that must
> > contain both gtk2 (to be used by some programs) and gtk3 (to be used by
> > other programs).
> > This patch just adds new recipe for latest vte version, 0.34.5, alongside
> > with 0.28.2 version.
> > How should priorities be set? "1" for gtk2-version, so it gets selected
> despite gtk3-version being newer?
>
> Because they are *not* drop-in replacements, how about naming the gtk3
> vte vte3_3.34.5.bb?
>

 I think calling it vte3 would be confusing at best, when vte itself is not
version 3.x. How about "vte-gtk3"?


 - ML
Otavio Salvador - May 29, 2013, 10:58 p.m.
On Wed, May 29, 2013 at 7:14 PM, Marko Lindqvist <cazfi74@gmail.com> wrote:

> On 29 May 2013 13:14, Burton, Ross <ross.burton@intel.com> wrote:
>
>> On 26 May 2013 15:03, Marko Lindqvist <cazfi74@gmail.com> wrote:
>> > Last gtk2-compatible version of vte is 0.28.2 currently present on OE
>> core.
>> > Later versions depend on gtk3.
>>
>> vte supports both gtk2 and gtk3.
>>
>
>  0.30.0 NEWS states that "dropped support for gtk2". While this sounds
> like upstream 0.28.2 would work with either gtk2 or gtk3, OE recipe depends
> on "gtk+", which is always gtk2?
>
>
>> > Since gtk3 exist in OE core, it would make
>> > sense to be able to build version of vte (and other similar packages)
>> > that does not depend on gtk2. Otherwise we end with systems that must
>> > contain both gtk2 (to be used by some programs) and gtk3 (to be used by
>> > other programs).
>> > This patch just adds new recipe for latest vte version, 0.34.5,
>> alongside
>> > with 0.28.2 version.
>> > How should priorities be set? "1" for gtk2-version, so it gets selected
>> despite gtk3-version being newer?
>>
>> Because they are *not* drop-in replacements, how about naming the gtk3
>> vte vte3_3.34.5.bb?
>>
>
>  I think calling it vte3 would be confusing at best, when vte itself is
> not version 3.x. How about "vte-gtk3"?
>

So I would say to rename vte to vte-gtk2 at same time and make it provide
vte for now.