Patchwork patch: diable xattr as default

login
register
mail settings
Submitter Saul Wold
Date May 21, 2013, 11:54 p.m.
Message ID <1369180475-31178-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/50273/
State Accepted
Commit a7de32c8ad1405ed31b620fb99dfe0fe80ac23a9
Headers show

Comments

Saul Wold - May 21, 2013, 11:54 p.m.
There is a optional dependency on xattr (and thus the attr package),
disable it by default, to ensure it builds correctly.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
 1 file changed, 2 insertions(+)
Mark Hatle - May 22, 2013, 12:20 a.m.
On 5/21/13 6:54 PM, Saul Wold wrote:
> There is a optional dependency on xattr (and thus the attr package),
> disable it by default, to ensure it builds correctly.
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb
> index 38df034..b131204 100644
> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb
> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb
> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>
>   acpaths = "-I ${S}/m4 "
> +
> +EXTRA_OECONF += "--disable-xattr"

There is an xattr distro feature.  It would be better to use:

ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr', 
'--disable-xattr', d)}"

EXTRA_OECONF += "${ENABLE_XATTR}"

(Might need a -native/-nativesdk version?)

>
Mark Hatle - May 22, 2013, 12:23 a.m.
On 5/21/13 7:20 PM, Mark Hatle wrote:
> On 5/21/13 6:54 PM, Saul Wold wrote:
>> There is a optional dependency on xattr (and thus the attr package),
>> disable it by default, to ensure it builds correctly.
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>    meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
>>    1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb
>> index 38df034..b131204 100644
>> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb
>> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb
>> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
>>    LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>
>>    acpaths = "-I ${S}/m4 "
>> +
>> +EXTRA_OECONF += "--disable-xattr"
>
> There is an xattr distro feature.  It would be better to use:
>
> ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr', '--enable-xattr',
> '--disable-xattr', d)}"
>
> EXTRA_OECONF += "${ENABLE_XATTR}"
>
> (Might need a -native/-nativesdk version?)

I forgot, PACKAGECONFIG might be better to use....  then the attr package 
dependencies can more easily be added.

PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"

--Mark

>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Saul Wold - May 22, 2013, 12:43 a.m.
On 05/21/2013 05:23 PM, Mark Hatle wrote:
> On 5/21/13 7:20 PM, Mark Hatle wrote:
>> On 5/21/13 6:54 PM, Saul Wold wrote:
>>> There is a optional dependency on xattr (and thus the attr package),
>>> disable it by default, to ensure it builds correctly.
>>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>> ---
>>>    meta/recipes-devtools/patch/patch_2.7.1.bb |    2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> b/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> index 38df034..b131204 100644
>>> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] =
>>> "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
>>>    LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>>
>>>    acpaths = "-I ${S}/m4 "
>>> +
>>> +EXTRA_OECONF += "--disable-xattr"
>>
>> There is an xattr distro feature.  It would be better to use:
>>
>> ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr',
>> '--enable-xattr',
>> '--disable-xattr', d)}"
>>
>> EXTRA_OECONF += "${ENABLE_XATTR}"
>>
>> (Might need a -native/-nativesdk version?)
>
> I forgot, PACKAGECONFIG might be better to use....  then the attr
> package dependencies can more easily be added.
>
> PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr',
> '', d)}"
> PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
>

Yup, this is more correct and slap my hand for forgetting the xattr 
DISTO_FEATURE!

V2 coming after some tests.

Sau!

> --Mark
>
>>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb b/meta/recipes-devtools/patch/patch_2.7.1.bb
index 38df034..b131204 100644
--- a/meta/recipes-devtools/patch/patch_2.7.1.bb
+++ b/meta/recipes-devtools/patch/patch_2.7.1.bb
@@ -9,3 +9,5 @@  SRC_URI[sha256sum] = "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
 acpaths = "-I ${S}/m4 "
+
+EXTRA_OECONF += "--disable-xattr"