Patchwork [v2,1/1] runqemu: fix networking issues

login
register
mail settings
Submitter Laurentiu Palcu
Date May 21, 2013, 7:38 a.m.
Message ID <4038377c71573129009473c15599e3d40b6b66a4.1369121729.git.laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/50209/
State Accepted
Commit a286514e2311f52b54d3571dbac6d34aff39e591
Headers show

Comments

Laurentiu Palcu - May 21, 2013, 7:38 a.m.
After switching from ifconfig to ip, networking stopped working. This
commit contains the following fixes:

 * set a decent broadcast address for the tap device;
 * bring up the device;
 * add the route using ip tool instead of the old route tool;

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 scripts/runqemu-ifup |   15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

Patch

diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
index 8948153..5f6a437 100755
--- a/scripts/runqemu-ifup
+++ b/scripts/runqemu-ifup
@@ -80,16 +80,6 @@  if [ ! -x "$IFCONFIG" ]; then
 	exit 1
 fi
 
-ROUTE=`which route`
-if [ "x$ROUTE" = "x" ]; then
-	# better than nothing...
-	ROUTE=/sbin/route
-fi
-if [ ! -x "$ROUTE" ]; then
-	echo "$ROUTE cannot be executed"
-	exit 1
-fi
-
 IPTABLES=`which iptables 2> /dev/null`
 if [ "x$IPTABLES" = "x" ]; then
 	IPTABLES=/sbin/iptables
@@ -100,10 +90,11 @@  if [ ! -x "$IPTABLES" ]; then
 fi
 
 n=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
-$IFCONFIG addr add 192.168.7.$n/32 dev $TAP
+$IFCONFIG addr add 192.168.7.$n/32 broadcast 192.168.7.255 dev $TAP
+$IFCONFIG link set dev $TAP up
 
 dest=$[ (`echo $TAP | sed 's/tap//'` * 2) + 2 ]
-$ROUTE add -host 192.168.7.$dest $TAP
+$IFCONFIG route add to 192.168.7.$dest dev $TAP
 
 # setup NAT for tap0 interface to have internet access in QEMU
 $IPTABLES -A POSTROUTING -t nat -j MASQUERADE -s 192.168.7.$n/32