Patchwork [bitbake-devel,1.18,1/3] goggle: fix invalid error check

login
register
mail settings
Submitter Paul Eggleton
Date May 20, 2013, 3:20 p.m.
Message ID <8ad4975c3bd80f7b1e9050f42241ad7ac5960d3f.1369063091.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/50163/
State New
Headers show

Comments

Paul Eggleton - May 20, 2013, 3:20 p.m.
From: Martin Donnelly <martin.donnelly@ge.com>

runCommand was returning 'error' but checking for 'err'
resulting in an exception.

(Bitbake master rev: 263aa44ed47e0cb03e1a97e7ed4a50bd9f828c78)

Signed-off-by: Martin Donnelly <martin.donnelly@ge.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 bitbake/lib/bb/ui/goggle.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/bitbake/lib/bb/ui/goggle.py b/bitbake/lib/bb/ui/goggle.py
index c0785b7..e8a54ab 100644
--- a/bitbake/lib/bb/ui/goggle.py
+++ b/bitbake/lib/bb/ui/goggle.py
@@ -81,7 +81,7 @@  def main (server, eventHandler):
 
     try:
         cmdline, error = server.runCommand(["getCmdLineAction"])
-        if err:
+        if error:
             print("Error getting bitbake commandline: %s" % error)
             return 1
         elif not cmdline: