Patchwork runqemu: fix networking issues

login
register
mail settings
Submitter Laurentiu Palcu
Date May 20, 2013, 10:09 a.m.
Message ID <1369044584-6053-1-git-send-email-laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/50133/
State New
Headers show

Comments

Laurentiu Palcu - May 20, 2013, 10:09 a.m.
After switching from ifconfig to ip, networking stopped working. This
commit contains the following fixes:

 * set a decent broadcast address for the tap device;
 * bring up the device;

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
Apparently, the autobuilder has some magic into it because all the sanity tests
succeeded... So, I don't know why AB tests succeeded but on my machine, and several
others, networking was broken and couldn't connect into the qemu image. If I'm
missing something, please, do not hesitate to correct me. This patch fixes the
issue for me though.

Thanks,
Laurentiu

 scripts/runqemu-ifup |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Stanacar, StefanX - May 20, 2013, 3:35 p.m.
On Mon, 2013-05-20 at 13:09 +0300, Laurentiu Palcu wrote:
> After switching from ifconfig to ip, networking stopped working. This
> commit contains the following fixes:
> 
>  * set a decent broadcast address for the tap device;
>  * bring up the device;
> 
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
> Apparently, the autobuilder has some magic into it because all the sanity tests
> succeeded... So, I don't know why AB tests succeeded but on my machine, and several
> others, networking was broken and couldn't connect into the qemu image. If I'm
> missing something, please, do not hesitate to correct me. This patch fixes the
> issue for me though.
> 
> Thanks,
> Laurentiu
> 
>  scripts/runqemu-ifup |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
> index 8948153..108d9a4 100755
> --- a/scripts/runqemu-ifup
> +++ b/scripts/runqemu-ifup
> @@ -100,7 +100,8 @@ if [ ! -x "$IPTABLES" ]; then
>  fi
>  
>  n=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
> -$IFCONFIG addr add 192.168.7.$n/32 dev $TAP
> +$IFCONFIG addr add 192.168.7.$n/32 broadcast 192.168.7.255 dev $TAP
> +$IFCONFIG link set dev $TAP up
>  
>  dest=$[ (`echo $TAP | sed 's/tap//'` * 2) + 2 ]
>  $ROUTE add -host 192.168.7.$dest $TAP

This fixes the issue for me too, thought there is something very strange
here. Last week I ran master builds (with newer commits than the
ifconfig->ip change) without ever seeing this issue. But today on the
same commit that on Friday worked, I get no network. The only thing that
changed is that my machine rebooted Monday morning... (I blame the gamma
rays). Also I think ROUTE too should be changed to use ip instead of the
old route command.


Regards,
Stefan
Khem Raj - May 20, 2013, 3:47 p.m.
thanks for fixing it. I wonder why I did not run into it something in
my settings probably.

On Mon, May 20, 2013 at 3:09 AM, Laurentiu Palcu
<laurentiu.palcu@intel.com> wrote:
> After switching from ifconfig to ip, networking stopped working. This
> commit contains the following fixes:
>
>  * set a decent broadcast address for the tap device;
>  * bring up the device;
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
> Apparently, the autobuilder has some magic into it because all the sanity tests
> succeeded... So, I don't know why AB tests succeeded but on my machine, and several
> others, networking was broken and couldn't connect into the qemu image. If I'm
> missing something, please, do not hesitate to correct me. This patch fixes the
> issue for me though.
>
> Thanks,
> Laurentiu
>
>  scripts/runqemu-ifup |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
> index 8948153..108d9a4 100755
> --- a/scripts/runqemu-ifup
> +++ b/scripts/runqemu-ifup
> @@ -100,7 +100,8 @@ if [ ! -x "$IPTABLES" ]; then
>  fi
>
>  n=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
> -$IFCONFIG addr add 192.168.7.$n/32 dev $TAP
> +$IFCONFIG addr add 192.168.7.$n/32 broadcast 192.168.7.255 dev $TAP
> +$IFCONFIG link set dev $TAP up
>
>  dest=$[ (`echo $TAP | sed 's/tap//'` * 2) + 2 ]
>  $ROUTE add -host 192.168.7.$dest $TAP
> --
> 1.7.9.5
>
Khem Raj - May 20, 2013, 3:47 p.m.
On Mon, May 20, 2013 at 8:35 AM, Stanacar, StefanX
<stefanx.stanacar@intel.com> wrote:
> Also I think ROUTE too should be changed to use ip instead of the
> old route command.


yes it should be.

Patch

diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
index 8948153..108d9a4 100755
--- a/scripts/runqemu-ifup
+++ b/scripts/runqemu-ifup
@@ -100,7 +100,8 @@  if [ ! -x "$IPTABLES" ]; then
 fi
 
 n=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
-$IFCONFIG addr add 192.168.7.$n/32 dev $TAP
+$IFCONFIG addr add 192.168.7.$n/32 broadcast 192.168.7.255 dev $TAP
+$IFCONFIG link set dev $TAP up
 
 dest=$[ (`echo $TAP | sed 's/tap//'` * 2) + 2 ]
 $ROUTE add -host 192.168.7.$dest $TAP