Patchwork [meta-fsl-ppc,master] base-files:fix the command line wrap around issue

login
register
mail settings
Submitter Zongchun Yu
Date May 20, 2013, 3:21 a.m.
Message ID <1369020072-7356-1-git-send-email-b40527@freescale.com>
Download mbox | patch
Permalink /patch/50131/
State Rejected
Delegated to: Zhenhua Luo
Headers show

Comments

Zongchun Yu - May 20, 2013, 3:21 a.m.
From: Zongchun Yu <b40527@freescale.com>

when the character number of cmdline is more than 80. the following character should
go to a new line. rather than cover the prompt and the inputting character before.

Signed-off-by: Zongchun Yu <b40527@freescale.com>
---
 recipes-core/base-files/base-files_3.0.14.bbappend |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
 create mode 100644 recipes-core/base-files/base-files_3.0.14.bbappend
Ting Liu - May 20, 2013, 10:15 a.m.
> -----Original Message-----
> From: Yu Zongchun-B40527
> Sent: Monday, May 20, 2013 11:21 AM
> To: meta-freescale@yoctoproject.org
> Cc: Luo Zhenhua-B19537; Liu Ting-B28495; Guo Chunrong-B40290; Yu
> Zongchun-B40527
> Subject: [PATCH] [meta-fsl-ppc,master]base-files:fix the command line
> wrap around issue
> 
> From: Zongchun Yu <b40527@freescale.com>
> 
> when the character number of cmdline is more than 80. the following
> character should go to a new line. rather than cover the prompt and the
> inputting character before.
> 
> Signed-off-by: Zongchun Yu <b40527@freescale.com>
> ---
>  recipes-core/base-files/base-files_3.0.14.bbappend |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)  create mode 100644
> recipes-core/base-files/base-files_3.0.14.bbappend
> 
> diff --git a/recipes-core/base-files/base-files_3.0.14.bbappend
> b/recipes-core/base-files/base-files_3.0.14.bbappend
> new file mode 100644
> index 0000000..5401e99
> --- /dev/null
> +++ b/recipes-core/base-files/base-files_3.0.14.bbappend
> @@ -0,0 +1,8 @@
> +do_install_append () {
> +   echo "export COLUMNS=80" >> ${D}${sysconfdir}/profile
> +   install -d ${D}/home/root
> +   echo "export COLUMNS=2000" >> ${D}/home/root/.profile

Home directory of root can be customized in Yocto. And what about other account?

> +   echo "if [ -f /usr/bin/resize ]; then /usr/bin/resize > /dev/null;
> +fi" >> ${D}/home/root/.profile }
> +
> +FILES_${PN} += "/home/root/.profile"
> --
> 1.6.2.5
Otavio Salvador - May 20, 2013, 12:25 p.m.
On Mon, May 20, 2013 at 12:21 AM, <b40527@freescale.com> wrote:

> From: Zongchun Yu <b40527@freescale.com>
>
> when the character number of cmdline is more than 80. the following
> character should
> go to a new line. rather than cover the prompt and the inputting character
> before.
>
> Signed-off-by: Zongchun Yu <b40527@freescale.com>
>

I think this needs to be fixed in OE-Core/Yocto and it is not BSP related.
Please propose a patch for OE-Core that fixes it generically.
Fabio Estevam - May 20, 2013, 12:45 p.m.
On Mon, May 20, 2013 at 9:25 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
>
>
>
> On Mon, May 20, 2013 at 12:21 AM, <b40527@freescale.com> wrote:
>>
>> From: Zongchun Yu <b40527@freescale.com>
>>
>> when the character number of cmdline is more than 80. the following
>> character should
>> go to a new line. rather than cover the prompt and the inputting character
>> before.
>>
>> Signed-off-by: Zongchun Yu <b40527@freescale.com>
>
>
> I think this needs to be fixed in OE-Core/Yocto and it is not BSP related.
> Please propose a patch for OE-Core that fixes it generically.

Yes, we also have this same issue in meta-fsl-arm and it is quite annoying.

Hopefully it can be fixed in oe-core.

Patch

diff --git a/recipes-core/base-files/base-files_3.0.14.bbappend b/recipes-core/base-files/base-files_3.0.14.bbappend
new file mode 100644
index 0000000..5401e99
--- /dev/null
+++ b/recipes-core/base-files/base-files_3.0.14.bbappend
@@ -0,0 +1,8 @@ 
+do_install_append () {
+   echo "export COLUMNS=80" >> ${D}${sysconfdir}/profile
+   install -d ${D}/home/root
+   echo "export COLUMNS=2000" >> ${D}/home/root/.profile
+   echo "if [ -f /usr/bin/resize ]; then /usr/bin/resize > /dev/null; fi" >> ${D}/home/root/.profile
+}
+
+FILES_${PN} += "/home/root/.profile"