Patchwork [bitbake-devel] data: Ensure dependencies of subfunctions are accounted for

login
register
mail settings
Submitter Richard Purdie
Date May 19, 2013, 10:16 a.m.
Message ID <1368958614.32727.91.camel@ted>
Download mbox | patch
Permalink /patch/50081/
State New
Headers show

Comments

Richard Purdie - May 19, 2013, 10:16 a.m.
Currently we account of the top level function's vardeps but not
those of any subfunction. This would imply we'd have to manually
write the dependencies of all parent functions which would be crazy.

This patch adds the dependencies to fix the issue.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py
index abf210a..87c4808 100644
--- a/bitbake/lib/bb/data.py
+++ b/bitbake/lib/bb/data.py
@@ -274,6 +274,7 @@  def emit_func(func, o=sys.__stdout__, d = init()):
             if d.getVarFlag(dep, "func"):
                emit_var(dep, o, d, False) and o.write('\n')
                newdeps |=  bb.codeparser.ShellParser(dep, logger).parse_shell(d.getVar(dep, True))
+               newdeps |= set((d.getVarFlag(dep, "vardeps", True) or "").split())
         newdeps -= seen
 
 def update_data(d):