Patchwork [meta-browser] libxi: Match the bbappend to OE-Core

login
register
mail settings
Submitter Khem Raj
Date May 18, 2013, 4:39 p.m.
Message ID <1368895167-6841-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/50073/
State Accepted, archived
Headers show

Comments

Khem Raj - May 18, 2013, 4:39 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
CC: Eric Bénard <eric@eukrea.com>
CC: Denis Carikli <denis@eukrea.com>
CC: Otavio Salvador <otavio@ossystems.com.br>

---
 recipes-graphics/libxi/libxi_1.7.1.bbappend |    2 ++
 recipes-graphics/libxi/libxi_1.7.bbappend   |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
 create mode 100644 recipes-graphics/libxi/libxi_1.7.1.bbappend
 delete mode 100644 recipes-graphics/libxi/libxi_1.7.bbappend
Andreas Müller - May 18, 2013, 5:35 p.m.
On Sat, May 18, 2013 at 6:39 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> CC: Eric Bénard <eric@eukrea.com>
> CC: Denis Carikli <denis@eukrea.com>
> CC: Otavio Salvador <otavio@ossystems.com.br>
>
> ---
>  recipes-graphics/libxi/libxi_1.7.1.bbappend |    2 ++
>  recipes-graphics/libxi/libxi_1.7.bbappend   |    2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  create mode 100644 recipes-graphics/libxi/libxi_1.7.1.bbappend
>  delete mode 100644 recipes-graphics/libxi/libxi_1.7.bbappend
>
> diff --git a/recipes-graphics/libxi/libxi_1.7.1.bbappend b/recipes-graphics/libxi/libxi_1.7.1.bbappend
> new file mode 100644
> index 0000000..c90046b
> --- /dev/null
> +++ b/recipes-graphics/libxi/libxi_1.7.1.bbappend
> @@ -0,0 +1,2 @@
> +PRINC := "${@int(PRINC) + 1}"
> +BBCLASSEXTEND += "native"
> diff --git a/recipes-graphics/libxi/libxi_1.7.bbappend b/recipes-graphics/libxi/libxi_1.7.bbappend
> deleted file mode 100644
> index c90046b..0000000
> --- a/recipes-graphics/libxi/libxi_1.7.bbappend
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -PRINC := "${@int(PRINC) + 1}"
> -BBCLASSEXTEND += "native"
> --
> 1.7.9.5
>
Martin sent same already - for unknown reasons it did not make it into
patchwork [1]

Andreas

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-May/045597.html
Eric BENARD - May 18, 2013, 7:57 p.m.
Hi Khem,

Le Sat, 18 May 2013 09:39:27 -0700,
Khem Raj <raj.khem@gmail.com> a écrit :

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> CC: Eric Bénard <eric@eukrea.com>
> CC: Denis Carikli <denis@eukrea.com>
> CC: Otavio Salvador <otavio@ossystems.com.br>
> 
> ---
>  recipes-graphics/libxi/libxi_1.7.1.bbappend |    2 ++
>  recipes-graphics/libxi/libxi_1.7.bbappend   |    2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  create mode 100644 recipes-graphics/libxi/libxi_1.7.1.bbappend
>  delete mode 100644 recipes-graphics/libxi/libxi_1.7.bbappend
> 
> diff --git a/recipes-graphics/libxi/libxi_1.7.1.bbappend b/recipes-graphics/libxi/libxi_1.7.1.bbappend
> new file mode 100644
> index 0000000..c90046b
> --- /dev/null
> +++ b/recipes-graphics/libxi/libxi_1.7.1.bbappend
> @@ -0,0 +1,2 @@
> +PRINC := "${@int(PRINC) + 1}"
> +BBCLASSEXTEND += "native"
> diff --git a/recipes-graphics/libxi/libxi_1.7.bbappend b/recipes-graphics/libxi/libxi_1.7.bbappend
> deleted file mode 100644
> index c90046b..0000000
> --- a/recipes-graphics/libxi/libxi_1.7.bbappend
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -PRINC := "${@int(PRINC) + 1}"
> -BBCLASSEXTEND += "native"

pushed to master

Thanks
Eric
Martin Jansa - May 19, 2013, 7:45 a.m.
On Sat, May 18, 2013 at 07:35:33PM +0200, Andreas Müller wrote:
> Martin sent same already - for unknown reasons it did not make it into
> patchwork [1]
> 
> Andreas
> 
> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-May/045597.html

It didn't make it into patchwork, because I've used -M and rename-only
patches are not picked by patchwork :/

Eric, can you please update status on patches in meta-browser bundle 
and when you're there also in danny?, dylan is empty now.

http://patches.openembedded.org/bundle/jama/meta-browser/?archive=both
http://patches.openembedded.org/bundle/jama/danny/?archive=both

http://patches.openembedded.org/bundle/jama/dylan/?archive=both
Ross Burton - May 20, 2013, 9:18 a.m.
On 18 May 2013 17:39, Khem Raj <raj.khem@gmail.com> wrote:
> +BBCLASSEXTEND += "native"

Why don't you submit a patch to oe-core's libxi, or even
xorg-lib-common.inc, to add this?

Ross
Khem Raj - May 20, 2013, 3:25 p.m.
On Mon, May 20, 2013 at 2:18 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 18 May 2013 17:39, Khem Raj <raj.khem@gmail.com> wrote:
>> +BBCLASSEXTEND += "native"
>
> Why don't you submit a patch to oe-core's libxi, or even
> xorg-lib-common.inc, to add this?


yeah that should be in OE-Core.
Ross Burton - May 20, 2013, 3:30 p.m.
On 20 May 2013 16:25, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, May 20, 2013 at 2:18 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 18 May 2013 17:39, Khem Raj <raj.khem@gmail.com> wrote:
>>> +BBCLASSEXTEND += "native"
>>
>> Why don't you submit a patch to oe-core's libxi, or even
>> xorg-lib-common.inc, to add this?
>
> yeah that should be in OE-Core.

I also noticed that it's only used by one of the three chrome recipes,
so is it even needed at all?

Ross
Khem Raj - May 20, 2013, 3:46 p.m.
On Mon, May 20, 2013 at 8:30 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 20 May 2013 16:25, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, May 20, 2013 at 2:18 AM, Burton, Ross <ross.burton@intel.com> wrote:
>>> On 18 May 2013 17:39, Khem Raj <raj.khem@gmail.com> wrote:
>>>> +BBCLASSEXTEND += "native"
>>>
>>> Why don't you submit a patch to oe-core's libxi, or even
>>> xorg-lib-common.inc, to add this?
>>
>> yeah that should be in OE-Core.
>
> I also noticed that it's only used by one of the three chrome recipes,
> so is it even needed at all?

the version which uses it is the default version for all architectures
for sometime
24.0.1312 is latest and may be used widely now but unless 19.0.1049 recipes are
in there this is needed. I will send a cleanup patch and see what folks think.
Eric BENARD - May 28, 2013, 8:04 a.m.
Hi Martin,

Le Sun, 19 May 2013 09:45:39 +0200,
Martin Jansa <martin.jansa@gmail.com> a écrit :

> On Sat, May 18, 2013 at 07:35:33PM +0200, Andreas Müller wrote:
> > Martin sent same already - for unknown reasons it did not make it into
> > patchwork [1]
> > 
> > Andreas
> > 
> > [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-May/045597.html
> 
> It didn't make it into patchwork, because I've used -M and rename-only
> patches are not picked by patchwork :/
> 
> Eric, can you please update status on patches in meta-browser bundle 
> and when you're there also in danny?, dylan is empty now.
> 
> http://patches.openembedded.org/bundle/jama/meta-browser/?archive=both
> http://patches.openembedded.org/bundle/jama/danny/?archive=both
> 
> http://patches.openembedded.org/bundle/jama/dylan/?archive=both
> 
cleanup done.

Thanks for the reminder ;-)

Eric

Patch

diff --git a/recipes-graphics/libxi/libxi_1.7.1.bbappend b/recipes-graphics/libxi/libxi_1.7.1.bbappend
new file mode 100644
index 0000000..c90046b
--- /dev/null
+++ b/recipes-graphics/libxi/libxi_1.7.1.bbappend
@@ -0,0 +1,2 @@ 
+PRINC := "${@int(PRINC) + 1}"
+BBCLASSEXTEND += "native"
diff --git a/recipes-graphics/libxi/libxi_1.7.bbappend b/recipes-graphics/libxi/libxi_1.7.bbappend
deleted file mode 100644
index c90046b..0000000
--- a/recipes-graphics/libxi/libxi_1.7.bbappend
+++ /dev/null
@@ -1,2 +0,0 @@ 
-PRINC := "${@int(PRINC) + 1}"
-BBCLASSEXTEND += "native"