Patchwork collectd: fix build failure with libnotify in sysroot

login
register
mail settings
Submitter Paul Eggleton
Date May 16, 2013, 10:55 a.m.
Message ID <1368701701-1918-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/49991/
State Accepted, archived
Commit b1095d11bdb33648bc4f1394146804cd9734b223
Headers show

Comments

Paul Eggleton - May 16, 2013, 10:55 a.m.
If libnotify is in the sysroot, collectd will try to use it and then
fail at do_compile because gtk/gtk.h can't be found. Since this is
functionality that's not likely to be needed in the embedded context as
far as collectd goes, just disable it.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
 1 file changed, 1 insertion(+)
Paul Eggleton - May 16, 2013, 11:07 a.m.
On Thursday 16 May 2013 11:55:01 Paul Eggleton wrote:
> If libnotify is in the sysroot, collectd will try to use it and then
> fail at do_compile because gtk/gtk.h can't be found. Since this is
> functionality that's not likely to be needed in the embedded context as
> far as collectd goes, just disable it.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> a508840..8641530 100644
> --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> @@ -26,6 +26,7 @@ EXTRA_OECONF = " \
>                  ${FPLAYOUT} \
>                  --disable-perl --with-libperl=no --with-perl-bindings=no \
>                  --with-libgcrypt=${STAGING_BINDIR_CROSS}/libgcrypt-config \
> +                --disable-notify_desktop \
>  "
> 
>  do_install_append() {

I missed out the subject prefix, sorry, this is meant for the meta-oe layer in 
case it wasn't obvious.

Cheers,
Paul

Patch

diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
index a508840..8641530 100644
--- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
+++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
@@ -26,6 +26,7 @@  EXTRA_OECONF = " \
                 ${FPLAYOUT} \
                 --disable-perl --with-libperl=no --with-perl-bindings=no \
                 --with-libgcrypt=${STAGING_BINDIR_CROSS}/libgcrypt-config \
+                --disable-notify_desktop \
 "
 
 do_install_append() {