Patchwork [0/4] Postinst logging reimplementation

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date May 16, 2013, 7:56 a.m.
Message ID <cover.1368690819.git.Qi.Chen@windriver.com>
Download mbox
Permalink /patch/49983/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib ChenQi/postinst-logging-reimplementation

Comments

Qi.Chen@windriver.com - May 16, 2013, 7:56 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

Goal:
1. Enable postinst logging if 'debug-tweaks' is in IMAGE_FEATURES
2. Make rpm, opkg and dpkg not depend on IMAGE_FEATURES and POSTLOG

Implementation:
1. The run-postinst scripts will log outputs and errors if /etc/.enable_postinst_logging is present.
2. The log location is always /var/log/postinstall.log. Do not allow configuration, because this is
   mainly for debugging purpose and /var/log/postinstall.log is a good place. Making it configurable is not necessary.

The following changes since commit a9f5bf0ed398bf9cb861feaa8b6fefd8645b1d09:

  sanity.bbclass: Attach the missing value to a format string. (2013-05-13 21:54:40 +0300)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/postinst-logging-reimplementation
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/postinst-logging-reimplementation

Chen Qi (4):
  image.bbclass: add postinst_enable_logging
  dpkg: modify the run-postinst script to enable postinst logging
  opkg: modify the run-postinst script to enable postinst logging
  rpm-postinsts.bb: enable postinst logging

 meta/classes/image.bbclass                 |    7 +++++++
 meta/recipes-devtools/dpkg/dpkg.inc        |   10 +++++-----
 meta/recipes-devtools/opkg/opkg.inc        |   10 +++++-----
 meta/recipes-devtools/rpm/rpm-postinsts.bb |   11 ++++++-----
 4 files changed, 23 insertions(+), 15 deletions(-)
Ross Burton - May 16, 2013, 8:56 a.m.
On 16 May 2013 08:56,  <Qi.Chen@windriver.com> wrote:
> 1. The run-postinst scripts will log outputs and errors if /etc/.enable_postinst_logging is present.

I'm not very keen on dot-files in etc, and as the postinst init script
is one-shot shouldn't it be deleting that configuration file once it's
completed?

Ross