Patchwork [oe-core,master] yajl: pass the cmake variable LIB_SUFFIX to handle installation on 64-bit systems

login
register
mail settings
Submitter Olivia Yin
Date May 14, 2013, 9:37 a.m.
Message ID <1368524249-8219-1-git-send-email-hong-hua.yin@freescale.com>
Download mbox | patch
Permalink /patch/49891/
State Accepted, archived
Headers show

Comments

Olivia Yin - May 14, 2013, 9:37 a.m.
WARNING: QA Issue: yajl: Files/directories were installed but not shipped
  /usr/lib
  /usr/lib/libyajl.so.2
  /usr/lib/libyajl.so
  /usr/lib/libyajl_s.a
  /usr/lib/libyajl.so.2.0.4
  /usr/lib/.debug
  /usr/lib/.debug/libyajl.so.2.0.4

NOTE: for 64-bit systems where lib64 is used you can pass the cmake
      variable LIB_SUFFIX to cause installation into the system's 'lib64'
      directory.

Signed-off-by: Olivia Yin <hong-hua.yin@freescale.com>
---
 meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Martin Jansa - May 14, 2013, noon
On Tue, May 14, 2013 at 05:37:29PM +0800, Olivia Yin wrote:
> WARNING: QA Issue: yajl: Files/directories were installed but not shipped
>   /usr/lib
>   /usr/lib/libyajl.so.2
>   /usr/lib/libyajl.so
>   /usr/lib/libyajl_s.a
>   /usr/lib/libyajl.so.2.0.4
>   /usr/lib/.debug
>   /usr/lib/.debug/libyajl.so.2.0.4
> 
> NOTE: for 64-bit systems where lib64 is used you can pass the cmake
>       variable LIB_SUFFIX to cause installation into the system's 'lib64'
>       directory.

Subject incorrectly says oe-core.

> Signed-off-by: Olivia Yin <hong-hua.yin@freescale.com>
> ---
>  meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> index 7359520..9d67e2d 100644
> --- a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> +++ b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "Yet Another JSON Library - A Portable JSON parsing and serialization library in ANSI C"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=74f541bd9a2b6c8e5d0714bcdc327f32"
> +PR = "r1"
>  
>  SRCREV = "fee1ebef9fa7dc0e9f5a23f37123b19b68c796ff"
>  SRC_URI = "git://github.com/lloyd/yajl.git"
> @@ -8,3 +9,5 @@ SRC_URI = "git://github.com/lloyd/yajl.git"
>  S = "${WORKDIR}/git"
>  
>  inherit cmake lib_package
> +
> +EXTRA_OECMAKE = "-DLIB_SUFFIX=${@d.getVar('baselib', True).replace('lib', '')}"
> -- 
> 1.7.0.4
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Martin Jansa - May 14, 2013, 5:09 p.m.
On Tue, May 14, 2013 at 02:00:08PM +0200, Martin Jansa wrote:
> On Tue, May 14, 2013 at 05:37:29PM +0800, Olivia Yin wrote:
> > WARNING: QA Issue: yajl: Files/directories were installed but not shipped
> >   /usr/lib
> >   /usr/lib/libyajl.so.2
> >   /usr/lib/libyajl.so
> >   /usr/lib/libyajl_s.a
> >   /usr/lib/libyajl.so.2.0.4
> >   /usr/lib/.debug
> >   /usr/lib/.debug/libyajl.so.2.0.4
> > 
> > NOTE: for 64-bit systems where lib64 is used you can pass the cmake
> >       variable LIB_SUFFIX to cause installation into the system's 'lib64'
> >       directory.
> 
> Subject incorrectly says oe-core.
And it was already applied few days ago:
http://git.openembedded.org/meta-openembedded/commit/?id=eb040205f38eb0e2c28ccc7b4f64e9541cc82cc0

> 
> > Signed-off-by: Olivia Yin <hong-hua.yin@freescale.com>
> > ---
> >  meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> > index 7359520..9d67e2d 100644
> > --- a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> > +++ b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
> > @@ -1,6 +1,7 @@
> >  DESCRIPTION = "Yet Another JSON Library - A Portable JSON parsing and serialization library in ANSI C"
> >  LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://COPYING;md5=74f541bd9a2b6c8e5d0714bcdc327f32"
> > +PR = "r1"
> >  
> >  SRCREV = "fee1ebef9fa7dc0e9f5a23f37123b19b68c796ff"
> >  SRC_URI = "git://github.com/lloyd/yajl.git"
> > @@ -8,3 +9,5 @@ SRC_URI = "git://github.com/lloyd/yajl.git"
> >  S = "${WORKDIR}/git"
> >  
> >  inherit cmake lib_package
> > +
> > +EXTRA_OECMAKE = "-DLIB_SUFFIX=${@d.getVar('baselib', True).replace('lib', '')}"
> > -- 
> > 1.7.0.4
> > 
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Patch

diff --git a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
index 7359520..9d67e2d 100644
--- a/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
+++ b/meta-oe/recipes-devtools/yajl/yajl_2.0.4.bb
@@ -1,6 +1,7 @@ 
 DESCRIPTION = "Yet Another JSON Library - A Portable JSON parsing and serialization library in ANSI C"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=74f541bd9a2b6c8e5d0714bcdc327f32"
+PR = "r1"
 
 SRCREV = "fee1ebef9fa7dc0e9f5a23f37123b19b68c796ff"
 SRC_URI = "git://github.com/lloyd/yajl.git"
@@ -8,3 +9,5 @@  SRC_URI = "git://github.com/lloyd/yajl.git"
 S = "${WORKDIR}/git"
 
 inherit cmake lib_package
+
+EXTRA_OECMAKE = "-DLIB_SUFFIX=${@d.getVar('baselib', True).replace('lib', '')}"