Patchwork pam: Add libtirpc to build dependencies

login
register
mail settings
Submitter Khem Raj
Date May 14, 2013, 6:45 a.m.
Message ID <1368513918-16448-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/49869/
State New
Headers show

Comments

Khem Raj - May 14, 2013, 6:45 a.m.
libtirpc is looked for by configure and if found
its enabled. So lets make it consistent and enable
it always

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - May 14, 2013, 10:05 a.m.
On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
> libtirpc is looked for by configure and if found
> its enabled. So lets make it consistent and enable
> it always
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What is the benefit of this dependency?

Cheers,

Richard
Khem Raj - May 14, 2013, 2:33 p.m.
On Tuesday, May 14, 2013, RicharPurdie <richard.purdie@linuxfoundation.org>
wrote:
> On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
>> libtirpc is looked for by configure and if found
>> its enabled. So lets make it consistent and enable
>> it always
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> What is the benefit of this dependency?


When building from sstate the build of libpam would fail during configure
if the machine who populated sstate had libtirpc staged before building
libpam and with high parallelism its quite often

>
> Cheers,
>
> Richard
>
>
Paul Eggleton - May 14, 2013, 2:41 p.m.
On Tuesday 14 May 2013 07:33:49 Khem Raj wrote:
> On Tuesday, May 14, 2013, RicharPurdie <richard.purdie@linuxfoundation.org>
> wrote:
> > On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
> >> libtirpc is looked for by configure and if found
> >> its enabled. So lets make it consistent and enable
> >> it always
> >> 
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> 
> >>  meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > What is the benefit of this dependency?
> 
> When building from sstate the build of libpam would fail during configure
> if the machine who populated sstate had libtirpc staged before building
> libpam and with high parallelism its quite often

Understood, but the question was what is the benefit of the added dependency on 
libtirpc; i.e. should we really be explicitly enabling this or explicitly 
disabling it?

Cheers,
Paul
Khem Raj - May 14, 2013, 3:49 p.m.
On Tuesday, May 14, 2013, Paul Eggleton <paul.eggleton@linux.intel.com>
wrote:
> On Tuesday 14 May 2013 07:33:49 Khem Raj wrote:
>> On Tuesday, May 14, 2013, RicharPurdie <
richard.purdie@linuxfoundation.org>
>> wrote:
>> > On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
>> >> libtirpc is looked for by configure and if found
>> >> its enabled. So lets make it consistent and enable
>> >> it always
>> >>
>> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> >> ---
>> >>
>> >>  meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > What is the benefit of this dependency?
>>
>> When building from sstate the build of libpam would fail during configure
>> if the machine who populated sstate had libtirpc staged before building
>> libpam and with high parallelism its quite often
>
> Understood, but the question was what is the benefit of the added
dependency on
> libtirpc; i.e. should we really be explicitly enabling this or explicitly
> disabling it?

There is no knob to disable/disable it. Adding one would be ideal but for
another day
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>
Phil Blundell - May 14, 2013, 4:24 p.m.
On Tue, 2013-05-14 at 07:33 -0700, Khem Raj wrote:
> 
> 
> On Tuesday, May 14, 2013, RicharPurdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
> >> libtirpc is looked for by configure and if found
> >> its enabled. So lets make it consistent and enable
> >> it always
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > What is the benefit of this dependency?
> 
> 
> When building from sstate the build of libpam would fail during
> configure if the machine who populated sstate had libtirpc staged
> before building libpam and with high parallelism its quite often 

Does this mean that every image which uses pam will also drag in tirpc?
What's the cost in space and time for that?

p.
Khem Raj - May 14, 2013, 9:10 p.m.
On May 14, 2013, at 9:24 AM, Phil Blundell <pb@pbcl.net> wrote:

> On Tue, 2013-05-14 at 07:33 -0700, Khem Raj wrote:
>> 
>> 
>> On Tuesday, May 14, 2013, RicharPurdie
>> <richard.purdie@linuxfoundation.org> wrote:
>>> On Mon, 2013-05-13 at 23:45 -0700, Khem Raj wrote:
>>>> libtirpc is looked for by configure and if found
>>>> its enabled. So lets make it consistent and enable
>>>> it always
>>>> 
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> meta/recipes-extended/pam/libpam_1.1.6.bb |    2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> What is the benefit of this dependency?
>> 
>> 
>> When building from sstate the build of libpam would fail during
>> configure if the machine who populated sstate had libtirpc staged
>> before building libpam and with high parallelism its quite often 
> 
> Does this mean that every image which uses pam will also drag in tirpc?

yes. 


> What's the cost in space and time for that?
> 

142K -  libtirpc.so.1.0.10

Time I can't quantify, depends on your build system e.g. on my system built from scratch with and without dependency
showed few (20+) seconds difference. It might vary for you.


> p.
> 
>

Patch

diff --git a/meta/recipes-extended/pam/libpam_1.1.6.bb b/meta/recipes-extended/pam/libpam_1.1.6.bb
index c355634..581f687 100644
--- a/meta/recipes-extended/pam/libpam_1.1.6.bb
+++ b/meta/recipes-extended/pam/libpam_1.1.6.bb
@@ -23,7 +23,7 @@  SRC_URI[sha256sum] = "bab887d6280f47fc3963df3b95735a27a16f0f663636163ddf3acab5f1
 
 SRC_URI_append_libc-uclibc = " file://pam-no-innetgr.patch"
 
-DEPENDS = "bison flex flex-native cracklib"
+DEPENDS = "bison flex flex-native cracklib libtirpc"
 
 EXTRA_OECONF = "--with-db-uniquename=_pam \
                 --includedir=${includedir}/security \