Patchwork [1/1] cachedpath.py: global name 'error' is not defined

login
register
mail settings
Submitter Robert Yang
Date May 13, 2013, 8:34 a.m.
Message ID <cf5272fc40c7b7d0b780358756fd9323fd6fe0d1.1368414411.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/49835/
State Accepted
Commit ac0e2781c2723257bd380cac170d4c8b97e36747
Headers show

Comments

Robert Yang - May 13, 2013, 8:34 a.m.
The error is not global since we don't use "from os import *", so it
should be os.error.

[YOCTO #4489]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/lib/oe/cachedpath.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/meta/lib/oe/cachedpath.py b/meta/lib/oe/cachedpath.py
index c7860ef..0840cc4 100644
--- a/meta/lib/oe/cachedpath.py
+++ b/meta/lib/oe/cachedpath.py
@@ -122,10 +122,8 @@  class CachedPath(object):
         # minor reason when (say) a thousand readable directories are still
         # left to visit.  That logic is copied here.
         try:
-            # Note that listdir and error are globals in this module due
-            # to earlier import-*.
             names = os.listdir(top)
-        except error as err:
+        except os.error as err:
             if onerror is not None:
                 onerror(err)
             return