Patchwork [v2] connman: add iptables to RDEPENDS

login
register
mail settings
Submitter Jonathan Liu
Date May 13, 2013, 2:58 a.m.
Message ID <1368413938-7757-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/49803/
State Not Applicable, archived
Headers show

Comments

Jonathan Liu - May 13, 2013, 2:58 a.m.
The connmand daemon requires libxtables.so from iptables to start up.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta/recipes-connectivity/connman/connman.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ross Burton - May 13, 2013, 9:05 a.m.
On 13 May 2013 03:58, Jonathan Liu <net147@gmail.com> wrote:
> The connmand daemon requires libxtables.so from iptables to start up.

And the automatic dependencies-from-linkage code seems to be working just fine:

$ dpkg -I connman_1.13-r20.0.2_core2.ipk
...
 Depends: iptables (>= 1.4.17), dbus-1, ofono, libdbus-1-3 (>= 1.6.8),
bluez4, libgnutls26 (>= 2.12.21), libc6 (>= 2.17), libglib-2.0-0 (>=
2.36.0), shadow, base-passwd, wpa-supplicant

So the question is can you verify that this dependency isn't happening
for you, and how do we fix *that* problem.

Ross
Jonathan Liu - May 13, 2013, 9:23 a.m.
I did a git pull which updated connman to 1.13 and rebuilt image from
scratch clearing all temp files and work. The iptables dependency was
missing when I checked with opkg-cl on the target.

Regards,
Jonathan

On 13/05/2013, at 7:05 PM, "Burton, Ross" <ross.burton@intel.com> wrote:

> On 13 May 2013 03:58, Jonathan Liu <net147@gmail.com> wrote:
>> The connmand daemon requires libxtables.so from iptables to start up.
>
> And the automatic dependencies-from-linkage code seems to be working just fine:
>
> $ dpkg -I connman_1.13-r20.0.2_core2.ipk
> ...
> Depends: iptables (>= 1.4.17), dbus-1, ofono, libdbus-1-3 (>= 1.6.8),
> bluez4, libgnutls26 (>= 2.12.21), libc6 (>= 2.17), libglib-2.0-0 (>=
> 2.36.0), shadow, base-passwd, wpa-supplicant
>
> So the question is can you verify that this dependency isn't happening
> for you, and how do we fix *that* problem.
>
> Ross
Ross Burton - May 13, 2013, 10:03 a.m.
On 13 May 2013 10:23, Jonathan Liu <net147@gmail.com> wrote:
> I did a git pull which updated connman to 1.13 and rebuilt image from
> scratch clearing all temp files and work. The iptables dependency was
> missing when I checked with opkg-cl on the target.

I really can't replicate this - my connman packages just built with
latest git have a versioned iptables dependency from the link.  Check
your do_package logs, you should find lines like this:

DEBUG: connman: Dependency libxtables.so.9 requires package iptables

Ross
Jonathan Liu - May 13, 2013, 11:29 a.m.
On 13/05/2013 8:03 PM, Burton, Ross wrote:
> On 13 May 2013 10:23, Jonathan Liu <net147@gmail.com> wrote:
>> I did a git pull which updated connman to 1.13 and rebuilt image from
>> scratch clearing all temp files and work. The iptables dependency was
>> missing when I checked with opkg-cl on the target.
> I really can't replicate this - my connman packages just built with
> latest git have a versioned iptables dependency from the link.  Check
> your do_package logs, you should find lines like this:
>
> DEBUG: connman: Dependency libxtables.so.9 requires package iptables
>
> Ross
The connmand daemon was complaining about libxtables.so.9 missing, but 
it's libxtables.so.10 now.
Maybe I just had to force a more complete rebuild.

Regards,
Jonathan
Ross Burton - May 13, 2013, 2:21 p.m.
On 13 May 2013 12:29, Jonathan Liu <net147@gmail.com> wrote:
> The connmand daemon was complaining about libxtables.so.9 missing, but it's
> libxtables.so.10 now.
> Maybe I just had to force a more complete rebuild.

iptables upgrading should have caused connman to rebuild against the
new iptables and pick up the new dependency, so it's possible that
your machine is pending a connman upgrade if you've been using a feed
to upgrade.  If it's a fresh image, then something went rather wrong.

Ross

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index afc361c..44d9d6e 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -15,7 +15,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
 
 DEPENDS  = "dbus glib-2.0 ppp iptables gnutls"
 
-INC_PR = "r20"
+INC_PR = "r21"
 
 EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
@@ -99,6 +99,7 @@  RPROVIDES_${PN} = "\
 
 RDEPENDS_${PN} = "\
 	dbus \
+	iptables \
 	${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
 	${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
 	${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \