Patchwork [meta-oe,meta-networking] cifs-utils: Add runtime recommendation to CIFS kernel module

login
register
mail settings
Submitter Otavio Salvador
Date May 8, 2013, 5:29 p.m.
Message ID <1368034148-3512-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/49599/
State Accepted
Commit 1eb3e91030cee6d5765a1924b605fb689573c6ad
Headers show

Comments

Otavio Salvador - May 8, 2013, 5:29 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Note: This patch has been tested in master and danny. Please
      consider it for master, dylan and danny branches.

 meta-networking/recipes-support/cifs/cifs-utils_git.bb | 3 +++
 1 file changed, 3 insertions(+)
Joe MacDonald - May 8, 2013, 5:49 p.m.
[[oe] [meta-oe][meta-networking PATCH] cifs-utils: Add runtime recommendation to CIFS kernel module] On 13.05.08 (Wed 14:29) Otavio Salvador wrote:

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Note: This patch has been tested in master and danny. Please
>       consider it for master, dylan and danny branches.
> 
>  meta-networking/recipes-support/cifs/cifs-utils_git.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> index 19b60ad..de2786a 100644
> --- a/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> @@ -5,6 +5,7 @@ LICENSE = "GPLv3 & LGPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>  
>  PV = "5.9"
> +PR = "r1"

For the sake of one patch in all branches, I think we're okay, but in
master we don't actually need PR anymore, do we?

-J.

>  
>  SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
>  SRC_URI = "git://git.samba.org/cifs-utils.git"
> @@ -18,3 +19,5 @@ do_install_append() {
>      # is installed to /sbin
>      rmdir ${D}${bindir} ${D}${sbindir}
>  }
> +
> +RRECOMMENDS_${PN} = "kernel-module-cifs"
Otavio Salvador - May 8, 2013, 5:54 p.m.
On Wed, May 8, 2013 at 2:49 PM, Joe MacDonald
<Joe.MacDonald@windriver.com> wrote:
> [[oe] [meta-oe][meta-networking PATCH] cifs-utils: Add runtime recommendation to CIFS kernel module] On 13.05.08 (Wed 14:29) Otavio Salvador wrote:
>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Note: This patch has been tested in master and danny. Please
>>       consider it for master, dylan and danny branches.
>>
>>  meta-networking/recipes-support/cifs/cifs-utils_git.bb | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
>> index 19b60ad..de2786a 100644
>> --- a/meta-networking/recipes-support/cifs/cifs-utils_git.bb
>> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
>> @@ -5,6 +5,7 @@ LICENSE = "GPLv3 & LGPLv3"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>
>>  PV = "5.9"
>> +PR = "r1"
>
> For the sake of one patch in all branches, I think we're okay, but in
> master we don't actually need PR anymore, do we?

In master it is not required (but still accepted) however to keep the
upgrade path from danny -> dylan -> dylan+1 we need.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Joe MacDonald - May 9, 2013, 6:10 p.m.
[Re: [oe] [meta-oe][meta-networking PATCH] cifs-utils: Add runtime recommendation to CIFS kernel module] On 13.05.08 (Wed 14:54) Otavio Salvador wrote:

> On Wed, May 8, 2013 at 2:49 PM, Joe MacDonald
> <Joe.MacDonald@windriver.com> wrote:
> > [[oe] [meta-oe][meta-networking PATCH] cifs-utils: Add runtime recommendation to CIFS kernel module] On 13.05.08 (Wed 14:29) Otavio Salvador wrote:
> >
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> Note: This patch has been tested in master and danny. Please
> >>       consider it for master, dylan and danny branches.
> >>
> >>  meta-networking/recipes-support/cifs/cifs-utils_git.bb | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >> index 19b60ad..de2786a 100644
> >> --- a/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >> @@ -5,6 +5,7 @@ LICENSE = "GPLv3 & LGPLv3"
> >>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> >>
> >>  PV = "5.9"
> >> +PR = "r1"
> >
> > For the sake of one patch in all branches, I think we're okay, but in
> > master we don't actually need PR anymore, do we?
> 
> In master it is not required (but still accepted) however to keep the
> upgrade path from danny -> dylan -> dylan+1 we need.

Okay, so, merged for master.  Thanks.

Patch

diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
index 19b60ad..de2786a 100644
--- a/meta-networking/recipes-support/cifs/cifs-utils_git.bb
+++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
@@ -5,6 +5,7 @@  LICENSE = "GPLv3 & LGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
 PV = "5.9"
+PR = "r1"
 
 SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
 SRC_URI = "git://git.samba.org/cifs-utils.git"
@@ -18,3 +19,5 @@  do_install_append() {
     # is installed to /sbin
     rmdir ${D}${bindir} ${D}${sbindir}
 }
+
+RRECOMMENDS_${PN} = "kernel-module-cifs"