Patchwork mx28evk: correct settings to make machine work

login
register
mail settings
Submitter Andreas Müller
Date May 28, 2011, 9:29 p.m.
Message ID <1306618191-3066-1-git-send-email-schnitzeltony@gmx.de>
Download mbox | patch
Permalink /patch/4959/
State Superseded
Headers show

Comments

Andreas Müller - May 28, 2011, 9:29 p.m.
Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
---
 conf/machine/include/imx28.inc |    4 ++--
 conf/machine/mx28evk.conf      |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Andreas Müller - June 5, 2011, 1:55 p.m.
On Saturday, May 28, 2011 11:29:51 PM Andreas Mueller wrote:
> Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> ---
>  conf/machine/include/imx28.inc |    4 ++--
>  conf/machine/mx28evk.conf      |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/conf/machine/include/imx28.inc
> b/conf/machine/include/imx28.inc index 38248a8..b50f000 100644
> --- a/conf/machine/include/imx28.inc
> +++ b/conf/machine/include/imx28.inc
> @@ -10,8 +10,8 @@ MACHINE_KERNEL_PR = "r0"
> 
>  KERNEL_IMAGETYPE = "uImage"
> 
> -UBOOT_ENTRYPOINT = "0x8000"
> -UBOOT_LOADADDRESS = "0x8000"
> +UBOOT_ENTRYPOINT = "0x40008000"
> +UBOOT_LOADADDRESS = "0x40008000"
> 
>  EXTRA_IMAGEDEPENDS += "u-boot"
> 
> diff --git a/conf/machine/mx28evk.conf b/conf/machine/mx28evk.conf
> index e093ffa..823b502 100644
> --- a/conf/machine/mx28evk.conf
> +++ b/conf/machine/mx28evk.conf
> @@ -17,7 +17,7 @@ XSERVER = "xserver-kdrive-fbdev"
>  require conf/machine/include/imx28.inc
> 
>  # used by sysvinit_2
> -SERIAL_CONSOLE = "115200 ttymxc0"
> +SERIAL_CONSOLE = "115200 ttyAM0"
> 
>  ROOT_FLASH_SIZE = "128"
Can someone please take a care for this?

regards

Andreas
Paul Menzel - June 5, 2011, 2:09 p.m.
Am Sonntag, den 05.06.2011, 15:55 +0200 schrieb Andreas Mueller:
> On Saturday, May 28, 2011 11:29:51 PM Andreas Mueller wrote:
> > Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> > ---
> >  conf/machine/include/imx28.inc |    4 ++--
> >  conf/machine/mx28evk.conf      |    2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/conf/machine/include/imx28.inc
> > b/conf/machine/include/imx28.inc index 38248a8..b50f000 100644
> > --- a/conf/machine/include/imx28.inc
> > +++ b/conf/machine/include/imx28.inc
> > @@ -10,8 +10,8 @@ MACHINE_KERNEL_PR = "r0"
> > 
> >  KERNEL_IMAGETYPE = "uImage"
> > 
> > -UBOOT_ENTRYPOINT = "0x8000"
> > -UBOOT_LOADADDRESS = "0x8000"
> > +UBOOT_ENTRYPOINT = "0x40008000"
> > +UBOOT_LOADADDRESS = "0x40008000"
> > 
> >  EXTRA_IMAGEDEPENDS += "u-boot"
> > 
> > diff --git a/conf/machine/mx28evk.conf b/conf/machine/mx28evk.conf
> > index e093ffa..823b502 100644
> > --- a/conf/machine/mx28evk.conf
> > +++ b/conf/machine/mx28evk.conf
> > @@ -17,7 +17,7 @@ XSERVER = "xserver-kdrive-fbdev"
> >  require conf/machine/include/imx28.inc
> > 
> >  # used by sysvinit_2
> > -SERIAL_CONSOLE = "115200 ttymxc0"
> > +SERIAL_CONSOLE = "115200 ttyAM0"
> > 
> >  ROOT_FLASH_SIZE = "128"
> Can someone please take a care for this?

I do not have the hardware to test your patch. A elaborate commit
message would be needed.

What is the problem? Why was is committed like this the first place? Was
not it tested? What components changed and most importantly which build
configuration did you use for testing?

If you resend this patch with my questions answered in the commit
message I would be happy to commit your patch.


Thanks,

Paul

Patch

diff --git a/conf/machine/include/imx28.inc b/conf/machine/include/imx28.inc
index 38248a8..b50f000 100644
--- a/conf/machine/include/imx28.inc
+++ b/conf/machine/include/imx28.inc
@@ -10,8 +10,8 @@  MACHINE_KERNEL_PR = "r0"
 
 KERNEL_IMAGETYPE = "uImage"
 
-UBOOT_ENTRYPOINT = "0x8000"
-UBOOT_LOADADDRESS = "0x8000"
+UBOOT_ENTRYPOINT = "0x40008000"
+UBOOT_LOADADDRESS = "0x40008000"
 
 EXTRA_IMAGEDEPENDS += "u-boot"
 
diff --git a/conf/machine/mx28evk.conf b/conf/machine/mx28evk.conf
index e093ffa..823b502 100644
--- a/conf/machine/mx28evk.conf
+++ b/conf/machine/mx28evk.conf
@@ -17,7 +17,7 @@  XSERVER = "xserver-kdrive-fbdev"
 require conf/machine/include/imx28.inc
 
 # used by sysvinit_2
-SERIAL_CONSOLE = "115200 ttymxc0"
+SERIAL_CONSOLE = "115200 ttyAM0"
 
 ROOT_FLASH_SIZE = "128"