Patchwork [meta-oe/meta-gnome,06/15] poppler: remove unrecognized configure options

login
register
mail settings
Submitter Andreas Müller
Date May 7, 2013, 10:41 p.m.
Message ID <1367966513-12566-7-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/49505/
State Accepted, archived
Commit 6619d96a4c518e5484999d885acb4e03a3cc5067
Headers show

Comments

Andreas Müller - May 7, 2013, 10:41 p.m.
warning was:

| configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta-oe/recipes-support/poppler/poppler.inc       |    1 -
 meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
 2 files changed, 0 insertions(+), 3 deletions(-)
Andreas Oberritter - May 10, 2013, 10:30 a.m.
On 08.05.2013 00:41, Andreas Müller wrote:
> warning was:
> 
> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
> 
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
> index d0c0074..11286bc 100644
> --- a/meta-oe/recipes-support/poppler/poppler.inc
> +++ b/meta-oe/recipes-support/poppler/poppler.inc
> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
>      --enable-xpdf-headers \
>      --disable-gtk-test \
>      --disable-poppler-qt \
> -    --disable-poppler-qt4 \
>      --enable-zlib \
>  "

This hunk doesn't match the cited warning.

Regards,
Andreas
Andreas Müller - May 10, 2013, 5:03 p.m.
On Fri, May 10, 2013 at 12:30 PM, Andreas Oberritter
<obi@opendreambox.org> wrote:
> On 08.05.2013 00:41, Andreas Müller wrote:
>> warning was:
>>
>> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
>>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> ---
>>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
>>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
>>  2 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
>> index d0c0074..11286bc 100644
>> --- a/meta-oe/recipes-support/poppler/poppler.inc
>> +++ b/meta-oe/recipes-support/poppler/poppler.inc
>> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
>>      --enable-xpdf-headers \
>>      --disable-gtk-test \
>>      --disable-poppler-qt \
>> -    --disable-poppler-qt4 \
>>      --enable-zlib \
>>  "
>
> This hunk doesn't match the cited warning.
>
> Regards,
> Andreas
Oops - will send a correcting patch.

Andreas
Martin Jansa - May 10, 2013, 5:21 p.m.
On Fri, May 10, 2013 at 07:03:40PM +0200, Andreas Müller wrote:
> On Fri, May 10, 2013 at 12:30 PM, Andreas Oberritter
> <obi@opendreambox.org> wrote:
> > On 08.05.2013 00:41, Andreas Müller wrote:
> >> warning was:
> >>
> >> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
> >>
> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> >> ---
> >>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
> >>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
> >>  2 files changed, 0 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
> >> index d0c0074..11286bc 100644
> >> --- a/meta-oe/recipes-support/poppler/poppler.inc
> >> +++ b/meta-oe/recipes-support/poppler/poppler.inc
> >> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
> >>      --enable-xpdf-headers \
> >>      --disable-gtk-test \
> >>      --disable-poppler-qt \
> >> -    --disable-poppler-qt4 \
> >>      --enable-zlib \
> >>  "
> >
> > This hunk doesn't match the cited warning.
> >
> > Regards,
> > Andreas
> Oops - will send a correcting patch.

I've also noticed that newer poppler fails to build on some
architectures (I know, too late, it was building fine on qemu* on
jenkins, but om-gta02 - armv4t fails with:

| Splash.cc: In member function 'void Splash::drawAALine(SplashPipe*, int, int, int)':
| Splash.cc:1497:19: error: conversion from 'SplashCoord {aka FixedPoint}' to 'Guchar {aka unsigned char}' is ambiguous
|        pipe->shape = aaGamma[t];
|                    ^
| Splash.cc:1497:30: note: candidates are:
|        pipe->shape = aaGamma[t];
|                               ^
| In file included from SplashMath.h:27:0,
|                  from Splash.cc:44:
| ../goo/FixedPoint.h:45:3: note: FixedPoint::operator int()
|    operator int()
|    ^
| ../goo/FixedPoint.h:43:3: note: FixedPoint::operator double()
|    operator double()
|    ^
| ../goo/FixedPoint.h:41:3: note: FixedPoint::operator float()
|    operator float()
|    ^
Andreas Müller - May 12, 2013, 10:35 a.m.
On Fri, May 10, 2013 at 7:21 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, May 10, 2013 at 07:03:40PM +0200, Andreas Müller wrote:
>> On Fri, May 10, 2013 at 12:30 PM, Andreas Oberritter
>> <obi@opendreambox.org> wrote:
>> > On 08.05.2013 00:41, Andreas Müller wrote:
>> >> warning was:
>> >>
>> >> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
>> >>
>> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> >> ---
>> >>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
>> >>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
>> >>  2 files changed, 0 insertions(+), 3 deletions(-)
>> >>
>> >> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
>> >> index d0c0074..11286bc 100644
>> >> --- a/meta-oe/recipes-support/poppler/poppler.inc
>> >> +++ b/meta-oe/recipes-support/poppler/poppler.inc
>> >> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
>> >>      --enable-xpdf-headers \
>> >>      --disable-gtk-test \
>> >>      --disable-poppler-qt \
>> >> -    --disable-poppler-qt4 \
>> >>      --enable-zlib \
>> >>  "
>> >
>> > This hunk doesn't match the cited warning.
>> >
>> > Regards,
>> > Andreas
>> Oops - will send a correcting patch.
>
> I've also noticed that newer poppler fails to build on some
> architectures (I know, too late, it was building fine on qemu* on
> jenkins, but om-gta02 - armv4t fails with:
>
> | Splash.cc: In member function 'void Splash::drawAALine(SplashPipe*, int, int, int)':
> | Splash.cc:1497:19: error: conversion from 'SplashCoord {aka FixedPoint}' to 'Guchar {aka unsigned char}' is ambiguous
> |        pipe->shape = aaGamma[t];
> |                    ^
> | Splash.cc:1497:30: note: candidates are:
> |        pipe->shape = aaGamma[t];
> |                               ^
> | In file included from SplashMath.h:27:0,
> |                  from Splash.cc:44:
> | ../goo/FixedPoint.h:45:3: note: FixedPoint::operator int()
> |    operator int()
> |    ^
> | ../goo/FixedPoint.h:43:3: note: FixedPoint::operator double()
> |    operator double()
> |    ^
> | ../goo/FixedPoint.h:41:3: note: FixedPoint::operator float()
> |    operator float()
> |    ^
>
> --
Can you send me log.do_configure for this?

Andreas
Martin Jansa - May 14, 2013, 4:10 p.m.
On Sun, May 12, 2013 at 12:35:49PM +0200, Andreas Müller wrote:
> On Fri, May 10, 2013 at 7:21 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Fri, May 10, 2013 at 07:03:40PM +0200, Andreas Müller wrote:
> >> On Fri, May 10, 2013 at 12:30 PM, Andreas Oberritter
> >> <obi@opendreambox.org> wrote:
> >> > On 08.05.2013 00:41, Andreas Müller wrote:
> >> >> warning was:
> >> >>
> >> >> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
> >> >>
> >> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> >> >> ---
> >> >>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
> >> >>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
> >> >>  2 files changed, 0 insertions(+), 3 deletions(-)
> >> >>
> >> >> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
> >> >> index d0c0074..11286bc 100644
> >> >> --- a/meta-oe/recipes-support/poppler/poppler.inc
> >> >> +++ b/meta-oe/recipes-support/poppler/poppler.inc
> >> >> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
> >> >>      --enable-xpdf-headers \
> >> >>      --disable-gtk-test \
> >> >>      --disable-poppler-qt \
> >> >> -    --disable-poppler-qt4 \
> >> >>      --enable-zlib \
> >> >>  "
> >> >
> >> > This hunk doesn't match the cited warning.
> >> >
> >> > Regards,
> >> > Andreas
> >> Oops - will send a correcting patch.
> >
> > I've also noticed that newer poppler fails to build on some
> > architectures (I know, too late, it was building fine on qemu* on
> > jenkins, but om-gta02 - armv4t fails with:
> >
> > | Splash.cc: In member function 'void Splash::drawAALine(SplashPipe*, int, int, int)':
> > | Splash.cc:1497:19: error: conversion from 'SplashCoord {aka FixedPoint}' to 'Guchar {aka unsigned char}' is ambiguous
> > |        pipe->shape = aaGamma[t];
> > |                    ^
> > | Splash.cc:1497:30: note: candidates are:
> > |        pipe->shape = aaGamma[t];
> > |                               ^
> > | In file included from SplashMath.h:27:0,
> > |                  from Splash.cc:44:
> > | ../goo/FixedPoint.h:45:3: note: FixedPoint::operator int()
> > |    operator int()
> > |    ^
> > | ../goo/FixedPoint.h:43:3: note: FixedPoint::operator double()
> > |    operator double()
> > |    ^
> > | ../goo/FixedPoint.h:41:3: note: FixedPoint::operator float()
> > |    operator float()
> > |    ^
> >
> > --
> Can you send me log.do_configure for this?

Sorry for late reply, but your patch "poppler: fix build for soft FPU
machines" fixed that already, thanks!
Andreas Müller - May 14, 2013, 4:50 p.m.
On Tue, May 14, 2013 at 6:10 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sun, May 12, 2013 at 12:35:49PM +0200, Andreas Müller wrote:
>> On Fri, May 10, 2013 at 7:21 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > On Fri, May 10, 2013 at 07:03:40PM +0200, Andreas Müller wrote:
>> >> On Fri, May 10, 2013 at 12:30 PM, Andreas Oberritter
>> >> <obi@opendreambox.org> wrote:
>> >> > On 08.05.2013 00:41, Andreas Müller wrote:
>> >> >> warning was:
>> >> >>
>> >> >> | configure: WARNING: unrecognized options: --disable-poppler-qt, --disable-abiword-output
>> >> >>
>> >> >> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> >> >> ---
>> >> >>  meta-oe/recipes-support/poppler/poppler.inc       |    1 -
>> >> >>  meta-oe/recipes-support/poppler/poppler_0.18.4.bb |    2 --
>> >> >>  2 files changed, 0 insertions(+), 3 deletions(-)
>> >> >>
>> >> >> diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
>> >> >> index d0c0074..11286bc 100644
>> >> >> --- a/meta-oe/recipes-support/poppler/poppler.inc
>> >> >> +++ b/meta-oe/recipes-support/poppler/poppler.inc
>> >> >> @@ -11,7 +11,6 @@ EXTRA_OECONF = "\
>> >> >>      --enable-xpdf-headers \
>> >> >>      --disable-gtk-test \
>> >> >>      --disable-poppler-qt \
>> >> >> -    --disable-poppler-qt4 \
>> >> >>      --enable-zlib \
>> >> >>  "
>> >> >
>> >> > This hunk doesn't match the cited warning.
>> >> >
>> >> > Regards,
>> >> > Andreas
>> >> Oops - will send a correcting patch.
>> >
>> > I've also noticed that newer poppler fails to build on some
>> > architectures (I know, too late, it was building fine on qemu* on
>> > jenkins, but om-gta02 - armv4t fails with:
>> >
>> > | Splash.cc: In member function 'void Splash::drawAALine(SplashPipe*, int, int, int)':
>> > | Splash.cc:1497:19: error: conversion from 'SplashCoord {aka FixedPoint}' to 'Guchar {aka unsigned char}' is ambiguous
>> > |        pipe->shape = aaGamma[t];
>> > |                    ^
>> > | Splash.cc:1497:30: note: candidates are:
>> > |        pipe->shape = aaGamma[t];
>> > |                               ^
>> > | In file included from SplashMath.h:27:0,
>> > |                  from Splash.cc:44:
>> > | ../goo/FixedPoint.h:45:3: note: FixedPoint::operator int()
>> > |    operator int()
>> > |    ^
>> > | ../goo/FixedPoint.h:43:3: note: FixedPoint::operator double()
>> > |    operator double()
>> > |    ^
>> > | ../goo/FixedPoint.h:41:3: note: FixedPoint::operator float()
>> > |    operator float()
>> > |    ^
>> >
>> > --
>> Can you send me log.do_configure for this?
>
> Sorry for late reply, but your patch "poppler: fix build for soft FPU
> machines" fixed that already, thanks!
>
No problem - a built for om-gta02 overnight showed the error situation.

Andreas

Patch

diff --git a/meta-oe/recipes-support/poppler/poppler.inc b/meta-oe/recipes-support/poppler/poppler.inc
index d0c0074..11286bc 100644
--- a/meta-oe/recipes-support/poppler/poppler.inc
+++ b/meta-oe/recipes-support/poppler/poppler.inc
@@ -11,7 +11,6 @@  EXTRA_OECONF = "\
     --enable-xpdf-headers \
     --disable-gtk-test \
     --disable-poppler-qt \
-    --disable-poppler-qt4 \
     --enable-zlib \
 "
 
diff --git a/meta-oe/recipes-support/poppler/poppler_0.18.4.bb b/meta-oe/recipes-support/poppler/poppler_0.18.4.bb
index 2f4927b..6a9dbbe 100644
--- a/meta-oe/recipes-support/poppler/poppler_0.18.4.bb
+++ b/meta-oe/recipes-support/poppler/poppler_0.18.4.bb
@@ -2,8 +2,6 @@  require poppler.inc
 
 DEPENDS += "lcms"
 
-EXTRA_OECONF_append = " --disable-abiword-output "
-
 RDEPENDS_${PN} = "poppler-data"
 
 SRC_URI[md5sum] = "12658f3308597e57f3faff538cc73baf"