Patchwork gstreamer: Fixed dependency problem with -meta packages

login
register
mail settings
Submitter Carlos Rafael Giani
Date May 5, 2013, 8:50 p.m.
Message ID <1367787030-5056-1-git-send-email-dv@pseudoterminal.org>
Download mbox | patch
Permalink /patch/49337/
State New
Headers show

Comments

Carlos Rafael Giani - May 5, 2013, 8:50 p.m.
Installing the gstreamer -meta packages was not possible, because the
-apps and -glib packages were missing. Allowing for empty -apps/glib
packages fixes this.

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Ross Burton - May 7, 2013, 9:55 a.m.
On 5 May 2013 21:50, Carlos Rafael Giani <dv@pseudoterminal.org> wrote:
> Installing the gstreamer -meta packages was not possible, because the
> -apps and -glib packages were missing. Allowing for empty -apps/glib
> packages fixes this.

From what I can tell there's only one -apps package
(gst-plugins-base-apps) and one -glib package (gst-plugins-bad-glib),
so why not add those extra dependencies in -base and -bad explicitly
instead of creating empty packages for no reason?

Ross
Carlos Rafael Giani - May 7, 2013, 10:29 a.m.
On 05/07/2013 11:55 AM, Burton, Ross wrote:
> On 5 May 2013 21:50, Carlos Rafael Giani <dv@pseudoterminal.org> wrote:
>> Installing the gstreamer -meta packages was not possible, because the
>> -apps and -glib packages were missing. Allowing for empty -apps/glib
>> packages fixes this.
>  From what I can tell there's only one -apps package
> (gst-plugins-base-apps) and one -glib package (gst-plugins-bad-glib),
> so why not add those extra dependencies in -base and -bad explicitly
> instead of creating empty packages for no reason?
>
> Ross

True, however I wonder if somebody relies on these packages being there.
Is it acceptable to break compatibility here?
Ross Burton - May 7, 2013, 10:55 a.m.
On 7 May 2013 11:29, Carlos Rafael Giani <dv@pseudoterminal.org> wrote:
> True, however I wonder if somebody relies on these packages being there.
> Is it acceptable to break compatibility here?

They haven't been there for a while and 1.4 is shipping without them
so I'd endorse cleaning them up instead of having empty packages.

Ross

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
index 7ae3ef6..9cab392 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
@@ -25,9 +25,12 @@  python populate_packages_prepend () {
 }
 
 # metapkg has runtime dependency on PN
-# each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev
+# each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev,
+# and plugin-meta on plugin-glib and plugin-apps
 # so we need them even when empty (like in gst-plugins-good case)
 ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-apps = "1"
+ALLOW_EMPTY_${PN}-glib = "1"
 ALLOW_EMPTY_${PN}-dev = "1"
 ALLOW_EMPTY_${PN}-staticdev = "1"