Patchwork [v2,2/3] neard: Use SRCREV instead of SRCPV

login
register
mail settings
Submitter Jukka Rissanen
Date May 2, 2013, 2:56 p.m.
Message ID <1367506593-11381-3-git-send-email-jukka.rissanen@linux.intel.com>
Download mbox | patch
Permalink /patch/49253/
State New
Headers show

Comments

Jukka Rissanen - May 2, 2013, 2:56 p.m.
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
 meta/recipes-connectivity/neard/neard_0.10.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - May 2, 2013, 3:39 p.m.
On Thu, May 02, 2013 at 05:56:32PM +0300, Jukka Rissanen wrote:
> 
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
>  meta/recipes-connectivity/neard/neard_0.10.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/neard/neard_0.10.bb b/meta/recipes-connectivity/neard/neard_0.10.bb
> index dc43f7e..b9198af 100644
> --- a/meta/recipes-connectivity/neard/neard_0.10.bb
> +++ b/meta/recipes-connectivity/neard/neard_0.10.bb
> @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>  
>  S = "${WORKDIR}/git"
>  SRCREV = "eb486bf35e24d7d1db61350f5ab393a0c880523d"
> -PV = "0.10+git${SRCPV}"
> +PV = "0.10+git${SRCREV}"

Why? SRCPV is better.

>  PR = "r0"
>  
>  inherit autotools pkgconfig systemd update-rc.d
> -- 
> 1.7.11.7
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Ross Burton - May 2, 2013, 4:11 p.m.
On 2 May 2013 16:39, Martin Jansa <martin.jansa@gmail.com> wrote:
>> -PV = "0.10+git${SRCPV}"
>> +PV = "0.10+git${SRCREV}"

As the git revision is the 0.10 tag, wouldn't it be clearer to not set
PV as the git revision is a detail of the fetcher - this *is* 0.10.

Ross
Martin Jansa - May 2, 2013, 4:46 p.m.
On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote:
> On 2 May 2013 16:39, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> -PV = "0.10+git${SRCPV}"
> >> +PV = "0.10+git${SRCREV}"
> 
> As the git revision is the 0.10 tag, wouldn't it be clearer to not set
> PV as the git revision is a detail of the fetcher - this *is* 0.10.

That's fine too as long as nobody bumps SRCREV without updating PV or
uses AUTOREV from some .inc or local.conf.
Richard Purdie - May 3, 2013, 3:36 p.m.
On Thu, 2013-05-02 at 18:46 +0200, Martin Jansa wrote:
> On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote:
> > On 2 May 2013 16:39, Martin Jansa <martin.jansa@gmail.com> wrote:
> > >> -PV = "0.10+git${SRCPV}"
> > >> +PV = "0.10+git${SRCREV}"
> > 
> > As the git revision is the 0.10 tag, wouldn't it be clearer to not set
> > PV as the git revision is a detail of the fetcher - this *is* 0.10.
> 
> That's fine too as long as nobody bumps SRCREV without updating PV or
> uses AUTOREV from some .inc or local.conf.

Agreed, regardless, SRCREV in PV is not correct, we shouldn't do that
and we have SRCPV for a reason.

Cheers,

Richard

Patch

diff --git a/meta/recipes-connectivity/neard/neard_0.10.bb b/meta/recipes-connectivity/neard/neard_0.10.bb
index dc43f7e..b9198af 100644
--- a/meta/recipes-connectivity/neard/neard_0.10.bb
+++ b/meta/recipes-connectivity/neard/neard_0.10.bb
@@ -16,7 +16,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
 
 S = "${WORKDIR}/git"
 SRCREV = "eb486bf35e24d7d1db61350f5ab393a0c880523d"
-PV = "0.10+git${SRCPV}"
+PV = "0.10+git${SRCREV}"
 PR = "r0"
 
 inherit autotools pkgconfig systemd update-rc.d