Patchwork fs-perms.txt: Don't tinker with file modes in /usr/src/debug

login
register
mail settings
Submitter Phil Blundell
Date May 2, 2013, 1:55 p.m.
Message ID <1367502902.14512.256.camel@phil-desktop.brightsign>
Download mbox | patch
Permalink /patch/49247/
State Accepted
Commit 53276bc7243fbb8d667b5a6c4a2c16d8f6861aed
Headers show

Comments

Phil Blundell - May 2, 2013, 1:55 p.m.
Since 6775feb9fe935ab01fd9cae2b2d3fce5824a9a72 our local "copy" of the
debug sources has in fact been hardlinked to ${S} and potentially other
places too.  This means that any modifications we make to these files
might have wider consequences than intended.

Avoid this potential pitfall by telling fixup_perms() to leave the file
modes in this directory alone.  No great harm will result from shipping
debug sources with a mode other than 0644: if the mode was permissive
enough for us to compile the sources in the first place then it must
also be permissive enough for subsequent debugging.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/files/fs-perms.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Mark Hatle - May 2, 2013, 2:07 p.m.
On 5/2/13 8:55 AM, Phil Blundell wrote:
> Since 6775feb9fe935ab01fd9cae2b2d3fce5824a9a72 our local "copy" of the
> debug sources has in fact been hardlinked to ${S} and potentially other
> places too.  This means that any modifications we make to these files
> might have wider consequences than intended.
>
> Avoid this potential pitfall by telling fixup_perms() to leave the file
> modes in this directory alone.  No great harm will result from shipping
> debug sources with a mode other than 0644: if the mode was permissive
> enough for us to compile the sources in the first place then it must
> also be permissive enough for subsequent debugging.

I'm fine with this as long as the uid/gid is set to root.  (it is below)

Acked-by: Mark Hatle <mark.hatle@windriver.com>

> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
>   meta/files/fs-perms.txt |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index ef44e26..becb85c 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -41,7 +41,7 @@ ${includedir}		0755	root	root	true	0644	root	root
>   ${oldincludedir}	0755	root	root	true	0644	root	root
>
>   # Cleanup debug src
> -/usr/src/debug		0755	root	root	true	0644	root	root
> +/usr/src/debug		0755	root	root	true	-	root	root
>
>   # Items from base-files
>   # Links
>

Patch

diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
index ef44e26..becb85c 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms.txt
@@ -41,7 +41,7 @@  ${includedir}		0755	root	root	true	0644	root	root
 ${oldincludedir}	0755	root	root	true	0644	root	root
 
 # Cleanup debug src
-/usr/src/debug		0755	root	root	true	0644	root	root
+/usr/src/debug		0755	root	root	true	-	root	root
 
 # Items from base-files
 # Links