Patchwork [2/5] bitbake.conf: set SERIAL_CONSOLES from SERIAL_CONSOLE by default

login
register
mail settings
Submitter Paul Eggleton
Date April 30, 2013, 4:52 p.m.
Message ID <c4a83801dc67074b524dd33c56ba9eed819def6f.1367340369.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/49185/
State Accepted
Commit c09809f0609beb27e5670d69cbdcf713fb884f7b
Headers show

Comments

Paul Eggleton - April 30, 2013, 4:52 p.m.
This is the first step in deprecating SERIAL_CONSOLE without affecting
machine configurations that still use it.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)
Khem Raj - April 30, 2013, 9:42 p.m.
On Apr 30, 2013, at 9:52 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> This is the first step in deprecating SERIAL_CONSOLE without affecting
> machine configurations that still use it.

Did you mean deprecating SERIAL_CONSOLES or SERIAL_CONSOLE
Paul Eggleton - May 1, 2013, 6:51 a.m.
On Tuesday 30 April 2013 14:42:46 Khem Raj wrote:
> On Apr 30, 2013, at 9:52 AM, Paul Eggleton <paul.eggleton@linux.intel.com> 
wrote:
> > This is the first step in deprecating SERIAL_CONSOLE without affecting
> > machine configurations that still use it.
> 
> Did you mean deprecating SERIAL_CONSOLES or SERIAL_CONSOLE

I mean deprecating SERIAL_CONSOLE. SERIAL_CONSOLES is the newer replacement, 
supporting multiple consoles e.g.

SERIAL_CONSOLES = "115200;ttyS0 38400;ttyS1"

Cheers,
Paul
Khem Raj - May 1, 2013, 5:07 p.m.
On Apr 30, 2013, at 11:51 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> On Tuesday 30 April 2013 14:42:46 Khem Raj wrote:
>> On Apr 30, 2013, at 9:52 AM, Paul Eggleton <paul.eggleton@linux.intel.com> 
> wrote:
>>> This is the first step in deprecating SERIAL_CONSOLE without affecting
>>> machine configurations that still use it.
>> 
>> Did you mean deprecating SERIAL_CONSOLES or SERIAL_CONSOLE
> 
> I mean deprecating SERIAL_CONSOLE. SERIAL_CONSOLES is the newer replacement, 
> supporting multiple consoles e.g.
> 
> SERIAL_CONSOLES = "115200;ttyS0 38400;ttyS1"
> 


yes thanks

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 075f812..d5e923b 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -745,6 +745,9 @@  COMBINED_FEATURES = "\
     ${@base_both_contain("DISTRO_FEATURES", "MACHINE_FEATURES", "wifi", d)}"
 COMBINED_FEATURES[vardeps] += "DISTRO_FEATURES MACHINE_FEATURES"
 
+SERIAL_CONSOLE ??= ""
+SERIAL_CONSOLES ??= "${@d.getVar('SERIAL_CONSOLE', True).replace(' ', ';')}"
+
 # Make sure MACHINE isn't exported
 # (breaks binutils at least)
 MACHINE[unexport] = "1"