Patchwork [0/5] SERIAL_CONSOLES improvements

login
register
mail settings
Submitter Paul Eggleton
Date April 30, 2013, 4:52 p.m.
Message ID <cover.1367340369.git.paul.eggleton@linux.intel.com>
Download mbox
Permalink /patch/49183/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib paule/serial-consoles

Comments

Paul Eggleton - April 30, 2013, 4:52 p.m.
Having two variables to enable essentially the same behaviour isn't
really desirable, so fix up the handling of SERIAL_CONSOLES, set it
from SERIAL_CONSOLE by default if not set and change everwhere we read
SERIAL_CONSOLE to read from SERIAL_CONSOLES instead. This should allow
us to deprecate SERIAL_CONSOLE whilst retaining compatibility with
machine configurations that still use it. 

Note: I'm a bit concerned about the default setting of SERIAL_CONSOLE in
systemd-serialgetty; I'm not sure why this is needed given that this is
almost always going to be machine-specific. I've left it alone for the
time being however.


The following changes since commit e86538db13605953465aacc3f2fb7d719dad919e:

  neard: add systemd unit file (2013-04-29 15:31:39 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/serial-consoles
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/serial-consoles

Paul Eggleton (5):
  sysvinit-inittab: ensure unique label for SERIAL_CONSOLES entries
  bitbake.conf: set SERIAL_CONSOLES from SERIAL_CONSOLE by default
  sysvinit-inittab: remove specific handling of SERIAL_CONSOLE
  shadow-securetty: change to handle SERIAL_CONSOLES
  systemd-serialgetty: change to handle SERIAL_CONSOLES

 meta/conf/bitbake.conf                             |  3 ++
 meta/recipes-core/systemd/systemd-serialgetty.bb   | 45 +++++++++++-----------
 .../sysvinit/sysvinit-inittab_2.88dsf.bb           | 11 ++----
 .../shadow/shadow-securetty_4.1.4.3.bb             | 20 ++++++----
 4 files changed, 42 insertions(+), 37 deletions(-)
Koen Kooi - May 1, 2013, 7:14 a.m.
Op 30 apr. 2013, om 18:52 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> Having two variables to enable essentially the same behaviour isn't
> really desirable, so fix up the handling of SERIAL_CONSOLES, set it
> from SERIAL_CONSOLE by default if not set and change everwhere we read
> SERIAL_CONSOLE to read from SERIAL_CONSOLES instead. This should allow
> us to deprecate SERIAL_CONSOLE whilst retaining compatibility with
> machine configurations that still use it. 
> 
> Note: I'm a bit concerned about the default setting of SERIAL_CONSOLE in
> systemd-serialgetty; I'm not sure why this is needed given that this is
> almost always going to be machine-specific. I've left it alone for the
> time being however.

It is always machine specific, but at the time of writing SERIAL_CONSOLE wasn't being set by all machines leading to parse failures.

regards,

Koen