Patchwork [meta-fsl-arm,for-danny] gst-fsl-plugin: add fsl-mm-mp3enc and fsl-mm-flv dependences

login
register
mail settings
Submitter Javier Viguera
Date April 30, 2013, 4:41 p.m.
Message ID <1367340079-46225-1-git-send-email-javier.viguera@digi.com>
Download mbox | patch
Permalink /patch/49157/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Javier Viguera - April 30, 2013, 4:41 p.m.
For MX5 machines, gst-fsl-plugin has build-time dependences on the
pre-built fsl-mm-mp3enc and fsl-mm-flv codec libraries.

If the mp3enc library is not in the sysroot, the 'libmfw_gst_mp3enc.so'
is not built.

If the fsl-mm-flv is not in the sysroot, the configure process warns
about:

"Unable to determine soname of lib_flv_parser_arm9_elinux.3.0.so
library"

and the resulting 'aiur_registry.arm11.cf' gets a wrong entry for
flv_parser library.

Signed-off-by: Javier Viguera <javier.viguera@digi.com>
---
 recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Daiane Angolini - April 30, 2013, 6:03 p.m.
On 04/30/2013 01:41 PM, Javier Viguera wrote:
> For MX5 machines, gst-fsl-plugin has build-time dependences on the
> pre-built fsl-mm-mp3enc and fsl-mm-flv codec libraries.
>
> If the mp3enc library is not in the sysroot, the 'libmfw_gst_mp3enc.so'
> is not built.
>
> If the fsl-mm-flv is not in the sysroot, the configure process warns
> about:
>
> "Unable to determine soname of lib_flv_parser_arm9_elinux.3.0.so
> library"
>
> and the resulting 'aiur_registry.arm11.cf' gets a wrong entry for
> flv_parser library.

Thanks a lot. It's an important bug fix and I think it can be used on 
danny/dylan/master.

Could you, please, rebase your patch to master? It will firstly be 
applied on master.

Could you, please, resend your patch? Please take a look here for how to 
submit the patch.
http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/README

As soon as you have resent it I will test it on imx53qsb

I think you can keep your description and subject ;-)


>
> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> ---
>   recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
> index 5db3f6f..c9074a3 100644
> --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
> +++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
> @@ -2,8 +2,8 @@
>   # Released under the MIT license (see COPYING.MIT for the terms)
>
>   require gst-fsl-plugin.inc
> -DEPENDS += "fsl-mm-codeclib"
> -RDEPENDS_${PN} = "fsl-mm-codeclib"
> +DEPENDS += "fsl-mm-codeclib fsl-mm-flv-codeclib fsl-mm-mp3enc-codeclib"
> +RDEPENDS_${PN} = "fsl-mm-codeclib fsl-mm-flv-codeclib fsl-mm-mp3enc-codeclib"
>
>   PR = "${INC_PR}.2"
>

Otavio, to bump, or not to bump?
Otavio Salvador - April 30, 2013, 6:12 p.m.
On Tue, Apr 30, 2013 at 3:03 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/30/2013 01:41 PM, Javier Viguera wrote:
>>
>> For MX5 machines, gst-fsl-plugin has build-time dependences on the
>> pre-built fsl-mm-mp3enc and fsl-mm-flv codec libraries.
>>
>> If the mp3enc library is not in the sysroot, the 'libmfw_gst_mp3enc.so'
>> is not built.
>>
>> If the fsl-mm-flv is not in the sysroot, the configure process warns
>> about:
>>
>> "Unable to determine soname of lib_flv_parser_arm9_elinux.3.0.so
>> library"
>>
>> and the resulting 'aiur_registry.arm11.cf' gets a wrong entry for
>> flv_parser library.
>
>
> Thanks a lot. It's an important bug fix and I think it can be used on
> danny/dylan/master.
>
> Could you, please, rebase your patch to master? It will firstly be applied
> on master.
>
> Could you, please, resend your patch? Please take a look here for how to
> submit the patch.
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/README
>
> As soon as you have resent it I will test it on imx53qsb
>
> I think you can keep your description and subject ;-)
>
>
>
>>
>> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
>> ---
>>   recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
>> b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
>> index 5db3f6f..c9074a3 100644
>> --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
>> +++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
>> @@ -2,8 +2,8 @@
>>   # Released under the MIT license (see COPYING.MIT for the terms)
>>
>>   require gst-fsl-plugin.inc
>> -DEPENDS += "fsl-mm-codeclib"
>> -RDEPENDS_${PN} = "fsl-mm-codeclib"
>> +DEPENDS += "fsl-mm-codeclib fsl-mm-flv-codeclib fsl-mm-mp3enc-codeclib"
>> +RDEPENDS_${PN} = "fsl-mm-codeclib fsl-mm-flv-codeclib
>> fsl-mm-mp3enc-codeclib"
>>
>>   PR = "${INC_PR}.2"
>>
>
> Otavio, to bump, or not to bump?

As it is intended to be backported it needs to be bumped or we break
upgrade path.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
index 5db3f6f..c9074a3 100644
--- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
+++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_2.0.3.bb
@@ -2,8 +2,8 @@ 
 # Released under the MIT license (see COPYING.MIT for the terms)
 
 require gst-fsl-plugin.inc
-DEPENDS += "fsl-mm-codeclib"
-RDEPENDS_${PN} = "fsl-mm-codeclib"
+DEPENDS += "fsl-mm-codeclib fsl-mm-flv-codeclib fsl-mm-mp3enc-codeclib"
+RDEPENDS_${PN} = "fsl-mm-codeclib fsl-mm-flv-codeclib fsl-mm-mp3enc-codeclib"
 
 PR = "${INC_PR}.2"