Patchwork systemd: do not recommend udev-extraconf for udev

login
register
mail settings
Submitter Andreas Müller
Date April 30, 2013, 7:31 a.m.
Message ID <1367307108-18479-1-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/49119/
State Accepted
Commit 860cd2f9ba5803824ab59bf9c0e84b83f7907dc1
Headers show

Comments

Andreas Müller - April 30, 2013, 7:31 a.m.
* adding this extra functionality is an image- or distro-decision
* at least automount-rule/script breaks other automount solutions causing
  misleading kernel messages as 'VFS: could not find a valid V7 on sda'

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/recipes-core/systemd/systemd_199.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Ross Burton - April 30, 2013, 9:09 a.m.
On 30 April 2013 08:31, Andreas Müller <schnitzeltony@googlemail.com> wrote:
> * adding this extra functionality is an image- or distro-decision
> * at least automount-rule/script breaks other automount solutions causing
>   misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>

If you're going to do this, please also do udev at the same time.

Ross
Ross Burton - April 30, 2013, 9:11 a.m.
On 30 April 2013 10:09, Burton, Ross <ross.burton@intel.com> wrote:
> On 30 April 2013 08:31, Andreas Müller <schnitzeltony@googlemail.com> wrote:
>> * adding this extra functionality is an image- or distro-decision
>> * at least automount-rule/script breaks other automount solutions causing
>>   misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>>
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>
> If you're going to do this, please also do udev at the same time.

Oh, and the images in oe-core need to be fixed to bring in
udev-extraconf as required.  The initramfs does already, but then we
need to have the debate on what other images should.  core-image-sato
certainly should depend on it, but what about core-image-minimal and
so on?

Ross
Koen Kooi - April 30, 2013, 9:12 a.m.
Op 30 apr. 2013, om 09:31 heeft Andreas Müller <schnitzeltony@googlemail.com> het volgende geschreven:

> * adding this extra functionality is an image- or distro-decision
> * at least automount-rule/script breaks other automount solutions causing
>  misleading kernel messages as 'VFS: could not find a valid V7 on sda'
> 
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>

Looks a lot like http://patches.openembedded.org/patch/48139/ :)
Koen Kooi - April 30, 2013, 9:14 a.m.
Op 30 apr. 2013, om 11:09 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 30 April 2013 08:31, Andreas Müller <schnitzeltony@googlemail.com> wrote:
>> * adding this extra functionality is an image- or distro-decision
>> * at least automount-rule/script breaks other automount solutions causing
>>  misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>> 
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> 
> If you're going to do this, please also do udev at the same time.

http://patches.openembedded.org/patch/48183/
Koen Kooi - April 30, 2013, 9:21 a.m.
Op 30 apr. 2013, om 11:11 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 30 April 2013 10:09, Burton, Ross <ross.burton@intel.com> wrote:
>> On 30 April 2013 08:31, Andreas Müller <schnitzeltony@googlemail.com> wrote:
>>> * adding this extra functionality is an image- or distro-decision
>>> * at least automount-rule/script breaks other automount solutions causing
>>>  misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>>> 
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> 
>> If you're going to do this, please also do udev at the same time.
> 
> Oh, and the images in oe-core need to be fixed to bring in
> udev-extraconf as required.  The initramfs does already, but then we
> need to have the debate on what other images should.  core-image-sato
> certainly should depend on it, but what about core-image-minimal and
> so on?

If you want people to use those images as a base for their own image: don't drag in udev-extraconf
Andreas Müller - April 30, 2013, 9:25 a.m.
On Tue, Apr 30, 2013 at 11:14 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 30 apr. 2013, om 11:09 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:
>
>> On 30 April 2013 08:31, Andreas Müller <schnitzeltony@googlemail.com> wrote:
>>> * adding this extra functionality is an image- or distro-decision
>>> * at least automount-rule/script breaks other automount solutions causing
>>>  misleading kernel messages as 'VFS: could not find a valid V7 on sda'
>>>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>>
>> If you're going to do this, please also do udev at the same time.
>
> http://patches.openembedded.org/patch/48183/
Suggestion / to be discussed:

* same for udev 182
* add udev-extraconf to core-image-sato
* add to core-image-minimal
* ?

Andreas
Ross Burton - April 30, 2013, 9:26 a.m.
On 30 April 2013 10:21, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Oh, and the images in oe-core need to be fixed to bring in
>> udev-extraconf as required.  The initramfs does already, but then we
>> need to have the debate on what other images should.  core-image-sato
>> certainly should depend on it, but what about core-image-minimal and
>> so on?
>
> If you want people to use those images as a base for their own image: don't drag in udev-extraconf

Sato should as that's basically been part of the defined experience.
minimal was basically a strawman - obviously it shouldn't.  It's the
others which are more debatable.  A series that removes udev-extraconf
from udev and systemd, then adds it to core-image-sato in some way
sounds good to me.

Ross

Patch

diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
index 43463c5..08cb0c6 100644
--- a/meta/recipes-core/systemd/systemd_199.bb
+++ b/meta/recipes-core/systemd/systemd_199.bb
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
 PROVIDES = "udev"
 
 PE = "1"
-PR = "r3"
+PR = "r4"
 
 DEPENDS = "kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers glib-2.0"
 DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
@@ -211,7 +211,7 @@  FILES_udev-dbg += "/lib/udev/.debug"
 
 RDEPENDS_udev += "udev-utils"
 RPROVIDES_udev = "hotplug"
-RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
+RRECOMMENDS_udev += "udev-hwdb"
 
 FILES_udev += "${base_sbindir}/udevd \
                ${rootlibexecdir}/systemd/systemd-udevd \