Patchwork xkeyboard-config: Remove xkbcomp from RDEPENDS_${PN}

login
register
mail settings
Submitter Phil Blundell
Date April 29, 2013, 12:57 p.m.
Message ID <1367240260.14512.120.camel@phil-desktop.brightsign>
Download mbox | patch
Permalink /patch/49045/
State Accepted
Commit 2c5dbc9291b4c77457a5f7d5ea96f586acf7f902
Headers show

Comments

Phil Blundell - April 29, 2013, 12:57 p.m.
Nothing in this package uses xkbcomp so depending on it here is not appropriate.
Whatever package(s) is/are invoking that binary should be the ones to depend
on it.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb |    1 -
 1 file changed, 1 deletion(-)
Gary Thomas - May 7, 2013, 3:13 p.m.
On 2013-04-29 06:57, Phil Blundell wrote:
> Nothing in this package uses xkbcomp so depending on it here is not appropriate.
> Whatever package(s) is/are invoking that binary should be the ones to depend
> on it.
>
> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
>   meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb b/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
> index ccb9f74..cf4da28 100644
> --- a/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
> +++ b/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
> @@ -23,7 +23,6 @@ PR = "r0"
>
>   EXTRA_OECONF = "--with-xkb-rules-symlink=xorg --disable-runtime-deps"
>
> -RDEPENDS_${PN} += "xkbcomp"
>   FILES_${PN} += "${datadir}/X11/xkb"
>
>   inherit autotools pkgconfig
>

It looks like the package(s) you're referring to are the X server.
Too bad you didn't provide those patches as well as images which
use X are currently broken (at least mine are)
Ross Burton - May 7, 2013, 3:23 p.m.
On 7 May 2013 16:13, Gary Thomas <gary@mlbassoc.com> wrote:
> It looks like the package(s) you're referring to are the X server.
> Too bad you didn't provide those patches as well as images which
> use X are currently broken (at least mine are)

Yeah, I noticed that when browsing mail over breakfast but dropped the
ball in actually saying on the list.  Add a dependency to it in
xserver-xorg.

Ross
Gary Thomas - May 7, 2013, 3:43 p.m.
On 2013-05-07 09:23, Burton, Ross wrote:
> On 7 May 2013 16:13, Gary Thomas <gary@mlbassoc.com> wrote:
>> It looks like the package(s) you're referring to are the X server.
>> Too bad you didn't provide those patches as well as images which
>> use X are currently broken (at least mine are)
>
> Yeah, I noticed that when browsing mail over breakfast but dropped the
> ball in actually saying on the list.  Add a dependency to it in
> xserver-xorg.

I'll put something together shortly.
Stanacar, StefanX - May 7, 2013, 3:47 p.m.
On Tue, 2013-05-07 at 09:43 -0600, Gary Thomas wrote:
> On 2013-05-07 09:23, Burton, Ross wrote:
> > On 7 May 2013 16:13, Gary Thomas <gary@mlbassoc.com> wrote:
> >> It looks like the package(s) you're referring to are the X server.
> >> Too bad you didn't provide those patches as well as images which
> >> use X are currently broken (at least mine are)
> >
> > Yeah, I noticed that when browsing mail over breakfast but dropped the
> > ball in actually saying on the list.  Add a dependency to it in
> > xserver-xorg.
> 
> I'll put something together shortly.
> 

I didn't noticed your reply until now, I just sent a patch... :)
Gary Thomas - May 7, 2013, 3:56 p.m.
On 2013-05-07 09:47, Stanacar, StefanX wrote:
>
>
> On Tue, 2013-05-07 at 09:43 -0600, Gary Thomas wrote:
>> On 2013-05-07 09:23, Burton, Ross wrote:
>>> On 7 May 2013 16:13, Gary Thomas <gary@mlbassoc.com> wrote:
>>>> It looks like the package(s) you're referring to are the X server.
>>>> Too bad you didn't provide those patches as well as images which
>>>> use X are currently broken (at least mine are)
>>>
>>> Yeah, I noticed that when browsing mail over breakfast but dropped the
>>> ball in actually saying on the list.  Add a dependency to it in
>>> xserver-xorg.
>>
>> I'll put something together shortly.
>>
>
> I didn't noticed your reply until now, I just sent a patch... :)
>

Thanks, it looks good to me.

Patch

diff --git a/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb b/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
index ccb9f74..cf4da28 100644
--- a/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
+++ b/meta/recipes-graphics/xorg-lib/xkeyboard-config_2.8.bb
@@ -23,7 +23,6 @@  PR = "r0"
 
 EXTRA_OECONF = "--with-xkb-rules-symlink=xorg --disable-runtime-deps"
 
-RDEPENDS_${PN} += "xkbcomp"
 FILES_${PN} += "${datadir}/X11/xkb"
 
 inherit autotools pkgconfig